[Libreoffice-commits] core.git: vcl/osx

Niklas Johansson sleeping.pillow at gmail.com
Thu Nov 20 03:26:59 PST 2014


 vcl/osx/a11yrolehelper.mm   |    2 +-
 vcl/osx/a11ywrapper.mm      |    2 +-
 vcl/osx/a11ywrappergroup.mm |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit a669de9c151692a8c24929641a7c12617b1bf458
Author: Niklas Johansson <sleeping.pillow at gmail.com>
Date:   Thu Nov 20 12:01:44 2014 +0100

    [Accessibility] Make the sidebar a bit accessible
    
    The accessibility of the sidebar is heavily built on PANEL's.
    Since A11y on mac ignored panels it did not pan out well.
    Also the title was removed from AXGroupRole but is needed
    to announce the different panels of the sidebar.
    
    This might have some unwanted effects on other parts of
    LibreOffice since a lot of things are built up from
    AccessibleRole::PANEL.
    
    Change-Id: I095d26b3c89e2c0403d3267baa53f3bec5e07662
    Reviewed-on: https://gerrit.libreoffice.org/12985
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/osx/a11yrolehelper.mm b/vcl/osx/a11yrolehelper.mm
index 45423db..8d14fc7 100644
--- a/vcl/osx/a11yrolehelper.mm
+++ b/vcl/osx/a11yrolehelper.mm
@@ -96,7 +96,7 @@ using namespace ::com::sun::star::uno;
         MAP( AccessibleRole::SEPARATOR, NSAccessibilitySplitterRole ); // FIXME
         MAP( AccessibleRole::SLIDER, NSAccessibilitySliderRole );
         MAP( AccessibleRole::SPIN_BOX, NSAccessibilityUnknownRole ); // FIXME
-        MAP( AccessibleRole::SPLIT_PANE, NSAccessibilitySplitterRole );
+        MAP( AccessibleRole::SPLIT_PANE, NSAccessibilitySplitGroupRole );
         MAP( AccessibleRole::STATUS_BAR, NSAccessibilityGroupRole ); // FIXME
         MAP( AccessibleRole::TABLE, NSAccessibilityTableRole );
         MAP( AccessibleRole::TABLE_CELL, NSAccessibilityTextFieldRole );
diff --git a/vcl/osx/a11ywrapper.mm b/vcl/osx/a11ywrapper.mm
index 4e19e1d..aca05cb 100644
--- a/vcl/osx/a11ywrapper.mm
+++ b/vcl/osx/a11ywrapper.mm
@@ -718,7 +718,7 @@ static std::ostream &operator<<(std::ostream &s, NSPoint point) {
     BOOL ignored = NO;
     sal_Int16 nRole = [ self accessibleContext ] -> getAccessibleRole();
     switch ( nRole ) {
-        case AccessibleRole::PANEL:
+        //case AccessibleRole::PANEL:
         case AccessibleRole::FRAME:
         case AccessibleRole::ROOT_PANE:
         case AccessibleRole::SEPARATOR:
diff --git a/vcl/osx/a11ywrappergroup.mm b/vcl/osx/a11ywrappergroup.mm
index 3eb864f..04c17a2 100644
--- a/vcl/osx/a11ywrappergroup.mm
+++ b/vcl/osx/a11ywrappergroup.mm
@@ -34,7 +34,7 @@
     NSMutableArray * attributeNames = [ NSMutableArray arrayWithArray: [ super accessibilityAttributeNames ] ];
     // Special Attributes and removing unwanted attributes depending on role
     [ attributeNames removeObjectsInArray: [ NSArray arrayWithObjects:
-            NSAccessibilityTitleAttribute, 
+            // NSAccessibilityTitleAttribute,
             NSAccessibilityEnabledAttribute, 
             NSAccessibilitySelectedChildrenAttribute, 
             nil ]


More information about the Libreoffice-commits mailing list