[Libreoffice-commits] libvisio.git: src/lib

David Tardon dtardon at redhat.com
Thu Nov 20 08:40:18 PST 2014


 src/lib/VSDContentCollector.cpp |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit a0f87f055629f21d43d6c58eabf3c978547e6f08
Author: David Tardon <dtardon at redhat.com>
Date:   Thu Nov 20 17:31:55 2014 +0100

    fix page referencing itself as its background page
    
    Change-Id: I70d91a8f2f72cba6cd6ce4a3427af98edb6d0a4a

diff --git a/src/lib/VSDContentCollector.cpp b/src/lib/VSDContentCollector.cpp
index a3cd0f1..87a5042 100644
--- a/src/lib/VSDContentCollector.cpp
+++ b/src/lib/VSDContentCollector.cpp
@@ -2762,6 +2762,10 @@ void libvisio::VSDContentCollector::endPage()
   {
     _handleLevelChange(0);
     _flushCurrentPage();
+    // TODO: this check does not prevent two pages mutually referencing themselves
+    // as their background pages. Or even longer cycle of pages.
+    if (m_currentPage.m_backgroundPageID == m_currentPage.m_currentPageID)
+      m_currentPage.m_backgroundPageID = MINUS_ONE;
     if (m_isBackgroundPage)
       m_pages.addBackgroundPage(m_currentPage);
     else


More information about the Libreoffice-commits mailing list