[Libreoffice-commits] core.git: configure.ac

Noel Grandin noel at peralex.com
Fri Nov 21 00:44:09 PST 2014


 configure.ac |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit 40e7eecb7efeeb9af59206d7a9c82ac55adf5279
Author: Noel Grandin <noel at peralex.com>
Date:   Thu Nov 20 16:02:57 2014 +0200

    add sanity checking to --with-iwyu
    
    add some error checking so developers like me don't pass an empty
    --with-iwyu option and get weird compile time error messages.
    
    Change-Id: I142a0404db1bce905ce4d791f286d7bfc913078c
    Reviewed-on: https://gerrit.libreoffice.org/12988
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
    Tested-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/configure.ac b/configure.ac
index fe56ff3..7d58d67 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2079,7 +2079,7 @@ AC_ARG_WITH(gssapi,
 
 AC_ARG_WITH(iwyu,
     AS_HELP_STRING([--with-iwyu],
-        [Provide IWYU binary path to check unneeded includes instead of building.
+        [Use given IWYU binary path to check unneeded includes instead of building.
          Use only if you are hacking on it.]),
 ,)
 
@@ -12512,6 +12512,12 @@ AC_SUBST(PARALLELISM)
 
 IWYU_PATH="$with_iwyu"
 AC_SUBST(IWYU_PATH)
+if test ! -z "$IWYU_PATH"; then
+    if test ! -f "$IWYU_PATH"; then
+        AC_MSG_ERROR([cannot find include-what-you-use binary specified by --with-iwyu])
+    fi
+fi
+
 #
 # Set up ILIB for MSVC build
 #


More information about the Libreoffice-commits mailing list