[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - basic/source

[Caolán McNamara]

 basic/source/runtime/methods.cxx |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit a45c9334f68fdfde10f60747206bef1638cd7192
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Nov 21 09:20:31 2014 +0000

    busted loop condition and coverity#1255390 Resource leak
    
    regression from
    
    commit 119873328acd70ca3569c21a0b1fe36277e8bf4c
    Date:   Thu Oct 21 15:34:02 2010 -0500
        convert vos/process.hxx and related API
    
    Change-Id: I36527a4f0109105b9853a79773b4c92f9bc4e902
    (cherry picked from commit ecc56da366960b642d0a7da1b4a47245243252f8)
    Reviewed-on: https://gerrit.libreoffice.org/13015
    Reviewed-by: Andras Timar <andras.timar at collabora.com>
    Tested-by: Andras Timar <andras.timar at collabora.com>

diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index 2e3c375..b152faf 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -3717,12 +3717,13 @@ RTLFUNC(Shell)
             osl_freeProcessHandle( pApp );
         }
 
-        for(int j = 0; i < nParamCount; i++)
+        for(int j = 0; j < nParamCount; ++j)
         {
             rtl_uString_release(pParamList[j]);
-            pParamList[j] = NULL;
         }
 
+        delete [] pParamList;
+
         if( !bSucc )
         {
             StarBASIC::Error( SbERR_FILE_NOT_FOUND );