[Libreoffice-commits] core.git: vcl/opengl

Michael Meeks michael.meeks at collabora.com
Tue Nov 25 02:11:56 PST 2014


 vcl/opengl/gdiimpl.cxx |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 7a1cb6c3953bba26e58af0f292b1e6bf4bc4a61b
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Tue Nov 25 10:12:47 2014 +0000

    vcl: misc. TODO comment expansion.
    
    Change-Id: Iac9e998c2737a370aff382f8c4ae68af8e59f521

diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx
index a794d15..295ac23 100644
--- a/vcl/opengl/gdiimpl.cxx
+++ b/vcl/opengl/gdiimpl.cxx
@@ -393,7 +393,7 @@ bool OpenGLSalGraphicsImpl::CheckOffscreenTexture()
     GLfloat fHeight = GetHeight();
     SalTwoRect aPosAry(0, 0, fWidth, fHeight, 0,0, fWidth, fHeight);
 
-    // TODO: lfrb: User GL_ARB_copy_image?
+    // TODO: improve performance: lfrb: User GL_ARB_copy_image?
     OpenGLTexture aNewTex = OpenGLTexture( GetWidth(), GetHeight() );
     glFramebufferTexture2D( GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, aNewTex.Id(), 0 );
     glViewport( 0, 0, GetWidth(), GetHeight() );
@@ -1376,7 +1376,7 @@ void OpenGLSalGraphicsImpl::drawPolyPolygon( sal_uInt32 nPoly, const sal_uInt32*
 
     if( mnLineColor != SALCOLOR_NONE )
     {
-        // TODO Use glMultiDrawElements or primitive restart
+        // TODO performance: Use glMultiDrawElements or primitive restart
         BeginSolid( mnLineColor );
         for( sal_uInt32 i = 0; i < nPoly; i++ )
             DrawLines( pPoints[i], pPtAry[i], true );
@@ -1562,7 +1562,8 @@ void OpenGLSalGraphicsImpl::DoCopyBits( const SalTwoRect& rPosAry, OpenGLSalGrap
     }
 
     SAL_WARN( "vcl.opengl", "*** NOT IMPLEMENTED *** copyBits" );
-    // TODO Copy from one FBO to the other (glBlitFramebuffer)
+    // TODO: Copy from one FBO to the other (glBlitFramebuffer)
+    //       ie. copying from one visible window to another visible window
 }
 
 void OpenGLSalGraphicsImpl::drawBitmap( const SalTwoRect& rPosAry, const SalBitmap& rSalBitmap )


More information about the Libreoffice-commits mailing list