[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sc/source

Caolán McNamara caolanm at redhat.com
Fri Nov 28 01:24:56 PST 2014


 sc/source/ui/view/gridwin.cxx |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

New commits:
commit 2962addb8bdc6207302283407b5de0d65fa7445f
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Nov 19 16:39:55 2014 +0000

    Resolves: rhbz#1165444 abrt crash with NULL pView
    
    Change-Id: I37f02f16209f274cf0358defba6bfa109948990f
    (cherry picked from commit 755209d88073fd497b884b8de1348ec75c2df7eb)
    Reviewed-on: https://gerrit.libreoffice.org/13156
    Reviewed-by: Andras Timar <andras.timar at collabora.com>
    Tested-by: Andras Timar <andras.timar at collabora.com>

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 38e0b86..cc1e2a7 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -5238,12 +5238,9 @@ bool ScGridWindow::GetEditUrl( const Point& rPos,
     ScInputHandler* pInputHdl = NULL;
     if (pViewSh)
         pInputHdl = pViewSh->GetInputHandler();
-
-    if (pInputHdl && pInputHdl->IsInputMode())
-    {
-        EditView* pView = pInputHdl->GetTableView();
+    EditView* pView = (pInputHdl && pInputHdl->IsInputMode()) ? pInputHdl->GetTableView() : NULL;
+    if (pView)
         return extractURLInfo(pView->GetFieldUnderMousePointer(), pName, pUrl, pTarget);
-    }
 
     //! nPosX/Y mit uebergeben?
     SCsCOL nPosX;


More information about the Libreoffice-commits mailing list