[Libreoffice-commits] core.git: 16 commits - chart2/source cui/source dbaccess/source editeng/source filter/source include/sfx2 sfx2/source starmath/source svx/source sw/source unoxml/qa
Caolán McNamara
caolanm at redhat.com
Wed Oct 1 12:29:31 PDT 2014
chart2/source/tools/MediaDescriptorHelper.cxx | 2 ++
cui/source/inc/treeopt.hxx | 1 -
cui/source/options/optgdlg.cxx | 7 ++++---
cui/source/tabpages/tpshadow.cxx | 4 +---
dbaccess/source/ui/dlg/detailpages.cxx | 9 ++-------
dbaccess/source/ui/dlg/detailpages.hxx | 3 ---
editeng/source/misc/hangulhanja.cxx | 2 +-
filter/source/graphicfilter/icgm/class5.cxx | 4 +---
include/sfx2/app.hxx | 1 -
include/sfx2/tabdlg.hxx | 1 -
sfx2/source/appl/app.hrc | 1 -
sfx2/source/appl/app.src | 5 -----
sfx2/source/appl/appinit.cxx | 3 ---
sfx2/source/appl/appquit.cxx | 20 --------------------
starmath/source/edit.cxx | 4 ++--
svx/source/table/tablertfexporter.cxx | 5 +----
sw/source/core/layout/atrfrm.cxx | 8 ++++----
sw/source/core/text/txtftn.cxx | 3 +--
sw/source/filter/ww8/ww8par3.cxx | 2 --
sw/source/ui/fmtui/tmpdlg.cxx | 2 +-
unoxml/qa/unit/domtest.cxx | 2 +-
21 files changed, 21 insertions(+), 68 deletions(-)
New commits:
commit 6d96902a3e25ebadc85666ddaf7c96e070ac99f5
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 17:17:29 2014 +0100
coverity#1242747 Uninitialized pointer field
Change-Id: I1530d071ad44afc114f1916bf234e0616b7dce90
diff --git a/dbaccess/source/ui/dlg/detailpages.cxx b/dbaccess/source/ui/dlg/detailpages.cxx
index 0904d6d..5018b58 100644
--- a/dbaccess/source/ui/dlg/detailpages.cxx
+++ b/dbaccess/source/ui/dlg/detailpages.cxx
@@ -63,10 +63,8 @@ namespace dbaui
:OGenericAdministrationPage(pParent, rId, rUIXMLDescription, _rCoreAttrs)
,m_pOptionsLabel(NULL)
,m_pOptions(NULL)
- ,m_pDataConvertFixedLine(NULL)
,m_pCharsetLabel(NULL)
,m_pCharset(NULL)
- ,m_pAutoFixedLine(NULL)
,m_pAutoRetrievingEnabled(NULL)
,m_pAutoIncrementLabel(NULL)
,m_pAutoIncrement(NULL)
@@ -87,8 +85,8 @@ namespace dbaui
if ((m_nControlFlags & CBTP_USE_CHARSET) == CBTP_USE_CHARSET)
{
- m_pDataConvertLabel = get<FixedText>("charsetheader");
- m_pDataConvertLabel->Show();
+ FixedText* pDataConvertLabel = get<FixedText>("charsetheader");
+ pDataConvertLabel->Show();
m_pCharsetLabel = get<FixedText>("charsetlabel");
m_pCharsetLabel->Show();
m_pCharset = get<CharSetListBox>("charset");
@@ -104,11 +102,9 @@ namespace dbaui
DELETEZ(m_pOptionsLabel);
DELETEZ(m_pOptions);
- DELETEZ(m_pDataConvertFixedLine);
DELETEZ(m_pCharsetLabel);
DELETEZ(m_pCharset);
- DELETEZ(m_pAutoFixedLine);
DELETEZ(m_pAutoIncrementLabel);
DELETEZ(m_pAutoIncrement);
@@ -128,7 +124,6 @@ namespace dbaui
if ((m_nControlFlags & CBTP_USE_CHARSET) == CBTP_USE_CHARSET)
{
- //_rControlList.push_back(new ODisableWrapper<FixedLine>(m_pDataConvertFixedLine));
_rControlList.push_back(new ODisableWrapper<FixedText>(m_pCharsetLabel));
}
}
diff --git a/dbaccess/source/ui/dlg/detailpages.hxx b/dbaccess/source/ui/dlg/detailpages.hxx
index 6ffef01..229b466 100644
--- a/dbaccess/source/ui/dlg/detailpages.hxx
+++ b/dbaccess/source/ui/dlg/detailpages.hxx
@@ -53,12 +53,9 @@ namespace dbaui
FixedText* m_pOptionsLabel;
Edit* m_pOptions;
- FixedLine* m_pDataConvertFixedLine;
- FixedText* m_pDataConvertLabel;
FixedText* m_pCharsetLabel;
CharSetListBox* m_pCharset;
- FixedLine* m_pAutoFixedLine;
CheckBox* m_pAutoRetrievingEnabled;
FixedText* m_pAutoIncrementLabel;
Edit* m_pAutoIncrement;
commit 8dd1367a7a6cb30e773c1eff1d7e5dd487cf7766
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 17:15:25 2014 +0100
coverity#1242740 Unused value
Change-Id: I627c50f6315b2212e3e1f4790b7fc8e08c6e0ee8
diff --git a/sw/source/filter/ww8/ww8par3.cxx b/sw/source/filter/ww8/ww8par3.cxx
index f2fd82f..227f534 100644
--- a/sw/source/filter/ww8/ww8par3.cxx
+++ b/sw/source/filter/ww8/ww8par3.cxx
@@ -1290,7 +1290,6 @@ WW8ListManager::WW8ListManager(SvStream& rSt_, SwWW8ImplReader& rReader_)
size_t nLFOInfos = pLFOInfos.size();
for (size_t nLfo = 0; nLfo < nLFOInfos; ++nLfo)
{
- bOk = false;
WW8LFOInfo& rLFOInfo = pLFOInfos[nLfo];
// stehen hierfuer ueberhaupt LFOLVL an ?
if( rLFOInfo.bOverride )
@@ -1435,7 +1434,6 @@ WW8ListManager::WW8ListManager(SvStream& rSt_, SwWW8ImplReader& rReader_)
for (sal_uInt8 nLevel = 0; nLevel < rLFOInfo.nLfoLvl; ++nLevel)
delete aItemSet[ nLevel ];
- bOk = true;
}
}
}
commit 74343722f64fe8be0484ab614eebb34333e26392
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 17:11:14 2014 +0100
coverity#1242505 Dereference before null check
Change-Id: I63a5361eb338dba30d76f4a0a1afb88e7de5f401
diff --git a/sw/source/ui/fmtui/tmpdlg.cxx b/sw/source/ui/fmtui/tmpdlg.cxx
index c13d881..c6255cd 100644
--- a/sw/source/ui/fmtui/tmpdlg.cxx
+++ b/sw/source/ui/fmtui/tmpdlg.cxx
@@ -291,7 +291,7 @@ SwTemplateDlg::SwTemplateDlg(vcl::Window* pParent,
m_nPageId = AddTabPage("page",
pFact->GetTabPageCreatorFunc( RID_SVXPAGE_PAGE ),
pFact->GetTabPageRangesFunc( RID_SVXPAGE_PAGE ) );
- if(!pActShell || 0 == ::GetHtmlMode(pWrtShell->GetView().GetDocShell()))
+ if (0 == ::GetHtmlMode(pWrtShell->GetView().GetDocShell()))
{
OSL_ENSURE(pFact->GetTabPageCreatorFunc( RID_SVXPAGE_BORDER ), "GetTabPageCreatorFunc fail!");
OSL_ENSURE(pFact->GetTabPageRangesFunc( RID_SVXPAGE_BORDER ), "GetTabPageRangesFunc fail!");
commit 6250f61fc8b87aacaec2c48c7751f15e9222fa2c
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 17:01:36 2014 +0100
coverity#1242472 Identical code for different branches
Change-Id: I32a74aa1ad42b975bca4b13403d261fd31deb8dd
diff --git a/filter/source/graphicfilter/icgm/class5.cxx b/filter/source/graphicfilter/icgm/class5.cxx
index 5e6fdb2..86237a5 100644
--- a/filter/source/graphicfilter/icgm/class5.cxx
+++ b/filter/source/graphicfilter/icgm/class5.cxx
@@ -55,9 +55,7 @@ void CGM::ImplDoClass5()
else
nWidth = (sal_uInt32)ImplGetFloat( pElement->eRealPrecision, pElement->nRealSize ) * 25; // scaling in 1/4 mm
- ( pElement->nAspectSourceFlags & ASF_LINEWIDTH )
- ? pElement->aLineBundle.nLineWidth = nWidth
- : pElement->aLineBundle.nLineWidth = nWidth;
+ pElement->aLineBundle.nLineWidth = nWidth;
}
break;
case 0x04 : /*Line Color*/
commit 8cb61cbb09f702b968649395f5beaf50e40edf99
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 16:56:10 2014 +0100
coverity#1242448 Identical code for different branches
Change-Id: Ie864a4d04ea1ae701ab5dbb5b93807e98d5f0f1c
diff --git a/starmath/source/edit.cxx b/starmath/source/edit.cxx
index eb3ac83..9ab5776 100644
--- a/starmath/source/edit.cxx
+++ b/starmath/source/edit.cxx
@@ -917,12 +917,12 @@ void SmEditWindow::MouseMove(const MouseEvent &rEvt)
sal_Int8 SmEditWindow::AcceptDrop( const AcceptDropEvent& /*rEvt*/ )
{
- return pEditView ? /*pEditView->QueryDrop( rEvt )*/DND_ACTION_NONE: DND_ACTION_NONE;
+ return DND_ACTION_NONE;
}
sal_Int8 SmEditWindow::ExecuteDrop( const ExecuteDropEvent& /*rEvt*/ )
{
- return pEditView ? /*pEditView->Drop( rEvt )*/DND_ACTION_NONE : DND_ACTION_NONE;
+ return DND_ACTION_NONE;
}
ESelection SmEditWindow::GetSelection() const
commit 8f9bc93ba3299efbd8ad181481e6e2e87df7c066
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 16:51:24 2014 +0100
coverity#1242441 Identical code for different branches
before
commit 887b3a35628b349e7934f2ae7c220a1cc17c3e63
Date: Fri Jun 13 17:52:30 2014 +0200
loplugin:staticcall
this looked like
SwFtnFrm *pFtnFrm = bEndn ? pEndBoss->FindFtn( pSource, pFtn ) :
pFtnBoss->FindFtn( pSource, pFtn );
which superficially seemed to have different if else branches
Change-Id: I450c8080d503489902f16cc756ff9f7013971388
diff --git a/sw/source/core/text/txtftn.cxx b/sw/source/core/text/txtftn.cxx
index e9ae8e2..068a41c 100644
--- a/sw/source/core/text/txtftn.cxx
+++ b/sw/source/core/text/txtftn.cxx
@@ -461,8 +461,7 @@ void SwTxtFrm::RemoveFtn( const sal_Int32 nStart, const sal_Int32 nLen )
// -> Ftn wandert in den PrevFollow
// beide muessen auf einer Seite/in einer Spalte stehen.
- SwFtnFrm *pFtnFrm = bEndn ? SwFtnBossFrm::FindFtn( pSource, pFtn ) :
- SwFtnBossFrm::FindFtn( pSource, pFtn );
+ SwFtnFrm *pFtnFrm = SwFtnBossFrm::FindFtn(pSource, pFtn);
if( pFtnFrm )
{
commit 4f1cf73b4da42a8bc9147712e3c575356f7e4c30
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 16:47:14 2014 +0100
coverity#1242436 Identical code for different branches
Change-Id: Ia2988cdde8be62a9fb3d2895c70148a01dedf594
diff --git a/editeng/source/misc/hangulhanja.cxx b/editeng/source/misc/hangulhanja.cxx
index ef7e58c..c71089c 100644
--- a/editeng/source/misc/hangulhanja.cxx
+++ b/editeng/source/misc/hangulhanja.cxx
@@ -491,7 +491,7 @@ namespace editeng
{
if ( implNextConvertibleUnit(
_bRepeatUnit
- ? ( IsByCharacter() ? m_nCurrentStartIndex : m_nCurrentStartIndex )
+ ? m_nCurrentStartIndex
: m_nCurrentEndIndex
) )
return true;
commit d61cb66bd83789f72dac89e56542b925cfe53ee2
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 16:35:57 2014 +0100
coverity#735513 constant guards dead code
Change-Id: Idba65df85e8fc2131d0cfbdd1b3c25470f0dc0ae
diff --git a/svx/source/table/tablertfexporter.cxx b/svx/source/table/tablertfexporter.cxx
index 167c665..7e38ffa 100644
--- a/svx/source/table/tablertfexporter.cxx
+++ b/svx/source/table/tablertfexporter.cxx
@@ -197,8 +197,7 @@ void SdrTableRtfExporter::WriteCell( sal_Int32 nCol, sal_Int32 nRow )
delete pParaObj;
}
- bool bResetPar, bResetAttr;
- bResetPar = bResetAttr = false;
+ bool bResetAttr = false;
SdrTextHorzAdjust eHAdj = xCell->GetTextHorizontalAdjust();
@@ -240,8 +239,6 @@ void SdrTableRtfExporter::WriteCell( sal_Int32 nCol, sal_Int32 nRow )
RTFOutFuncs::Out_String( mrStrm, aContent );
mrStrm.WriteCharPtr( OOO_STRING_SVTOOLS_RTF_CELL );
- if ( bResetPar )
- mrStrm.WriteCharPtr( OOO_STRING_SVTOOLS_RTF_PARD ).WriteCharPtr( OOO_STRING_SVTOOLS_RTF_INTBL );
if ( bResetAttr )
mrStrm.WriteCharPtr( OOO_STRING_SVTOOLS_RTF_PLAIN );
}
commit 00d39034138bdb84b1304f4b6a41f265d6715c90
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 16:33:58 2014 +0100
coverity#735489 constant guards dead code
Change-Id: I387dcfb34dd6f1fc74ed929cb6b2833ae8e0f574
diff --git a/include/sfx2/app.hxx b/include/sfx2/app.hxx
index 41a3130..1f41a5d 100644
--- a/include/sfx2/app.hxx
+++ b/include/sfx2/app.hxx
@@ -209,7 +209,6 @@ public:
SAL_DLLPRIVATE SfxDispatcher* GetAppDispatcher_Impl();
SAL_DLLPRIVATE SfxDispatcher* GetDispatcher_Impl();
- SAL_DLLPRIVATE bool QueryExit_Impl();
SAL_DLLPRIVATE void SetOptions_Impl(const SfxItemSet &);
SAL_DLLPRIVATE bool Initialize_Impl();
diff --git a/sfx2/source/appl/app.hrc b/sfx2/source/appl/app.hrc
index 1d74997..801fe40 100644
--- a/sfx2/source/appl/app.hrc
+++ b/sfx2/source/appl/app.hrc
@@ -23,7 +23,6 @@
#define STR_NO_WEBBROWSER_FOUND (RID_SFX_APP_START+7)
#define STR_NO_ABS_URI_REF (RID_SFX_APP_START+8)
-#define STR_CANT_QUIT (RID_SFX_APP_START+10)
#define STR_ISMODIFIED (RID_SFX_APP_START+11)
#define RID_FULLSCREENTOOLBOX (RID_SFX_APP_START+42)
diff --git a/sfx2/source/appl/app.src b/sfx2/source/appl/app.src
index aeb560d..0c606fd 100644
--- a/sfx2/source/appl/app.src
+++ b/sfx2/source/appl/app.src
@@ -203,11 +203,6 @@ String GID_CONTROLS
Text [ en-US ] = "Controls" ;
};
-String STR_CANT_QUIT
-{
- Text [ en-US ] = "The application cannot be terminated at the moment.\nPlease wait until all print jobs and/or\nOLE actions have finished and close all dialogs." ;
-};
-
String STR_ISMODIFIED
{
Text [ en-US ] = "Do you want to save the changes to %1?" ;
diff --git a/sfx2/source/appl/appinit.cxx b/sfx2/source/appl/appinit.cxx
index 1d92c5e..f5a4682 100644
--- a/sfx2/source/appl/appinit.cxx
+++ b/sfx2/source/appl/appinit.cxx
@@ -93,9 +93,6 @@ void SAL_CALL SfxTerminateListener_Impl::disposing( const EventObject& ) throw(
void SAL_CALL SfxTerminateListener_Impl::queryTermination( const EventObject& ) throw(TerminationVetoException, RuntimeException, std::exception )
{
- SolarMutexGuard aGuard;
- if ( !SfxGetpApp()->QueryExit_Impl() )
- throw TerminationVetoException();
}
void SAL_CALL SfxTerminateListener_Impl::notifyTermination( const EventObject& aEvent ) throw(RuntimeException, std::exception )
diff --git a/sfx2/source/appl/appquit.cxx b/sfx2/source/appl/appquit.cxx
index da121d3..e37e98d 100644
--- a/sfx2/source/appl/appquit.cxx
+++ b/sfx2/source/appl/appquit.cxx
@@ -56,26 +56,6 @@
using ::basic::BasicManagerRepository;
-
-bool SfxApplication::QueryExit_Impl()
-{
- bool bQuit = true;
-
- // Does some instance, that can not be shut down, still require the app?
- if ( !bQuit )
- {
- // Not really exit, only minimize
- MessageDialog aInfoBox( NULL, SfxResId(STR_CANT_QUIT), VCL_MESSAGE_INFO );
- aInfoBox.Execute();
- OSL_TRACE( "QueryExit => sal_False (in use)" );
- return false;
- }
-
- return true;
-}
-
-
-
void SfxApplication::Deinitialize()
{
if ( pAppData_Impl->bDowning )
commit 1075cd6b5d7d5da9e347ac934d7acf51a39639db
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 16:27:47 2014 +0100
coverity#707673 uninitialized member
Change-Id: Iab55c2545790bdee7104abf91d7a3df2deb21ec5
diff --git a/chart2/source/tools/MediaDescriptorHelper.cxx b/chart2/source/tools/MediaDescriptorHelper.cxx
index 6104265..645a54e 100644
--- a/chart2/source/tools/MediaDescriptorHelper.cxx
+++ b/chart2/source/tools/MediaDescriptorHelper.cxx
@@ -192,6 +192,8 @@ void MediaDescriptorHelper::impl_init()
ISSET_WinExtent = false;
+ ISSET_SetEmbedded = false;
+
ISSET_Storage = false;
ISSET_Stream = false;
}
commit ab54489c3a9c24a9f85572a1e442988124f038a4
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 16:24:17 2014 +0100
coverity#704894 Explicit NULL derefenced
Change-Id: If1e812f9b3c93c8e81817dc599d1d732dbc68b0c
diff --git a/sw/source/core/layout/atrfrm.cxx b/sw/source/core/layout/atrfrm.cxx
index 1b11a28..5932f59 100644
--- a/sw/source/core/layout/atrfrm.cxx
+++ b/sw/source/core/layout/atrfrm.cxx
@@ -2836,7 +2836,7 @@ void SwFlyFrmFmt::MakeFrms()
if( bAdd )
{
- SwFlyFrm *pFly = 0;
+ SwFlyFrm *pFly;
switch( aAnchorAttr.GetAnchorId() )
{
case FLY_AT_FLY:
@@ -2848,12 +2848,12 @@ void SwFlyFrmFmt::MakeFrms()
pFly = new SwFlyAtCntFrm( this, pFrm, pFrm );
break;
+ default:
+ assert(false && "Neuer Ankertyp" );
+ //fall-through
case FLY_AS_CHAR:
pFly = new SwFlyInCntFrm( this, pFrm, pFrm );
break;
- default:
- OSL_ENSURE( false, "Neuer Ankertyp" );
- break;
}
pFrm->AppendFly( pFly );
SwPageFrm *pPage = pFly->FindPageFrm();
commit 39a6d582a5a98f073ccb8e2bdd6832ace5eb3ca9
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 16:21:46 2014 +0100
coverity#1242928 Uninitialized pointer field
Change-Id: I841306c664ddc5d81ce1c84357de3b2daf32964a
diff --git a/cui/source/tabpages/tpshadow.cxx b/cui/source/tabpages/tpshadow.cxx
index 7bd6076..9621c45 100644
--- a/cui/source/tabpages/tpshadow.cxx
+++ b/cui/source/tabpages/tpshadow.cxx
@@ -53,6 +53,7 @@ SvxShadowTabPage::SvxShadowTabPage( vcl::Window* pParent, const SfxItemSet& rInA
rInAttrs ),
rOutAttrs ( rInAttrs ),
eRP ( RP_LT ),
+ pnColorListState ( 0 ),
nPageType ( 0 ),
nDlgType ( 0 ),
pbAreaTP ( 0 ),
@@ -162,11 +163,8 @@ SvxShadowTabPage::SvxShadowTabPage( vcl::Window* pParent, const SfxItemSet& rInA
m_pLbShadowColor->SetSelectHdl( aLink );
m_pMtrTransparent->SetModifyHdl( aLink );
m_pMtrDistance->SetModifyHdl( aLink );
-
}
-
-
void SvxShadowTabPage::Construct()
{
m_pLbShadowColor->Fill( pColorList );
commit d6dd0a3b10427e5b8b2aef6d98fcd86cf6129347
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 16:19:40 2014 +0100
coverity#1242929 Uninitialized scalar field
Change-Id: I77d19b131a378b16e82ce789c5d0fc99845e92db
diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx
index f45b4a4..79688cc 100644
--- a/cui/source/options/optgdlg.cxx
+++ b/cui/source/options/optgdlg.cxx
@@ -997,9 +997,10 @@ static OUString lcl_getDatePatternsConfigString( const LocaleDataWrapper& rLocal
return aBuf.makeStringAndClear();
}
-OfaLanguagesTabPage::OfaLanguagesTabPage( vcl::Window* pParent, const SfxItemSet& rSet ) :
- SfxTabPage( pParent,"OptLanguagesPage","cui/ui/optlanguagespage.ui", &rSet ),
- pLangConfig(new LanguageConfig_Impl)
+OfaLanguagesTabPage::OfaLanguagesTabPage(vcl::Window* pParent, const SfxItemSet& rSet)
+ : SfxTabPage(pParent,"OptLanguagesPage","cui/ui/optlanguagespage.ui", &rSet)
+ , pLangConfig(new LanguageConfig_Impl)
+ , m_bDatePatternsValid(false)
{
get(m_pUserInterfaceLB, "userinterface");
m_pUserInterfaceLB->SetStyle(m_pUserInterfaceLB->GetStyle() | WB_SORT);
commit 7df609db556cadb78d9b861d4bea5da75deb8704
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 16:17:56 2014 +0100
coverity#1242932 Uncaught exception
Change-Id: I13ef24dfa1c82ad14737dac77b18e92d3abeb96b
diff --git a/unoxml/qa/unit/domtest.cxx b/unoxml/qa/unit/domtest.cxx
index 49eefe0..34558c5 100644
--- a/unoxml/qa/unit/domtest.cxx
+++ b/unoxml/qa/unit/domtest.cxx
@@ -175,7 +175,7 @@ struct TokenHandler
return Identifier.getLength() ? Identifier[0] : 0;
}
- virtual uno::Sequence< ::sal_Int8 > SAL_CALL getUTF8Identifier( ::sal_Int32 ) throw (uno::RuntimeException) SAL_OVERRIDE
+ virtual uno::Sequence< ::sal_Int8 > SAL_CALL getUTF8Identifier( ::sal_Int32 ) throw (uno::RuntimeException, std::exception) SAL_OVERRIDE
{
CPPUNIT_ASSERT_MESSAGE( "TokenHandler::getUTF8Identifier() unexpected call",
false );
commit 0b384f2756c690a3b9ed102118f40ee4c0da5abf
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 16:16:12 2014 +0100
coverity#1242943 unused member
Change-Id: I6a5a0efdfa45814a59d4b7b5885850e1618a526e
diff --git a/cui/source/inc/treeopt.hxx b/cui/source/inc/treeopt.hxx
index ac2d360..b6d70f4 100644
--- a/cui/source/inc/treeopt.hxx
+++ b/cui/source/inc/treeopt.hxx
@@ -160,7 +160,6 @@ private:
SvxColorTabPage *mpColorPage;
bool bForgetSelection;
- bool bExternBrowserActive;
bool bIsFromExtensionManager;
// check "for the current document only" and set focus to "Western" languages box
commit e62e266022ff0ae1d500e8b5fd807894b9f2b60a
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Oct 1 16:14:22 2014 +0100
coverity#1242662 unused member
Change-Id: Ie089a4afabb07e3b119563dafb162da427bb635d
diff --git a/include/sfx2/tabdlg.hxx b/include/sfx2/tabdlg.hxx
index 5e88ed9..a061793 100644
--- a/include/sfx2/tabdlg.hxx
+++ b/include/sfx2/tabdlg.hxx
@@ -77,7 +77,6 @@ friend class SfxTabDialogController;
PushButton* m_pBaseFmtBtn;
bool m_bOwnsOKBtn;
- bool m_bOwnsUserBtn;
bool m_bOwnsCancelBtn;
bool m_bOwnsHelpBtn;
bool m_bOwnsResetBtn;
More information about the Libreoffice-commits
mailing list