[Libreoffice-commits] core.git: 4 commits - chart2/source sc/source svx/source sw/source

[Norbert Thiebaud]

 chart2/source/controller/main/ChartController_Properties.cxx |    2 +-
 sc/source/ui/view/cellsh1.cxx                                |    2 +-
 svx/source/form/fmshimp.cxx                                  |    2 +-
 sw/source/core/tox/txmsrt.cxx                                |    7 ++++---
 4 files changed, 7 insertions(+), 6 deletions(-)

New commits:
commit 86a3fe47a66950e26d23d7d7f2680fa7d4fb0839
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Sat Oct 4 21:36:27 2014 -0500

    coverity#704049 Unchecked return value
    
    Gold? broken since 3edb1dcdc82304c418fc32212bb0bdf2c92e414e
    June 26 2002 ?
    
    Change-Id: I7f0bc4899070daff8329d6f66315956a7ed6084c

diff --git a/sw/source/core/tox/txmsrt.cxx b/sw/source/core/tox/txmsrt.cxx
index 325b389..ee76ab1 100644
--- a/sw/source/core/tox/txmsrt.cxx
+++ b/sw/source/core/tox/txmsrt.cxx
@@ -245,9 +245,10 @@ bool SwTOXSortTabBase::operator<( const SwTOXSortTabBase& rCmp )
                         // Both pointers exist -> compare text
                         // else -> compare AlternativeText
                         if( ( pEnd && pEndCmp ) || ( !pEnd && !pEndCmp ) )
-                            pTOXIntl->IsEqual( GetTxt(), GetLocale(),
-                                               rCmp.GetTxt(), rCmp.GetLocale() );
-
+                        {
+                            return pTOXIntl->IsEqual( GetTxt(), GetLocale(),
+                                                      rCmp.GetTxt(), rCmp.GetLocale() );
+                        }
                         if( pEnd && !pEndCmp )
                             return true;
                     }
commit 34823ac17d9e00fc7ca5db4cff3a4c8211c39142
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Sat Oct 4 21:26:04 2014 -0500

    coverity#704031 Unchecked return value
    
    Change-Id: I2db8f517f27ab9c8abe5aa473fad159a1506c06c

diff --git a/svx/source/form/fmshimp.cxx b/svx/source/form/fmshimp.cxx
index c07e66a..38e4ad6 100644
--- a/svx/source/form/fmshimp.cxx
+++ b/svx/source/form/fmshimp.cxx
@@ -3223,7 +3223,7 @@ void FmXFormShell::CreateExternalView()
             {
                 Reference< runtime::XFormController > xAsFormController( m_xExternalViewController, UNO_QUERY );
                 ControllerFeatures aHelper( xAsFormController, NULL );
-                aHelper->commitCurrentControl();
+                (void)aHelper->commitCurrentControl();
             }
 
             Reference< runtime::XFormController > xNewController(m_xExtViewTriggerController);
commit 6c70a38d12a0ab91bbee5bf0fea172bfcd38d774
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Sat Oct 4 21:19:01 2014 -0500

    coverity#704002 Unchecked return value
    
    Change-Id: Ibf506a219df7d0ad67959b3d266a037003fceea4

diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx
index 511d4b7..5c63df4 100644
--- a/sc/source/ui/view/cellsh1.cxx
+++ b/sc/source/ui/view/cellsh1.cxx
@@ -2098,7 +2098,7 @@ void ScCellShell::ExecuteEdit( SfxRequest& rReq )
                             if (pHdl)
                             {
                                 //  "=" in KeyEvent, switches to input-mode
-                                pScMod->InputKeyEvent( KeyEvent('=', vcl::KeyCode()) );
+                                (void)pScMod->InputKeyEvent( KeyEvent('=', vcl::KeyCode()) );
 
                                 std::vector<OUString> aNames = pDlg->GetSelectedNames();
                                 if (!aNames.empty())
commit 2fc308b941667294650233e6b0abd7c8e282472f
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Sat Oct 4 21:11:33 2014 -0500

    coverity#703928 Unchecked return value
    
    Change-Id: I26ba62448796f1d80d2b4bbaf2499d08058c3add

diff --git a/chart2/source/controller/main/ChartController_Properties.cxx b/chart2/source/controller/main/ChartController_Properties.cxx
index bfdd4b8..ca3dfa1 100644
--- a/chart2/source/controller/main/ChartController_Properties.cxx
+++ b/chart2/source/controller/main/ChartController_Properties.cxx
@@ -797,7 +797,7 @@ bool ChartController::executeDlg_ObjectProperties_withoutUndoGuard(
             if(pOutItemSet)
             {
                 ControllerLockGuardUNO aCLGuard( getModel());
-                pItemConverter->ApplyItemSet(*pOutItemSet); //model should be changed now
+                (void)pItemConverter->ApplyItemSet(*pOutItemSet); //model should be changed now
                 bRet = true;
             }
         }