[Libreoffice-commits] core.git: 6 commits - chart2/source scripting/source sc/source vcl/generic vcl/source

Norbert Thiebaud nthiebaud at gmail.com
Sun Oct 5 11:26:22 PDT 2014


 chart2/source/controller/dialogs/res_Trendline.cxx |    2 +-
 sc/source/ui/docshell/dbdocfun.cxx                 |    2 +-
 sc/source/ui/unoobj/cellsuno.cxx                   |    2 +-
 scripting/source/stringresource/stringresource.cxx |    2 +-
 vcl/generic/print/genprnpsp.cxx                    |    8 +++++---
 vcl/source/gdi/virdev.cxx                          |    2 +-
 6 files changed, 10 insertions(+), 8 deletions(-)

New commits:
commit 605dc6596a282297cac8e85aa2bbb59477cc27fd
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Sun Oct 5 13:16:21 2014 -0500

    coverity#1208996 Unchecked return value
    
    Change-Id: I02e79ddeefa3961ab7adeb71fbc57bfd0cbe02a8

diff --git a/vcl/source/gdi/virdev.cxx b/vcl/source/gdi/virdev.cxx
index 5e218c9..bfd5716 100644
--- a/vcl/source/gdi/virdev.cxx
+++ b/vcl/source/gdi/virdev.cxx
@@ -144,7 +144,7 @@ void VirtualDevice::ImplInitVirDev( const OutputDevice* pOutDev,
 
     SalGraphics* pGraphics;
     if ( !pOutDev->mpGraphics )
-        pOutDev->AcquireGraphics();
+        (void)pOutDev->AcquireGraphics();
     pGraphics = pOutDev->mpGraphics;
     if ( pGraphics )
         mpVirDev = pSVData->mpDefInst->CreateVirtualDevice( pGraphics, nDX, nDY, nBitCount, pData );
commit 39c8834d21488d596b1e609402320ad24133c21d
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Sun Oct 5 13:14:03 2014 -0500

    coverity#1209004 Unchecked return value
    
    Change-Id: I8749a5d6f176406e181312d94a1e643974d87617

diff --git a/scripting/source/stringresource/stringresource.cxx b/scripting/source/stringresource/stringresource.cxx
index b38ddc6..0e3bfce 100644
--- a/scripting/source/stringresource/stringresource.cxx
+++ b/scripting/source/stringresource/stringresource.cxx
@@ -356,7 +356,7 @@ void StringResourceImpl::implSetCurrentLocale( const Locale& locale,
 
     if( pLocaleItem != NULL )
     {
-        loadLocale( pLocaleItem );
+        (void)loadLocale( pLocaleItem );
         m_pCurrentLocaleItem = pLocaleItem;
 
         // Only notify without modifying
commit 276a051ef5dc144a202633779259a4ecd43c81a8
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Sun Oct 5 13:05:04 2014 -0500

    coverity#1223085 Unchecked return value
    
    Change-Id: I4149684a6f704893e130bd1776850634fdb67ceb

diff --git a/chart2/source/controller/dialogs/res_Trendline.cxx b/chart2/source/controller/dialogs/res_Trendline.cxx
index 9dd896f..77e972b 100644
--- a/chart2/source/controller/dialogs/res_Trendline.cxx
+++ b/chart2/source/controller/dialogs/res_Trendline.cxx
@@ -276,7 +276,7 @@ bool TrendlineResources::FillItemSet(SfxItemSet* rOutAttrs) const
         rOutAttrs->Put( SfxBoolItem( SCHATTR_REGRESSION_SET_INTERCEPT, m_pCB_SetIntercept->IsChecked() ));
 
     aValue = 0.0;
-    m_pNumFormatter->IsNumberFormat(m_pFmtFld_InterceptValue->GetText(),nIndex,aValue);
+    (void)m_pNumFormatter->IsNumberFormat(m_pFmtFld_InterceptValue->GetText(),nIndex,aValue);
     rOutAttrs->Put(SvxDoubleItem( aValue, SCHATTR_REGRESSION_INTERCEPT_VALUE ) );
 
     return true;
commit 4000d7adea213c9336dc4755b1764489a11c0172
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Sun Oct 5 12:52:55 2014 -0500

    coverity#1231669 Unchecked return value
    
    Change-Id: I60b7c8267c81b0545c2bcc367ad6cac43aefad64

diff --git a/sc/source/ui/unoobj/cellsuno.cxx b/sc/source/ui/unoobj/cellsuno.cxx
index 0b7ae88..67aa0ea 100644
--- a/sc/source/ui/unoobj/cellsuno.cxx
+++ b/sc/source/ui/unoobj/cellsuno.cxx
@@ -5570,7 +5570,7 @@ void SAL_CALL ScCellRangeObj::sort( const uno::Sequence<beans::PropertyValue>& a
         pDocSh->GetDBData( aRange, SC_DB_MAKE, SC_DBSEL_FORCE_MARK );       // ggf. Bereich anlegen
 
         ScDBDocFunc aFunc(*pDocSh); // Bereich muss angelegt sein
-        aFunc.Sort( nTab, aParam, true, true, true );
+        (void)aFunc.Sort( nTab, aParam, true, true, true );
     }
 }
 
commit a8e2f3e8454c1fd62f40e2def5204819893fde97
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Sun Oct 5 12:51:49 2014 -0500

    coverity#1231670 Unchecked return value
    
    Change-Id: I29a751b2d44e86ccf115015b0ede8bae2e702eea

diff --git a/sc/source/ui/docshell/dbdocfun.cxx b/sc/source/ui/docshell/dbdocfun.cxx
index 2b438ce..bed565a 100644
--- a/sc/source/ui/docshell/dbdocfun.cxx
+++ b/sc/source/ui/docshell/dbdocfun.cxx
@@ -397,7 +397,7 @@ bool ScDBDocFunc::RepeatDB( const OUString& rDBName, bool bRecord, bool bApi, bo
             if (bSort)
             {
                 pDBData->GetSortParam( aSortParam );            // Bereich kann sich geaendert haben
-                Sort( nTab, aSortParam, false, false, bApi );
+                (void)Sort( nTab, aSortParam, false, false, bApi );
             }
             if (bQuery)
             {
commit c6b619e1e82c3cfadd9ce6f9f85f4054959ecffd
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Sun Oct 5 12:49:28 2014 -0500

    coverity#1240252 Unchecked return value
    
    Change-Id: I472f9fc9cb7b5d2e7030cc4272e29b955931ee88

diff --git a/vcl/generic/print/genprnpsp.cxx b/vcl/generic/print/genprnpsp.cxx
index 3b11ec6..d215a1d 100644
--- a/vcl/generic/print/genprnpsp.cxx
+++ b/vcl/generic/print/genprnpsp.cxx
@@ -299,9 +299,11 @@ static bool passFileToCommandLine( const OUString& rFilename, const OUString& rC
             close( fd[ 1 ] );
         }
         int status = 0;
-        waitpid( pid, &status, 0 );
-        if( ! status )
-            bSuccess = true;
+        if(waitpid( pid, &status, 0 ) != -1)
+        {
+            if( ! status )
+                bSuccess = true;
+        }
     }
     else if( ! pid )
     {


More information about the Libreoffice-commits mailing list