[Libreoffice-commits] core.git: connectivity/qa

Robert Antoni Buj i Gelonch robert.buj at gmail.com
Sat Oct 11 07:52:11 PDT 2014


 connectivity/qa/connectivity/tools/HsqlDatabase.java |   13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

New commits:
commit 0bc6ea3637e279fa2807d8ee649fb33f1ae6da47
Author: Robert Antoni Buj i Gelonch <robert.buj at gmail.com>
Date:   Sat Oct 11 16:16:09 2014 +0200

    connectivity: Iterate over each Entry in a Map & Enhanced for-loops
    
    Change-Id: Id4a340584fc727058f6e37c1f0d3c5887e931417
    Reviewed-on: https://gerrit.libreoffice.org/11917
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
    Tested-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/connectivity/qa/connectivity/tools/HsqlDatabase.java b/connectivity/qa/connectivity/tools/HsqlDatabase.java
index b5a7e21..13b0f32 100644
--- a/connectivity/qa/connectivity/tools/HsqlDatabase.java
+++ b/connectivity/qa/connectivity/tools/HsqlDatabase.java
@@ -30,10 +30,9 @@ import com.sun.star.sdbcx.XTablesSupplier;
 import com.sun.star.uno.UnoRuntime;
 
 import helper.URLHelper;
-import java.util.HashMap;
-import java.util.Iterator;
-import java.util.Set;
 import java.io.File;
+import java.util.HashMap;
+import java.util.Map;
 
 public class HsqlDatabase extends AbstractDatabase
 {
@@ -162,14 +161,12 @@ public class HsqlDatabase extends AbstractDatabase
             createStatement.append(')');
         }
 
-        final Set<String> foreignKeyTables = foreignKeys.keySet();
-        for (final Iterator<String> foreignKey = foreignKeyTables.iterator();
-                foreignKey.hasNext();)
+        for (Map.Entry<String, String> foreignKey : foreignKeys.entrySet())
         {
-            final String foreignTable = foreignKey.next();
+            final String foreignTable = foreignKey.getKey();
 
             createStatement.append(", FOREIGN KEY (");
-            createStatement.append(foreignKeys.get(foreignTable));
+            createStatement.append(foreignKey.getValue());
             createStatement.append(") REFERENCES \"");
             createStatement.append(foreignTable);
             createStatement.append("\"(");


More information about the Libreoffice-commits mailing list