[Libreoffice-commits] core.git: sw/source

Caolán McNamara caolanm at redhat.com
Wed Oct 15 02:54:16 PDT 2014


 sw/source/core/unocore/unochart.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0d6f45377592a62ff4ee510d5fbd3bdd9e20160a
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Oct 15 09:52:01 2014 +0100

    coverity#1212509 Logically dead code
    
    this look very wrong, surely this is what was meant
    
    Change-Id: I461fc1a67770c733aee2f4379dcc252abd09b641

diff --git a/sw/source/core/unocore/unochart.cxx b/sw/source/core/unocore/unochart.cxx
index 1dea221..d688d9f 100644
--- a/sw/source/core/unocore/unochart.cxx
+++ b/sw/source/core/unocore/unochart.cxx
@@ -797,9 +797,9 @@ uno::Reference< chart2::data::XDataSource > SwChartDataProvider::Impl_createData
             {
                 sal_Int32 nFirstSeqLen = 0;
                 sal_Int32 nFirstSeqLabelIdx = -1;
+                bool bFirstFound = false;
                 for (oi = 0;  oi < oiEnd;  ++oi)
                 {
-                    bool bFirstFound = false;
                     // row/col used at all?
                     if (aDataStartIdx[oi] != -1 &&
                         (!bFirstIsLabel || aLabelIdx[oi] != -1))


More information about the Libreoffice-commits mailing list