[Libreoffice-commits] core.git: toolkit/qa

Robert Antoni Buj i Gelonch robert.buj at gmail.com
Sun Oct 19 03:21:45 PDT 2014


 toolkit/qa/complex/toolkit/accessibility/_XAccessibleEventBroadcaster.java |   15 ++++------
 1 file changed, 6 insertions(+), 9 deletions(-)

New commits:
commit 68a18a6249dc9d8842a72413f3cd6f39ecf416e3
Author: Robert Antoni Buj i Gelonch <robert.buj at gmail.com>
Date:   Thu Oct 9 20:10:09 2014 +0200

    accessibility: The if statement is redundant
    
    Change-Id: I70dd50d8d588c71d391936195bb13ccb767470be
    Reviewed-on: https://gerrit.libreoffice.org/11890
    Reviewed-by: David Ostrovsky <david at ostrovsky.org>
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
    Tested-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/toolkit/qa/complex/toolkit/accessibility/_XAccessibleEventBroadcaster.java b/toolkit/qa/complex/toolkit/accessibility/_XAccessibleEventBroadcaster.java
index c46115b..18ee618 100644
--- a/toolkit/qa/complex/toolkit/accessibility/_XAccessibleEventBroadcaster.java
+++ b/toolkit/qa/complex/toolkit/accessibility/_XAccessibleEventBroadcaster.java
@@ -23,6 +23,7 @@ import com.sun.star.awt.Rectangle;
 import com.sun.star.awt.PosSize;
 import com.sun.star.awt.XWindow;
 import com.sun.star.accessibility.AccessibleEventObject;
+import com.sun.star.accessibility.AccessibleStateType;
 import com.sun.star.accessibility.XAccessible;
 import com.sun.star.accessibility.XAccessibleEventBroadcaster;
 import com.sun.star.accessibility.XAccessibleEventListener;
@@ -172,15 +173,11 @@ public class _XAccessibleEventBroadcaster {
 
     private static boolean chkTransient(Object Testcase) {
         XAccessibleContext accCon = UnoRuntime.queryInterface(XAccessibleContext.class, Testcase);
-        if (accCon.getAccessibleStateSet().contains(
-            com.sun.star.accessibility.AccessibleStateType.TRANSIENT)){
-            if (!accCon.getAccessibleParent().getAccessibleContext().getAccessibleStateSet().contains(
-                        com.sun.star.accessibility.AccessibleStateType.MANAGES_DESCENDANTS)) {
-                return false;
-            }
-            return true;
-        }
-        return false;
+        return accCon.getAccessibleStateSet().contains(
+            AccessibleStateType.TRANSIENT)
+            && accCon.getAccessibleParent().getAccessibleContext()
+                .getAccessibleStateSet().contains(
+                    AccessibleStateType.MANAGES_DESCENDANTS);
     }
 
 }


More information about the Libreoffice-commits mailing list