[Libreoffice-commits] core.git: 2 commits - sc/source svl/source

Eike Rathke erack at redhat.com
Thu Oct 30 11:09:31 PDT 2014


 sc/source/core/data/table6.cxx  |    3 +++
 svl/source/numbers/zforlist.cxx |    4 +---
 2 files changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 5ecd416c011557ce663edd52a5bc95e991fb3b84
Author: Eike Rathke <erack at redhat.com>
Date:   Thu Oct 30 17:51:28 2014 +0100

    CID#736090 Improper use of negative value
    
    Change-Id: Ice6d473d56b16ca53a046888f38d0c570d4b3828

diff --git a/sc/source/core/data/table6.cxx b/sc/source/core/data/table6.cxx
index 8102c78..d9140ed 100644
--- a/sc/source/core/data/table6.cxx
+++ b/sc/source/core/data/table6.cxx
@@ -52,6 +52,9 @@ bool lcl_GetTextWithBreaks( const EditTextObject& rData, ScDocument* pDoc, OUStr
 bool ScTable::SearchCell(const SvxSearchItem& rSearchItem, SCCOL nCol, SCROW nRow,
                          const ScMarkData& rMark, OUString& rUndoStr, ScDocument* pUndoDoc)
 {
+    if (!ValidColRow( nCol, nRow))
+        return false;
+
     bool    bFound = false;
     bool    bDoSearch = true;
     bool    bDoBack = rSearchItem.GetBackward();
commit 34c725d3fdf95841df43910715f61db980783bca
Author: Eike Rathke <erack at redhat.com>
Date:   Fri Oct 24 23:42:08 2014 +0200

    eliminate now unnecessary temporary OUString
    
    Change-Id: I8461cb3f9a3c1cd662b1bcbfc53ee56a498a7b35

diff --git a/svl/source/numbers/zforlist.cxx b/svl/source/numbers/zforlist.cxx
index d28d5f6..fba025a 100644
--- a/svl/source/numbers/zforlist.cxx
+++ b/svl/source/numbers/zforlist.cxx
@@ -1801,13 +1801,11 @@ SvNumberformat* SvNumberFormatter::ImpInsertFormat( const ::com::sun::star::i18n
         }
     }
     sal_Int32 nCheckPos = 0;
-    OUString sTempIn(aCodeStr);
-    SvNumberformat* pFormat = new SvNumberformat(sTempIn,
+    SvNumberformat* pFormat = new SvNumberformat(aCodeStr,
                                                  pFormatScanner,
                                                  pStringScanner,
                                                  nCheckPos,
                                                  ActLnge);
-    aCodeStr = sTempIn;
     if ( !pFormat || !(nCheckPos == 0) )
     {
         if (LocaleDataWrapper::areChecksEnabled())


More information about the Libreoffice-commits mailing list