[Libreoffice-commits] core.git: forms/qa

[Robert Antoni Buj i Gelonch]

 forms/qa/complex/forms/CheckOGroupBoxModel.java |    5 +----
 forms/qa/integration/forms/FormLayer.java       |    2 +-
 2 files changed, 2 insertions(+), 5 deletions(-)

New commits:
commit 1c70f59c133256f3ee0411a3b625916ad62a8603
Author: Robert Antoni Buj i Gelonch <robert.buj at gmail.com>
Date:   Tue Sep 30 13:01:02 2014 +0200

    forms: the assigned value is never used
    
    Change-Id: I8eadc27ba8880630ec93c68145969f3e8ba6c189
    Reviewed-on: https://gerrit.libreoffice.org/11712
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
    Tested-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/forms/qa/complex/forms/CheckOGroupBoxModel.java b/forms/qa/complex/forms/CheckOGroupBoxModel.java
index 6f048a6..b76cda3 100644
--- a/forms/qa/complex/forms/CheckOGroupBoxModel.java
+++ b/forms/qa/complex/forms/CheckOGroupBoxModel.java
@@ -127,8 +127,6 @@ public class CheckOGroupBoxModel
     private String[] getBoundPropsToTest()
     {
         Property[] properties = m_xPropSet.getPropertySetInfo().getProperties();
-        String[] testPropsNames = null;
-
         ArrayList<String> tNames = new ArrayList<String>();
 
         for (int i = 0; i < properties.length; i++)
@@ -151,8 +149,7 @@ public class CheckOGroupBoxModel
         } // endfor
 
         //get a array of bound properties
-        testPropsNames = new String[tNames.size()];
-        testPropsNames = tNames.toArray(testPropsNames);
+        String[] testPropsNames = tNames.toArray(new String[tNames.size()]);
         return testPropsNames;
     }
 
diff --git a/forms/qa/integration/forms/FormLayer.java b/forms/qa/integration/forms/FormLayer.java
index a86f6f1..e7c33a0 100644
--- a/forms/qa/integration/forms/FormLayer.java
+++ b/forms/qa/integration/forms/FormLayer.java
@@ -102,7 +102,7 @@ public class FormLayer
         // insert the model into the form component hierarchy, if the caller gave us a location
         if ( null != _parentForm )
         {
-            XIndexContainer parentForm = null;
+            XIndexContainer parentForm;
             if ( _parentForm instanceof XIndexContainer )
                 parentForm = (XIndexContainer)_parentForm;
             else