[Libreoffice-commits] core.git: sc/source

Caolán McNamara caolanm at redhat.com
Sat Apr 4 12:52:58 PDT 2015


 sc/source/core/data/drwlayer.cxx |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 071ad23d8f09c46a6e5b20eab9e49c6dea8ccc6a
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Apr 4 20:49:52 2015 +0100

    coverity#1292910 Dereference after null check
    
    Change-Id: I5c6b2e603cfada736fcca21d5124c01bfab77831

diff --git a/sc/source/core/data/drwlayer.cxx b/sc/source/core/data/drwlayer.cxx
index e70254a..3b4e110 100644
--- a/sc/source/core/data/drwlayer.cxx
+++ b/sc/source/core/data/drwlayer.cxx
@@ -144,7 +144,7 @@ ScUndoAnchorData::~ScUndoAnchorData()
 void ScUndoAnchorData::Undo()
 {
     // Trigger Object Change
-    if(pObj && pObj->IsInserted() && pObj->GetPage() && pObj->GetModel())
+    if (pObj->IsInserted() && pObj->GetPage() && pObj->GetModel())
     {
         SdrHint aHint(*pObj);
         pObj->GetModel()->Broadcast(aHint);
@@ -164,14 +164,13 @@ void ScUndoAnchorData::Redo()
         ScDrawLayer::SetCellAnchoredFromPosition(*pObj, *mpDoc, mnTab);
 
     // Trigger Object Change
-    if(pObj && pObj->IsInserted() && pObj->GetPage() && pObj->GetModel())
+    if (pObj->IsInserted() && pObj->GetPage() && pObj->GetModel())
     {
         SdrHint aHint(*pObj);
         pObj->GetModel()->Broadcast(aHint);
     }
 }
 
-
 ScTabDeletedHint::ScTabDeletedHint( SCTAB nTabNo ) :
     nTab( nTabNo )
 {


More information about the Libreoffice-commits mailing list