[Libreoffice-commits] core.git: sfx2/source

[Julien Nabet]

 sfx2/source/sidebar/Theme.cxx |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit cbbb24d0afcdbdac21d03ec4ee1455a3834afff4
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Mon Apr 13 20:10:16 2015 +0200

    tdf#90566: memory leak: maChangeListeners is not properly disposed
    
    + exchange arguments of swap to use the same pattern as the other swap locations
    
    Thank you Mike Kaganski!
    
    Change-Id: Ie575d503349b3218c7a0211e1f81d791e995297e

diff --git a/sfx2/source/sidebar/Theme.cxx b/sfx2/source/sidebar/Theme.cxx
index 03dd0c1..c3596b1 100644
--- a/sfx2/source/sidebar/Theme.cxx
+++ b/sfx2/source/sidebar/Theme.cxx
@@ -390,13 +390,13 @@ void Theme::UpdateTheme (void)
 void SAL_CALL Theme::disposing (void)
 {
     ChangeListeners aListeners;
-    maChangeListeners.swap(aListeners);
+    aListeners.swap(maChangeListeners);
 
     const lang::EventObject aEvent (static_cast<XWeak*>(this));
 
     for (ChangeListeners::const_iterator
-             iContainer(maChangeListeners.begin()),
-             iContainerEnd(maChangeListeners.end());
+             iContainer(aListeners.begin()),
+             iContainerEnd(aListeners.end());
          iContainer != iContainerEnd;
          ++iContainer)
     {