[Libreoffice-commits] core.git: include/svx

Caolán McNamara caolanm at redhat.com
Wed Apr 15 08:48:52 PDT 2015


 include/svx/dataaccessdescriptor.hxx  |    2 +-
 include/svx/databaselocationinput.hxx |    2 +-
 include/svx/dbaexchange.hxx           |    6 +++---
 include/svx/dbaobjectex.hxx           |    2 +-
 include/svx/dbcharsethelper.hxx       |    2 +-
 include/svx/deflt3d.hxx               |    2 +-
 include/svx/dialcontrol.hxx           |   12 +++---------
 include/svx/dlgctl3d.hxx              |    6 +++---
 include/svx/dlgctrl.hxx               |   32 ++++++++++++++++----------------
 include/svx/drawitem.hxx              |   16 ++++++----------
 10 files changed, 36 insertions(+), 46 deletions(-)

New commits:
commit 5537b135dfc4c499112fd4d1ef6ca6866f65c9bc
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Apr 15 16:44:06 2015 +0100

    add some SAL_WARN_UNUSED
    
    Change-Id: I6b8fb1d9b76f586a9a27d53f90e7686fcdf35077

diff --git a/include/svx/dataaccessdescriptor.hxx b/include/svx/dataaccessdescriptor.hxx
index abc813b..2a91fa2 100644
--- a/include/svx/dataaccessdescriptor.hxx
+++ b/include/svx/dataaccessdescriptor.hxx
@@ -61,7 +61,7 @@ namespace svx
 
     /** class encapsulating the com::sun::star::sdb::DataAccessDescriptor service.
     */
-    class SVX_DLLPUBLIC ODataAccessDescriptor
+    class SVX_DLLPUBLIC SAL_WARN_UNUSED ODataAccessDescriptor
     {
     protected:
         ODADescriptorImpl*      m_pImpl;
diff --git a/include/svx/databaselocationinput.hxx b/include/svx/databaselocationinput.hxx
index 373305c..69760de 100644
--- a/include/svx/databaselocationinput.hxx
+++ b/include/svx/databaselocationinput.hxx
@@ -45,7 +45,7 @@ namespace svx
 
         This helper class controls such two UI elements.
     */
-    class SVX_DLLPUBLIC DatabaseLocationInputController
+    class SVX_DLLPUBLIC SAL_WARN_UNUSED DatabaseLocationInputController
     {
     public:
         DatabaseLocationInputController(
diff --git a/include/svx/dbaexchange.hxx b/include/svx/dbaexchange.hxx
index eed5b2c..68bd1eb 100644
--- a/include/svx/dbaexchange.hxx
+++ b/include/svx/dbaexchange.hxx
@@ -40,7 +40,7 @@ namespace svx
 
     //= OColumnTransferable
 
-    class SVX_DLLPUBLIC OColumnTransferable : public TransferableHelper
+    class SVX_DLLPUBLIC SAL_WARN_UNUSED OColumnTransferable : public TransferableHelper
     {
     protected:
         ODataAccessDescriptor   m_aDescriptor;
@@ -166,7 +166,7 @@ namespace svx
 
     /** class for transferring data access objects (tables, queries, statements ...)
     */
-    class SVX_DLLPUBLIC ODataAccessObjectTransferable : public TransferableHelper
+    class SVX_DLLPUBLIC SAL_WARN_UNUSED ODataAccessObjectTransferable : public TransferableHelper
     {
         ODataAccessDescriptor   m_aDescriptor;
         OUString         m_sCompatibleObjectDescription;
@@ -254,7 +254,7 @@ namespace svx
 
     /** class for transferring multiple columns
     */
-    class SVX_DLLPUBLIC OMultiColumnTransferable : public TransferableHelper
+    class SVX_DLLPUBLIC SAL_WARN_UNUSED OMultiColumnTransferable : public TransferableHelper
     {
         ::com::sun::star::uno::Sequence< ::com::sun::star::beans::PropertyValue >   m_aDescriptors;
 
diff --git a/include/svx/dbaobjectex.hxx b/include/svx/dbaobjectex.hxx
index 2592d63..57f9844 100644
--- a/include/svx/dbaobjectex.hxx
+++ b/include/svx/dbaobjectex.hxx
@@ -36,7 +36,7 @@ namespace svx
 
     //= OComponentTransferable
 
-    class SVX_DLLPUBLIC OComponentTransferable : public TransferableHelper
+    class SVX_DLLPUBLIC SAL_WARN_UNUSED OComponentTransferable : public TransferableHelper
     {
     protected:
         ODataAccessDescriptor   m_aDescriptor;
diff --git a/include/svx/dbcharsethelper.hxx b/include/svx/dbcharsethelper.hxx
index 3676988..ad02bd9 100644
--- a/include/svx/dbcharsethelper.hxx
+++ b/include/svx/dbcharsethelper.hxx
@@ -30,7 +30,7 @@ namespace svxform
 
     //= ODataAccessCharsetHelper
 
-    class SVX_DLLPUBLIC ODataAccessCharsetHelper
+    class SVX_DLLPUBLIC SAL_WARN_UNUSED ODataAccessCharsetHelper
     {
     protected:
         mutable ::rtl::Reference< ::connectivity::simple::IDataAccessCharSet >  m_xCharsetHelper;
diff --git a/include/svx/deflt3d.hxx b/include/svx/deflt3d.hxx
index 0f2d96c..29cba8a 100644
--- a/include/svx/deflt3d.hxx
+++ b/include/svx/deflt3d.hxx
@@ -31,7 +31,7 @@
 |*
 \************************************************************************/
 
-class SVX_DLLPUBLIC E3dDefaultAttributes
+class SVX_DLLPUBLIC SAL_WARN_UNUSED E3dDefaultAttributes
 {
 private:
     // Compound object
diff --git a/include/svx/dialcontrol.hxx b/include/svx/dialcontrol.hxx
index 38b60e3..36ac077 100644
--- a/include/svx/dialcontrol.hxx
+++ b/include/svx/dialcontrol.hxx
@@ -31,7 +31,7 @@ namespace svx {
 
 
 
-class DialControlBmp : public VirtualDevice
+class SAL_WARN_UNUSED DialControlBmp : public VirtualDevice
 {
 public:
     explicit            DialControlBmp( vcl::Window& rParent );
@@ -75,7 +75,7 @@ private:
     -   Shows the value entered/modified in the numeric field.
     -   Enables/disables/shows/hides the field according to own state changes.
  */
-class SVX_DLLPUBLIC DialControl : public Control
+class SVX_DLLPUBLIC SAL_WARN_UNUSED DialControl : public Control
 {
 public:
     explicit            DialControl( vcl::Window* pParent, WinBits nBits );
@@ -164,10 +164,8 @@ private:
     DECL_LINK( LinkedFieldModifyHdl, NumericField* );
 };
 
-
-
 /** Wrapper for usage of a DialControl in item connections. */
-class SVX_DLLPUBLIC DialControlWrapper : public sfx::SingleControlWrapper< DialControl, sal_Int32 >
+class SVX_DLLPUBLIC SAL_WARN_UNUSED DialControlWrapper : public sfx::SingleControlWrapper< DialControl, sal_Int32 >
 {
 public:
     explicit            DialControlWrapper( DialControl& rDial );
@@ -179,13 +177,9 @@ public:
     virtual void        SetControlValue( sal_Int32 nValue ) SAL_OVERRIDE;
 };
 
-
-
 /** An item<->control connection for a DialControl. */
 typedef sfx::ItemControlConnection< sfx::Int32ItemWrapper, DialControlWrapper > DialControlConnection;
 
-
-
 } // namespace svx
 
 #endif
diff --git a/include/svx/dlgctl3d.hxx b/include/svx/dlgctl3d.hxx
index a17e9a8..09b1c52 100644
--- a/include/svx/dlgctl3d.hxx
+++ b/include/svx/dlgctl3d.hxx
@@ -36,7 +36,7 @@ class E3dObject;
 #define PREVIEW_OBJECTTYPE_SPHERE           0x0000
 #define PREVIEW_OBJECTTYPE_CUBE             0x0001
 
-class SVX_DLLPUBLIC Svx3DPreviewControl : public Control
+class SVX_DLLPUBLIC SAL_WARN_UNUSED Svx3DPreviewControl : public Control
 {
 protected:
     FmFormModel*            mpModel;
@@ -64,7 +64,7 @@ public:
     virtual void Set3DAttributes(const SfxItemSet& rAttr);
 };
 
-class SVX_DLLPUBLIC Svx3DLightControl : public Svx3DPreviewControl
+class SVX_DLLPUBLIC SAL_WARN_UNUSED Svx3DLightControl : public Svx3DPreviewControl
 {
     // Callback for interactive changes
     Link                        maUserInteractiveChangeCallback;
@@ -141,7 +141,7 @@ public:
     basegfx::B3DVector GetLightDirection(sal_uInt32 nNum) const;
 };
 
-class SVX_DLLPUBLIC SvxLightCtl3D : public Control
+class SVX_DLLPUBLIC SAL_WARN_UNUSED SvxLightCtl3D : public Control
 {
 private:
     // local controls
diff --git a/include/svx/dlgctrl.hxx b/include/svx/dlgctrl.hxx
index 01a2de7..ddf50b5 100644
--- a/include/svx/dlgctrl.hxx
+++ b/include/svx/dlgctrl.hxx
@@ -38,7 +38,7 @@ namespace com { namespace sun { namespace star { namespace awt {
 |* virtual method from the control.
 \************************************************************************/
 
-class SvxTabPage : public SfxTabPage
+class SAL_WARN_UNUSED SvxTabPage : public SfxTabPage
 {
 
 public:
@@ -61,7 +61,7 @@ typedef sal_uInt16 CTL_STATE;
 class SvxRectCtlAccessibleContext;
 class SvxPixelCtlAccessible;
 
-class SVX_DLLPUBLIC SvxRectCtl : public Control
+class SVX_DLLPUBLIC SAL_WARN_UNUSED SvxRectCtl : public Control
 {
 private:
     SVX_DLLPRIVATE void             InitSettings( bool bForeground, bool bBackground );
@@ -133,7 +133,7 @@ public:
 |* Preview control for the display of bitmaps
 \************************************************************************/
 
-class SVX_DLLPUBLIC SvxBitmapCtl
+class SVX_DLLPUBLIC SAL_WARN_UNUSED SvxBitmapCtl
 {
 protected:
     Size            aSize;
@@ -157,7 +157,7 @@ public:
 |* Control for editing bitmaps
 \************************************************************************/
 
-class SVX_DLLPUBLIC SvxPixelCtl : public Control
+class SVX_DLLPUBLIC SAL_WARN_UNUSED SvxPixelCtl : public Control
 {
 private:
     using OutputDevice::SetLineColor;
@@ -221,7 +221,7 @@ public:
 
 /************************************************************************/
 
-class SVX_DLLPUBLIC ColorLB : public ColorListBox
+class SVX_DLLPUBLIC SAL_WARN_UNUSED ColorLB : public ColorListBox
 {
 
 public:
@@ -236,7 +236,7 @@ public:
 
 /************************************************************************/
 
-class SVX_DLLPUBLIC HatchingLB : public ListBox
+class SVX_DLLPUBLIC SAL_WARN_UNUSED HatchingLB : public ListBox
 {
     XHatchListRef mpList;
 public:
@@ -250,7 +250,7 @@ public:
 
 /************************************************************************/
 
-class SVX_DLLPUBLIC GradientLB : public ListBox
+class SVX_DLLPUBLIC SAL_WARN_UNUSED GradientLB : public ListBox
 {
     XGradientListRef mpList;
 public:
@@ -266,7 +266,7 @@ public:
 
 /************************************************************************/
 
-class SVX_DLLPUBLIC BitmapLB : public ListBox
+class SVX_DLLPUBLIC SAL_WARN_UNUSED BitmapLB : public ListBox
 {
 public:
     explicit BitmapLB(vcl::Window* pParent, WinBits aWB);
@@ -285,7 +285,7 @@ private:
 
 /************************************************************************/
 
-class FillAttrLB : public ColorListBox
+class FillAttrLB SAL_WARN_UNUSED : public ColorListBox
 {
 private:
     BitmapEx        maBitmapEx;
@@ -301,7 +301,7 @@ public:
 
 /************************************************************************/
 
-class FillTypeLB : public ListBox
+class FillTypeLB SAL_WARN_UNUSED : public ListBox
 {
 
 public:
@@ -313,7 +313,7 @@ public:
 
 /************************************************************************/
 
-class SVX_DLLPUBLIC LineLB : public ListBox
+class SVX_DLLPUBLIC SAL_WARN_UNUSED LineLB : public ListBox
 {
 private:
     /// bitfield
@@ -336,7 +336,7 @@ public:
 
 /************************************************************************/
 
-class SVX_DLLPUBLIC LineEndLB : public ListBox
+class SVX_DLLPUBLIC SAL_WARN_UNUSED LineEndLB : public ListBox
 {
 
 public:
@@ -355,7 +355,7 @@ class SdrObject;
 class SdrPathObj;
 class SdrModel;
 
-class SvxPreviewBase : public Control
+class SAL_WARN_UNUSED SvxPreviewBase : public Control
 {
 private:
     SdrModel*                                       mpModel;
@@ -389,7 +389,7 @@ public:
 |*
 \************************************************************************/
 
-class SVX_DLLPUBLIC SvxXLinePreview : public SvxPreviewBase
+class SVX_DLLPUBLIC SAL_WARN_UNUSED SvxXLinePreview : public SvxPreviewBase
 {
 private:
     SdrPathObj*                                     mpLineObjA;
@@ -421,7 +421,7 @@ public:
 |*
 \************************************************************************/
 
-class SVX_DLLPUBLIC SvxXRectPreview : public SvxPreviewBase
+class SVX_DLLPUBLIC SAL_WARN_UNUSED SvxXRectPreview : public SvxPreviewBase
 {
 private:
     SdrObject*                                      mpRectangleObject;
@@ -442,7 +442,7 @@ public:
 |*
 \************************************************************************/
 
-class SVX_DLLPUBLIC SvxXShadowPreview : public SvxPreviewBase
+class SVX_DLLPUBLIC SAL_WARN_UNUSED SvxXShadowPreview : public SvxPreviewBase
 {
 private:
     Point maShadowOffset;
diff --git a/include/svx/drawitem.hxx b/include/svx/drawitem.hxx
index d2eaafa..e22cac8 100644
--- a/include/svx/drawitem.hxx
+++ b/include/svx/drawitem.hxx
@@ -29,7 +29,7 @@
 //  SvxColorListItem
 
 
-class SVX_DLLPUBLIC SvxColorListItem: public SfxPoolItem
+class SVX_DLLPUBLIC SAL_WARN_UNUSED SvxColorListItem: public SfxPoolItem
 {
     XColorListRef     pColorList;
 
@@ -54,12 +54,8 @@ public:
     void                    SetColorList( const XColorListRef &pTable ) { pColorList = pTable; }
 };
 
-
-
 //  SvxGradientListItem
-
-
-class SVX_DLLPUBLIC SvxGradientListItem: public SfxPoolItem
+class SVX_DLLPUBLIC SAL_WARN_UNUSED SvxGradientListItem : public SfxPoolItem
 {
     XGradientListRef  pGradientList;
 
@@ -89,7 +85,7 @@ public:
 
 //  SvxHatchListItem
 
-class SVX_DLLPUBLIC SvxHatchListItem: public SfxPoolItem
+class SVX_DLLPUBLIC SAL_WARN_UNUSED SvxHatchListItem : public SfxPoolItem
 {
     XHatchListRef     pHatchList;
 
@@ -120,7 +116,7 @@ public:
 
 //  SvxBitmapListItem
 
-class SVX_DLLPUBLIC SvxBitmapListItem: public SfxPoolItem
+class SVX_DLLPUBLIC SAL_WARN_UNUSED SvxBitmapListItem : public SfxPoolItem
 {
     XBitmapListRef    pBitmapList;
 
@@ -151,7 +147,7 @@ public:
 
 //  SvxDashListItem
 
-class SVX_DLLPUBLIC SvxDashListItem: public SfxPoolItem
+class SVX_DLLPUBLIC SAL_WARN_UNUSED SvxDashListItem : public SfxPoolItem
 {
     XDashListRef      pDashList;
 
@@ -179,7 +175,7 @@ public:
 
 //  SvxLineEndListItem
 
-class SVX_DLLPUBLIC SvxLineEndListItem: public SfxPoolItem
+class SVX_DLLPUBLIC SAL_WARN_UNUSED SvxLineEndListItem : public SfxPoolItem
 {
     XLineEndListRef   pLineEndList;
 


More information about the Libreoffice-commits mailing list