[Libreoffice-commits] core.git: 7 commits - filter/source forms/source formula/source fpicker/source framework/source i18npool/source io/source lotuswordpro/source oox/source reportdesign/source sc/source
Noel Grandin
noel at peralex.com
Fri Aug 14 02:13:41 PDT 2015
filter/source/graphicfilter/eps/eps.cxx | 8 +--
filter/source/graphicfilter/icgm/class4.cxx | 2
filter/source/graphicfilter/idxf/dxf2mtf.cxx | 2
filter/source/msfilter/msvbahelper.cxx | 2
filter/source/pdf/impdialog.cxx | 6 +-
filter/source/xsltfilter/OleHandler.cxx | 2
forms/source/component/DatabaseForm.cxx | 2
forms/source/component/ListBox.cxx | 4 -
forms/source/xforms/binding.cxx | 10 ++--
forms/source/xforms/datatyperepository.cxx | 2
formula/source/core/api/FormulaCompiler.cxx | 4 -
fpicker/source/office/OfficeControlAccess.cxx | 2
fpicker/source/office/OfficeFilePicker.cxx | 4 -
fpicker/source/office/OfficeFolderPicker.cxx | 2
fpicker/source/office/RemoteFilesDialog.cxx | 2
fpicker/source/office/commonpicker.cxx | 4 -
fpicker/source/office/iodlg.cxx | 6 +-
framework/source/dispatch/servicehandler.cxx | 2
framework/source/uielement/headermenucontroller.cxx | 2
framework/source/uielement/langselectionmenucontroller.cxx | 2
i18npool/source/breakiterator/breakiteratorImpl.cxx | 6 +-
i18npool/source/breakiterator/breakiterator_cjk.cxx | 2
i18npool/source/breakiterator/breakiterator_unicode.cxx | 6 +-
i18npool/source/breakiterator/xdictionary.cxx | 16 +++----
i18npool/source/indexentry/indexentrysupplier_asian.cxx | 2
io/source/acceptor/acc_pipe.cxx | 3 -
io/source/acceptor/acc_socket.cxx | 3 -
io/source/connector/ctr_pipe.cxx | 3 -
io/source/connector/ctr_socket.cxx | 3 -
lotuswordpro/source/filter/lwpbulletstylemgr.cxx | 2
lotuswordpro/source/filter/lwpdrawobj.cxx | 6 +-
lotuswordpro/source/filter/lwpframelayout.cxx | 2
lotuswordpro/source/filter/lwpfribmark.cxx | 2
lotuswordpro/source/filter/lwplnopts.cxx | 4 -
lotuswordpro/source/filter/lwpmarker.cxx | 8 +--
lotuswordpro/source/filter/lwptools.cxx | 4 -
oox/source/drawingml/customshapegeometry.cxx | 28 ++++++-------
oox/source/drawingml/diagram/diagramdefinitioncontext.cxx | 2
oox/source/drawingml/effectproperties.cxx | 2
oox/source/drawingml/hyperlinkcontext.cxx | 4 -
oox/source/dump/dumperbase.cxx | 2
oox/source/export/drawingml.cxx | 2
oox/source/export/shapes.cxx | 12 ++---
oox/source/helper/textinputstream.cxx | 6 +-
oox/source/helper/zipstorage.cxx | 3 -
oox/source/vml/vmlformatting.cxx | 2
reportdesign/source/filter/xml/xmlStyleImport.cxx | 2
reportdesign/source/ui/dlg/GroupsSorting.cxx | 4 -
reportdesign/source/ui/dlg/Navigator.cxx | 6 +-
reportdesign/source/ui/report/DesignView.cxx | 4 -
reportdesign/source/ui/report/EndMarker.cxx | 2
reportdesign/source/ui/report/ReportController.cxx | 4 -
reportdesign/source/ui/report/ReportSection.cxx | 2
reportdesign/source/ui/report/SectionWindow.cxx | 2
reportdesign/source/ui/report/StartMarker.cxx | 2
reportdesign/source/ui/report/ViewsWindow.cxx | 8 +--
reportdesign/source/ui/report/dlgedfunc.cxx | 6 +-
sc/source/core/data/attarray.cxx | 2
sc/source/core/data/column.cxx | 4 -
sc/source/core/data/documen2.cxx | 4 -
sc/source/core/data/documen3.cxx | 2
sc/source/core/data/documen4.cxx | 2
sc/source/core/data/documen7.cxx | 2
sc/source/core/data/documen8.cxx | 8 +--
sc/source/core/data/documen9.cxx | 3 -
sc/source/core/data/document.cxx | 4 -
sc/source/core/data/documentimport.cxx | 2
sc/source/core/data/dpobject.cxx | 4 -
sc/source/core/data/dpoutput.cxx | 6 +-
sc/source/core/data/dptabres.cxx | 2
sc/source/core/data/drwlayer.cxx | 4 -
sc/source/core/data/formulacell.cxx | 2
sc/source/core/data/funcdesc.cxx | 2
sc/source/core/data/markarr.cxx | 6 +-
sc/source/core/data/markdata.cxx | 4 -
sc/source/core/data/simpleformulacalc.cxx | 2
sc/source/core/data/stlpool.cxx | 10 ++--
sc/source/core/data/stlsheet.cxx | 2
sc/source/core/data/tabprotection.cxx | 2
sc/source/core/opencl/formulagroupcl.cxx | 8 +--
sc/source/core/opencl/opbase.cxx | 4 -
sc/source/core/tool/chgtrack.cxx | 6 +-
sc/source/core/tool/compiler.cxx | 2
sc/source/core/tool/formulagroup.cxx | 2
sc/source/core/tool/interpr1.cxx | 8 +--
sc/source/core/tool/interpr4.cxx | 16 +++----
sc/source/core/tool/rangelst.cxx | 2
sc/source/core/tool/rangeutl.cxx | 7 +--
sc/source/core/tool/reftokenhelper.cxx | 4 -
89 files changed, 187 insertions(+), 198 deletions(-)
New commits:
commit fef9472dcc89688c89b15b997857abb94cb22f47
Author: Noel Grandin <noel at peralex.com>
Date: Wed Aug 12 15:10:45 2015 +0200
loplugin: defaultparams
Change-Id: I0d4b901b6678f3344ed62018d871e1630195aef0
diff --git a/sc/source/core/opencl/formulagroupcl.cxx b/sc/source/core/opencl/formulagroupcl.cxx
index ed03cce..caf5687 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -250,7 +250,7 @@ public:
}
virtual void GenDeclRef( std::stringstream& ss ) const SAL_OVERRIDE
{
- ss << GenSlidingWindowDeclRef(false);
+ ss << GenSlidingWindowDeclRef();
}
virtual void GenSlidingWindowDecl( std::stringstream& ss ) const SAL_OVERRIDE
{
@@ -1801,8 +1801,8 @@ public:
ss << ") {\n\t";
ss << "int gid0 = get_global_id(0), i = 0;\n\t";
ss << "double tmp = ";
- ss << Gen2(vSubArguments[0]->GenSlidingWindowDeclRef(false),
- vSubArguments[1]->GenSlidingWindowDeclRef(false)) << ";\n\t";
+ ss << Gen2(vSubArguments[0]->GenSlidingWindowDeclRef(),
+ vSubArguments[1]->GenSlidingWindowDeclRef()) << ";\n\t";
ss << "return tmp;\n}";
}
virtual bool takeString() const SAL_OVERRIDE { return true; }
@@ -3770,7 +3770,7 @@ void DynamicKernel::CodeGen()
decl << "(__global double *result, ";
DK->GenSlidingWindowDecl(decl);
decl << ") {\n\tint gid0 = get_global_id(0);\n\tresult[gid0] = " <<
- DK->GenSlidingWindowDeclRef(false) << ";\n}\n";
+ DK->GenSlidingWindowDeclRef() << ";\n}\n";
mFullProgramSrc = decl.str();
#ifdef SAL_DETAIL_ENABLE_LOG_INFO
std::stringstream area;
diff --git a/sc/source/core/opencl/opbase.cxx b/sc/source/core/opencl/opbase.cxx
index f1d7b21..a8f2f99 100644
--- a/sc/source/core/opencl/opbase.cxx
+++ b/sc/source/core/opencl/opbase.cxx
@@ -250,7 +250,7 @@ void CheckVariables::CheckSubArgumentIsNan( std::stringstream& ss,
ss << pTmpDVR2->GetArrayLength();
ss << " ||";
ss << "isNan(";
- ss << vSubArguments[i]->GenSlidingWindowDeclRef(false);
+ ss << vSubArguments[i]->GenSlidingWindowDeclRef();
ss << "))\n";
ss << " tmp";
ss << i;
@@ -258,7 +258,7 @@ void CheckVariables::CheckSubArgumentIsNan( std::stringstream& ss,
ss << " tmp";
ss << i;
ss << "=";
- ss << vSubArguments[i]->GenSlidingWindowDeclRef(false);
+ ss << vSubArguments[i]->GenSlidingWindowDeclRef();
ss << ";\n";
}
if (vSubArguments[i]->GetFormulaToken()->GetType() == formula::svDouble ||
diff --git a/sc/source/core/tool/chgtrack.cxx b/sc/source/core/tool/chgtrack.cxx
index fc89f9e..b8785ca 100644
--- a/sc/source/core/tool/chgtrack.cxx
+++ b/sc/source/core/tool/chgtrack.cxx
@@ -3494,7 +3494,7 @@ void ScChangeTrack::UpdateReference( ScChangeAction** ppFirstAction,
{
pActDel->SetCutOffInsert(
static_cast<ScChangeActionIns*>(p), 1 );
- p->GetBigRange().aStart.IncCol( 1 );
+ p->GetBigRange().aStart.IncCol();
}
else if ( aDelRange.In( p->GetBigRange().aEnd ) )
{
@@ -3511,7 +3511,7 @@ void ScChangeTrack::UpdateReference( ScChangeAction** ppFirstAction,
{
pActDel->SetCutOffInsert(
static_cast<ScChangeActionIns*>(p), 1 );
- p->GetBigRange().aStart.IncRow( 1 );
+ p->GetBigRange().aStart.IncRow();
}
else if ( aDelRange.In( p->GetBigRange().aEnd ) )
{
@@ -3528,7 +3528,7 @@ void ScChangeTrack::UpdateReference( ScChangeAction** ppFirstAction,
{
pActDel->SetCutOffInsert(
static_cast<ScChangeActionIns*>(p), 1 );
- p->GetBigRange().aStart.IncTab( 1 );
+ p->GetBigRange().aStart.IncTab();
}
else if ( aDelRange.In( p->GetBigRange().aEnd ) )
{
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 7c2e6aa..1adfaba 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -2521,7 +2521,7 @@ Label_MaskStateMachine:
{ // ?!?
SetError( nErr = errIllegalChar );
nSrcPos = aFormula.getLength();
- aSymbol.truncate(0);
+ aSymbol.truncate();
}
else
{
diff --git a/sc/source/core/tool/formulagroup.cxx b/sc/source/core/tool/formulagroup.cxx
index dfa3689..f196b16 100644
--- a/sc/source/core/tool/formulagroup.cxx
+++ b/sc/source/core/tool/formulagroup.cxx
@@ -478,7 +478,7 @@ FormulaGroupInterpreter *FormulaGroupInterpreter::getStatic()
#if HAVE_FEATURE_OPENCL
const ScCalcConfig& rConfig = ScInterpreter::GetGlobalConfig();
if (officecfg::Office::Common::Misc::UseOpenCL::get())
- switchOpenCLDevice(rConfig.maOpenCLDevice, rConfig.mbOpenCLAutoSelect, false);
+ switchOpenCLDevice(rConfig.maOpenCLDevice, rConfig.mbOpenCLAutoSelect);
#endif
static bool bAllowSoftwareInterpreter = (getenv("SC_ALLOW_BROKEN_SOFTWARE_INTERPRETER") != NULL);
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index f95d5eb..ce59e26 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -5475,7 +5475,7 @@ double ScInterpreter::IterateParametersIfs( ScIterFuncIfs eFunc )
// result matrix is filled with boolean values.
std::vector<double> aResValues;
- pResultMatrix->GetDoubleArray(aResValues, true);
+ pResultMatrix->GetDoubleArray(aResValues);
if (aResArray.size() != aResValues.size())
{
SetError( errIllegalParameter);
@@ -7773,8 +7773,7 @@ void ScInterpreter::ScCurrency()
ScGlobal::eLnge,
true, // mit Tausenderpunkt
false, // nicht rot
- (sal_uInt16) fDec,// Nachkommastellen
- 1); // 1 Vorkommanull
+ (sal_uInt16) fDec);// Nachkommastellen
if (!pFormatter->GetPreviewString(sFormatString,
fVal,
aStr,
@@ -7861,8 +7860,7 @@ void ScInterpreter::ScFixed()
ScGlobal::eLnge,
bThousand, // mit Tausenderpunkt
false, // nicht rot
- (sal_uInt16) fDec,// Nachkommastellen
- 1); // 1 Vorkommanull
+ (sal_uInt16) fDec);// Nachkommastellen
if (!pFormatter->GetPreviewString(sFormatString,
fVal,
aStr,
diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 8548f8e..70c52bc 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -1248,7 +1248,7 @@ ScDBRangeBase* ScInterpreter::PopDBDoubleRef()
SCCOL nCol1, nCol2;
SCROW nRow1, nRow2;
SCTAB nTab1, nTab2;
- PopDoubleRef(nCol1, nRow1, nTab1, nCol2, nRow2, nTab2, false);
+ PopDoubleRef(nCol1, nRow1, nTab1, nCol2, nRow2, nTab2);
if (nGlobalError)
break;
return new ScDBInternalRange(pDok,
@@ -4033,9 +4033,9 @@ StackVar ScInterpreter::Interpret()
case ocGetDiffDate : ScGetDiffDate(); break;
case ocGetDiffDate360 : ScGetDiffDate360(); break;
case ocGetDateDif : ScGetDateDif(); break;
- case ocMin : ScMin( false ); break;
+ case ocMin : ScMin() ; break;
case ocMinA : ScMin( true ); break;
- case ocMax : ScMax( false ); break;
+ case ocMax : ScMax(); break;
case ocMaxA : ScMax( true ); break;
case ocSum : ScSum(); break;
case ocProduct : ScProduct(); break;
@@ -4043,21 +4043,21 @@ StackVar ScInterpreter::Interpret()
case ocIRR : ScIRR(); break;
case ocMIRR : ScMIRR(); break;
case ocISPMT : ScISPMT(); break;
- case ocAverage : ScAverage( false ); break;
+ case ocAverage : ScAverage() ; break;
case ocAverageA : ScAverage( true ); break;
case ocCount : ScCount(); break;
case ocCount2 : ScCount2(); break;
case ocVar :
- case ocVarS : ScVar( false ); break;
+ case ocVarS : ScVar(); break;
case ocVarA : ScVar( true ); break;
case ocVarP :
- case ocVarP_MS : ScVarP( false ); break;
+ case ocVarP_MS : ScVarP(); break;
case ocVarPA : ScVarP( true ); break;
case ocStDev :
- case ocStDevS : ScStDev( false ); break;
+ case ocStDevS : ScStDev(); break;
case ocStDevA : ScStDev( true ); break;
case ocStDevP :
- case ocStDevP_MS : ScStDevP( false ); break;
+ case ocStDevP_MS : ScStDevP(); break;
case ocStDevPA : ScStDevP( true ); break;
case ocPV : ScPV(); break;
case ocSYD : ScSYD(); break;
diff --git a/sc/source/core/tool/rangelst.cxx b/sc/source/core/tool/rangelst.cxx
index 90a01ff..d4bc70e 100644
--- a/sc/source/core/tool/rangelst.cxx
+++ b/sc/source/core/tool/rangelst.cxx
@@ -1003,7 +1003,7 @@ void ScRangeList::DeleteArea( SCCOL nCol1, SCROW nRow1, SCTAB nTab1,
continue;
}
for(vector<ScRange>::iterator itr = aNewRanges.begin(); itr != aNewRanges.end(); ++itr)
- Join( *itr, false);
+ Join( *itr);
}
const ScRange* ScRangeList::Find( const ScAddress& rAdr ) const
diff --git a/sc/source/core/tool/rangeutl.cxx b/sc/source/core/tool/rangeutl.cxx
index fe8b5c0..7c5f13d 100644
--- a/sc/source/core/tool/rangeutl.cxx
+++ b/sc/source/core/tool/rangeutl.cxx
@@ -812,7 +812,6 @@ void ScRangeStringConverter::GetStringFromXMLRangeString( OUString& rString, con
FormulaGrammar::AddressConvention eConv = pDoc->GetAddressConvention();
const sal_Unicode cSep = ' ';
const sal_Unicode cSepNew = ScCompiler::GetNativeSymbolChar(ocSep);
- const sal_Unicode cQuote = '\'';
OUStringBuffer aRetStr;
sal_Int32 nOffset = 0;
@@ -821,11 +820,11 @@ void ScRangeStringConverter::GetStringFromXMLRangeString( OUString& rString, con
while (nOffset >= 0)
{
OUString aToken;
- GetTokenByOffset(aToken, rXMLRange, nOffset, cSep, cQuote);
+ GetTokenByOffset(aToken, rXMLRange, nOffset, cSep);
if (nOffset < 0)
break;
- sal_Int32 nSepPos = IndexOf(aToken, ':', 0, cQuote);
+ sal_Int32 nSepPos = IndexOf(aToken, ':', 0);
if (nSepPos >= 0)
{
// Cell range
@@ -840,7 +839,7 @@ void ScRangeStringConverter::GetStringFromXMLRangeString( OUString& rString, con
if (nEndCellDotPos <= 0)
{
// initialize buffer with table name...
- sal_Int32 nDotPos = IndexOf(aBeginCell, '.', 0, cQuote);
+ sal_Int32 nDotPos = IndexOf(aBeginCell, '.', 0);
OUStringBuffer aBuf = aBeginCell.copy(0, nDotPos);
if (nEndCellDotPos == 0)
diff --git a/sc/source/core/tool/reftokenhelper.cxx b/sc/source/core/tool/reftokenhelper.cxx
index 04070f2..4c7371a 100644
--- a/sc/source/core/tool/reftokenhelper.cxx
+++ b/sc/source/core/tool/reftokenhelper.cxx
@@ -37,8 +37,6 @@ void ScRefTokenHelper::compileRangeRepresentation(
vector<ScTokenRef>& rRefTokens, const OUString& rRangeStr, ScDocument* pDoc,
const sal_Unicode cSep, FormulaGrammar::Grammar eGrammar, bool bOnly3DRef)
{
- const sal_Unicode cQuote = '\'';
-
// #i107275# ignore parentheses
OUString aRangeStr = rRangeStr;
while( (aRangeStr.getLength() >= 2) && (aRangeStr[ 0 ] == '(') && (aRangeStr[ aRangeStr.getLength() - 1 ] == ')') )
@@ -49,7 +47,7 @@ void ScRefTokenHelper::compileRangeRepresentation(
while (nOffset >= 0 && !bFailure)
{
OUString aToken;
- ScRangeStringConverter::GetTokenByOffset(aToken, aRangeStr, nOffset, cSep, cQuote);
+ ScRangeStringConverter::GetTokenByOffset(aToken, aRangeStr, nOffset, cSep);
if (nOffset < 0)
break;
commit 18da84abd6667775b6e79a20418ad4bcb65c45af
Author: Noel Grandin <noel at peralex.com>
Date: Wed Aug 12 15:10:34 2015 +0200
loplugin: defaultparams
Change-Id: I807ce811f5988d6134b4c6f73408cd034f25a7f7
diff --git a/sc/source/core/data/attarray.cxx b/sc/source/core/data/attarray.cxx
index 216ede6..65c2331 100644
--- a/sc/source/core/data/attarray.cxx
+++ b/sc/source/core/data/attarray.cxx
@@ -932,7 +932,7 @@ void ScAttrArray::MergePatternArea( SCROW nStartRow, SCROW nEndRow,
if (bDeep)
lcl_MergeDeep( *rState.pItemSet, rThisSet );
else
- rState.pItemSet->MergeValues( rThisSet, false );
+ rState.pItemSet->MergeValues( rThisSet );
}
else
{
diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index 846a52f..c7d71e3 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -1819,7 +1819,7 @@ void ScColumn::MarkScenarioIn( ScMarkData& rDestMark ) const
{
aRange.aStart.SetRow( nStart );
aRange.aEnd.SetRow( nEnd );
- rDestMark.SetMultiMarkArea( aRange, true );
+ rDestMark.SetMultiMarkArea( aRange );
}
pPattern = aAttrIter.Next( nStart, nEnd );
@@ -2872,7 +2872,7 @@ public:
sc::SharedFormulaUtil::unshareFormulaCell(aPos, *pCell);
pCell->GetCode()->SetCodeError(0);
OUString aFormula = pCell->GetFormula(mrCxt);
- pCell->Compile(mrCxt, aFormula, false);
+ pCell->Compile(mrCxt, aFormula);
ScColumn::JoinNewFormulaCell(aPos, *pCell);
mbCompiled = true;
diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx
index 5b02cf7..bfea26f 100644
--- a/sc/source/core/data/documen2.cxx
+++ b/sc/source/core/data/documen2.cxx
@@ -256,7 +256,7 @@ ScDocument::ScDocument( ScDocumentMode eMode, SfxObjectShell* pDocShell ) :
sfx2::LinkManager* ScDocument::GetLinkManager()
{
- return GetDocLinkManager().getLinkManager(true);
+ return GetDocLinkManager().getLinkManager();
}
const sfx2::LinkManager* ScDocument::GetLinkManager() const
@@ -345,7 +345,7 @@ IMPL_LINK_NOARG_TYPED(ScDocument, TrackTimeHdl, Idle *, void)
if (!pShell->IsModified())
{
- pShell->SetModified( true );
+ pShell->SetModified();
SfxBindings* pBindings = GetViewBindings();
if (pBindings)
{
diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx
index 5e3df16..5e6aa4d 100644
--- a/sc/source/core/data/documen3.cxx
+++ b/sc/source/core/data/documen3.cxx
@@ -994,7 +994,7 @@ void ScDocument::UpdateReference(
xRowNameRanges->UpdateReference( eUpdateRefMode, this, aRange, nDx, nDy, nDz );
pDBCollection->UpdateReference( eUpdateRefMode, nCol1, nRow1, nTab1, nCol2, nRow2, nTab2, nDx, nDy, nDz );
if (pRangeName)
- pRangeName->UpdateReference(rCxt, -1);
+ pRangeName->UpdateReference(rCxt);
if ( pDPCollection )
pDPCollection->UpdateReference( eUpdateRefMode, aRange, nDx, nDy, nDz );
UpdateChartRef( eUpdateRefMode, nCol1, nRow1, nTab1, nCol2, nRow2, nTab2, nDx, nDy, nDz );
diff --git a/sc/source/core/data/documen4.cxx b/sc/source/core/data/documen4.cxx
index 8b73c47..4d93eca 100644
--- a/sc/source/core/data/documen4.cxx
+++ b/sc/source/core/data/documen4.cxx
@@ -602,7 +602,7 @@ bool ScDocument::GetSelectionFunction( ScSubTotalFunc eFunc,
ScMarkData aMark(rMark);
aMark.MarkToMulti();
- if (!aMark.IsMultiMarked() && !aMark.IsCellMarked(rCursor.Col(), rCursor.Row(), false))
+ if (!aMark.IsMultiMarked() && !aMark.IsCellMarked(rCursor.Col(), rCursor.Row()))
aMark.SetMarkArea(rCursor);
SCTAB nMax = static_cast<SCTAB>(maTabs.size());
diff --git a/sc/source/core/data/documen7.cxx b/sc/source/core/data/documen7.cxx
index c60619e..7d0315a 100644
--- a/sc/source/core/data/documen7.cxx
+++ b/sc/source/core/data/documen7.cxx
@@ -452,7 +452,7 @@ void ScDocument::CalcFormulaTree( bool bOnlyForced, bool bProgressBar, bool bSet
bool bProgress = !bOnlyForced && nFormulaCodeInTree && bProgressBar;
if ( bProgress )
- ScProgress::CreateInterpretProgress( this, true );
+ ScProgress::CreateInterpretProgress( this );
pCell = pFormulaTree;
ScFormulaCell* pLastNoGood = 0;
diff --git a/sc/source/core/data/documen8.cxx b/sc/source/core/data/documen8.cxx
index 5c094ad..85be656 100644
--- a/sc/source/core/data/documen8.cxx
+++ b/sc/source/core/data/documen8.cxx
@@ -484,7 +484,7 @@ public:
// the calls.
mrDoc.EnableIdle(false);
- mpStylePool->SetSearchMask(SFX_STYLE_FAMILY_PAGE, SFXSTYLEBIT_ALL);
+ mpStylePool->SetSearchMask(SFX_STYLE_FAMILY_PAGE);
}
~IdleCalcTextWidthScope()
@@ -857,7 +857,7 @@ void ScDocument::UpdateExternalRefLinks(vcl::Window* pWin)
// #i101960# set document modified, as in TrackTimeHdl for DDE links
if (!pShell->IsModified())
{
- pShell->SetModified( true );
+ pShell->SetModified();
SfxBindings* pBindings = GetViewBindings();
if (pBindings)
{
@@ -1249,7 +1249,7 @@ void ScDocument::TransliterateText( const ScMarkData& rMultiMark, sal_Int32 nTyp
SfxItemSet* pFontSet = GetPreviewFont( nCol, nRow, nTab );
pPattern->FillEditItemSet( pDefaults, pFontSet );
}
- pEngine->SetDefaults( pDefaults, true );
+ pEngine->SetDefaults( pDefaults );
if (aCell.meType == CELLTYPE_STRING)
pEngine->SetText(aCell.mpString->getString());
else if (aCell.mpEditText)
@@ -1272,7 +1272,7 @@ void ScDocument::TransliterateText( const ScMarkData& rMultiMark, sal_Int32 nTyp
{
// remove defaults (paragraph attributes) before creating text object
SfxItemSet* pEmpty = new SfxItemSet( pEngine->GetEmptyItemSet() );
- pEngine->SetDefaults( pEmpty, true );
+ pEngine->SetDefaults( pEmpty );
// The cell will take ownership of the text object instance.
SetEditText(ScAddress(nCol,nRow,nTab), pEngine->CreateTextObject());
diff --git a/sc/source/core/data/documen9.cxx b/sc/source/core/data/documen9.cxx
index 18d483c..790db1f 100644
--- a/sc/source/core/data/documen9.cxx
+++ b/sc/source/core/data/documen9.cxx
@@ -504,8 +504,7 @@ bool ScDocument::IsPrintEmpty( SCTAB nTab, SCCOL nStartCol, SCROW nStartRow,
// might create and assign a printer.
ScDocument* pThis = const_cast<ScDocument*>(this);
- pThis->ExtendMerge( 0,nStartRow, nExtendCol,nTmpRow, nTab,
- false ); // no Refresh, incl. Attrs
+ pThis->ExtendMerge( 0,nStartRow, nExtendCol,nTmpRow, nTab ); // no Refresh, incl. Attrs
OutputDevice* pDev = pThis->GetPrinter();
pDev->SetMapMode( MAP_PIXEL ); // Important for GetNeededSize
diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index febf0df..7943fa5 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -4125,7 +4125,7 @@ void ScDocument::UpdateAllRowHeights( sc::RowHeightContext& rCxt, const ScMarkDa
if ( maTabs[nTab] && ( !pTabMark || pTabMark->GetTableSelect(nTab) ) )
{
maTabs[nTab]->SetOptimalHeightOnly(rCxt, 0, MAXROW, &aProgress, nProgressStart);
- maTabs[nTab]->SetDrawPageSize(true, true);
+ maTabs[nTab]->SetDrawPageSize(true);
nProgressStart += maTabs[nTab]->GetWeightedCount();
}
}
@@ -5415,7 +5415,7 @@ bool ScDocument::ExtendTotalMerge( ScRange& rRange ) const
bool bRet = false;
ScRange aExt = rRange;
// ExtendMerge() is non-const, but called withouth refresh.
- if (const_cast<ScDocument*>(this)->ExtendMerge( aExt, false))
+ if (const_cast<ScDocument*>(this)->ExtendMerge( aExt ))
{
if ( aExt.aEnd.Row() > rRange.aEnd.Row() )
{
diff --git a/sc/source/core/data/documentimport.cxx b/sc/source/core/data/documentimport.cxx
index 419c366..642bbc2 100644
--- a/sc/source/core/data/documentimport.cxx
+++ b/sc/source/core/data/documentimport.cxx
@@ -309,7 +309,7 @@ void ScDocumentImport::setMatrixCells(
// Matrix formulas currently need re-calculation on import.
pCell->SetMatColsRows(
- rRange.aEnd.Col()-rRange.aStart.Col()+1, rRange.aEnd.Row()-rRange.aStart.Row()+1, true);
+ rRange.aEnd.Col()-rRange.aStart.Col()+1, rRange.aEnd.Row()-rRange.aStart.Row()+1);
// Set the reference cells.
ScSingleRefData aRefData;
diff --git a/sc/source/core/data/dpobject.cxx b/sc/source/core/data/dpobject.cxx
index 009c60d..db4ccd2 100644
--- a/sc/source/core/data/dpobject.cxx
+++ b/sc/source/core/data/dpobject.cxx
@@ -1251,7 +1251,7 @@ OUString ScDPObject::GetDimName( long nDim, bool& rIsDataLayout, sal_Int32* pFla
if (pFlags)
*pFlags = ScUnoHelpFunctions::GetLongProperty( xDimProp,
- OUString(SC_UNO_DP_FLAGS), 0 );
+ OUString(SC_UNO_DP_FLAGS) );
}
}
}
@@ -2353,7 +2353,7 @@ bool ScDPObject::FillLabelDataForDimension(
GetMembers(nDim, GetUsedHierarchy(nDim), rLabelData.maMembers);
lcl_FillLabelData(rLabelData, xDimProp);
rLabelData.mnFlags = ScUnoHelpFunctions::GetLongProperty(
- xDimProp, OUString(SC_UNO_DP_FLAGS), 0);
+ xDimProp, OUString(SC_UNO_DP_FLAGS) );
}
return true;
}
diff --git a/sc/source/core/data/dpoutput.cxx b/sc/source/core/data/dpoutput.cxx
index 450c5bb..a2c13f8 100644
--- a/sc/source/core/data/dpoutput.cxx
+++ b/sc/source/core/data/dpoutput.cxx
@@ -263,7 +263,7 @@ void ScDPOutputImpl::OutputBlockFrame ( SCCOL nStartCol, SCROW nStartRow, SCCOL
aBoxInfo.SetValid(SvxBoxInfoItemValidFlags::VERT,false );
if ( bHori )
{
- aBoxInfo.SetValid(SvxBoxInfoItemValidFlags::HORI,true);
+ aBoxInfo.SetValid(SvxBoxInfoItemValidFlags::HORI);
aBoxInfo.SetLine( &aLine, SvxBoxInfoItemLine::HORI );
}
else
@@ -491,7 +491,7 @@ uno::Sequence<sheet::MemberResult> getVisiblePageMembersAsResults( const uno::Re
if (aCaption.isEmpty())
aCaption = rName;
- bool bVisible = ScUnoHelpFunctions::GetBoolProperty(xMemPS, SC_UNO_DP_ISVISIBLE, false);
+ bool bVisible = ScUnoHelpFunctions::GetBoolProperty(xMemPS, SC_UNO_DP_ISVISIBLE);
if (bVisible)
aRes.push_back(sheet::MemberResult(rName, aCaption, 0));
@@ -563,7 +563,7 @@ ScDPOutput::ScDPOutput( ScDocument* pD, const uno::Reference<sheet::XDimensionsS
bool bHasHiddenMember = ScUnoHelpFunctions::GetBoolProperty(
xDimProp, OUString(SC_UNO_DP_HAS_HIDDEN_MEMBER));
sal_Int32 nNumFmt = ScUnoHelpFunctions::GetLongProperty(
- xDimProp, SC_UNO_DP_NUMBERFO, 0);
+ xDimProp, SC_UNO_DP_NUMBERFO);
if ( eDimOrient != sheet::DataPilotFieldOrientation_HIDDEN )
{
diff --git a/sc/source/core/data/dptabres.cxx b/sc/source/core/data/dptabres.cxx
index 146bbf4..cda6832 100644
--- a/sc/source/core/data/dptabres.cxx
+++ b/sc/source/core/data/dptabres.cxx
@@ -1051,7 +1051,7 @@ void ScDPResultMember::InitFrom( const vector<ScDPDimension*>& ppDim, const vect
if ( bInitChild )
{
pChildDimension = new ScDPResultDimension( pResultData );
- pChildDimension->InitFrom(ppDim, ppLev, nPos, rInitState, true);
+ pChildDimension->InitFrom(ppDim, ppLev, nPos, rInitState);
}
}
diff --git a/sc/source/core/data/drwlayer.cxx b/sc/source/core/data/drwlayer.cxx
index 032637c..dc7576c 100644
--- a/sc/source/core/data/drwlayer.cxx
+++ b/sc/source/core/data/drwlayer.cxx
@@ -267,7 +267,7 @@ ScDrawLayer::ScDrawLayer( ScDocument* pDocument, const OUString& rName ) :
}
SetPropertyList( static_cast<XPropertyList *> (pXCol.get()) );
- SetSwapGraphics(true);
+ SetSwapGraphics();
SetScaleUnit(MAP_100TH_MM);
SfxItemPool& rPool = GetItemPool();
@@ -556,7 +556,7 @@ void ScDrawLayer::MoveCells( SCTAB nTab, SCCOL nCol1,SCROW nRow1, SCCOL nCol2,SC
pData->maStart.PutInOrder( pData->maEnd );
// Update also an untransformed anchor thats what we stored ( and still do ) to xml
- ScDrawObjData* pNoRotatedAnchor = GetNonRotatedObjData( pObj, false );
+ ScDrawObjData* pNoRotatedAnchor = GetNonRotatedObjData( pObj );
if ( pNoRotatedAnchor )
{
pNoRotatedAnchor->maStart = pData->maStart;
diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx
index e02c3cc..c90ab3e 100644
--- a/sc/source/core/data/formulacell.cxx
+++ b/sc/source/core/data/formulacell.cxx
@@ -3172,7 +3172,7 @@ bool ScFormulaCell::UpdateReferenceOnCopy(
if (bCompile)
{
- CompileTokenArray(false); // no Listening
+ CompileTokenArray(); // no Listening
bNeedDirty = true;
}
diff --git a/sc/source/core/data/funcdesc.cxx b/sc/source/core/data/funcdesc.cxx
index 8749059..61e2f64 100644
--- a/sc/source/core/data/funcdesc.cxx
+++ b/sc/source/core/data/funcdesc.cxx
@@ -690,7 +690,7 @@ ScFunctionMgr::~ScFunctionMgr()
const ScFuncDesc* ScFunctionMgr::Get( sal_uInt16 nFIndex ) const
{
const ScFuncDesc* pDesc;
- for (pDesc = First(0); pDesc; pDesc = Next())
+ for (pDesc = First(); pDesc; pDesc = Next())
if (pDesc->nFIndex == nFIndex)
break;
return pDesc;
diff --git a/sc/source/core/data/markarr.cxx b/sc/source/core/data/markarr.cxx
index 6a83437..baa9aab 100644
--- a/sc/source/core/data/markarr.cxx
+++ b/sc/source/core/data/markarr.cxx
@@ -108,7 +108,7 @@ void ScMarkArray::SetMarkArea( SCROW nStartRow, SCROW nEndRow, bool bMarked )
else
{
if (!pData)
- Reset(false); // create pData for further processing - could use special case handling!
+ Reset(); // create pData for further processing - could use special case handling!
SCSIZE nNeeded = nCount + 2;
if ( nLimit < nNeeded )
@@ -309,7 +309,7 @@ void ScMarkArray::CopyMarksTo( ScMarkArray& rDestMarkArray ) const
SCsROW ScMarkArray::GetNextMarked( SCsROW nRow, bool bUp ) const
{
if (!pData)
- const_cast<ScMarkArray*>(this)->Reset(false); // create pData for further processing
+ const_cast<ScMarkArray*>(this)->Reset(); // create pData for further processing
SCsROW nRet = nRow;
if (ValidRow(nRow))
@@ -335,7 +335,7 @@ SCsROW ScMarkArray::GetNextMarked( SCsROW nRow, bool bUp ) const
SCROW ScMarkArray::GetMarkEnd( SCROW nRow, bool bUp ) const
{
if (!pData)
- const_cast<ScMarkArray*>(this)->Reset(false); // create pData for further processing
+ const_cast<ScMarkArray*>(this)->Reset(); // create pData for further processing
SCROW nRet;
SCSIZE nIndex;
diff --git a/sc/source/core/data/markdata.cxx b/sc/source/core/data/markdata.cxx
index 28c18d7..ab333db 100644
--- a/sc/source/core/data/markdata.cxx
+++ b/sc/source/core/data/markdata.cxx
@@ -131,7 +131,7 @@ void ScMarkData::SetMultiMarkArea( const ScRange& rRange, bool bMark )
if ( bMarked && !bMarkIsNeg )
{
bMarked = false;
- SetMultiMarkArea( aMarkRange, true );
+ SetMultiMarkArea( aMarkRange );
}
}
@@ -363,7 +363,7 @@ void ScMarkData::MarkFromRangeList( const ScRangeList& rList, bool bReset )
for (size_t i=0; i < nCount; i++)
{
const ScRange& rRange = *rList[ i ];
- SetMultiMarkArea( rRange, true );
+ SetMultiMarkArea( rRange );
SelectTable( rRange.aStart.Tab(), true );
}
}
diff --git a/sc/source/core/data/simpleformulacalc.cxx b/sc/source/core/data/simpleformulacalc.cxx
index a931551..885d403 100644
--- a/sc/source/core/data/simpleformulacalc.cxx
+++ b/sc/source/core/data/simpleformulacalc.cxx
@@ -53,7 +53,7 @@ void ScSimpleFormulaCalculator::Calculate()
ScCompiler aComp(mpDoc, maAddr);
aComp.SetGrammar(maGram);
OUStringBuffer aStr;
- aComp.CreateStringFromToken(aStr, aInt.GetResultToken().get(), false);
+ aComp.CreateStringFromToken(aStr, aInt.GetResultToken().get());
bIsMatrix = true;
diff --git a/sc/source/core/data/stlpool.cxx b/sc/source/core/data/stlpool.cxx
index 996a35a..d175cc7 100644
--- a/sc/source/core/data/stlpool.cxx
+++ b/sc/source/core/data/stlpool.cxx
@@ -373,11 +373,11 @@ void ScStyleSheetPool::CreateStandardStyles()
aBoxItem.SetLine( &aBorderLine, SvxBoxItemLine::LEFT );
aBoxItem.SetLine( &aBorderLine, SvxBoxItemLine::RIGHT );
aBoxItem.SetDistance( 10 ); // 0.2mm
- aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::TOP, true );
- aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::BOTTOM, true );
- aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::LEFT, true );
- aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::RIGHT, true );
- aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::DISTANCE, true );
+ aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::TOP );
+ aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::BOTTOM );
+ aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::LEFT );
+ aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::RIGHT );
+ aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::DISTANCE );
aBoxInfoItem.SetTable( false );
aBoxInfoItem.SetDist ( true );
diff --git a/sc/source/core/data/stlsheet.cxx b/sc/source/core/data/stlsheet.cxx
index be060c2..58be8f5 100644
--- a/sc/source/core/data/stlsheet.cxx
+++ b/sc/source/core/data/stlsheet.cxx
@@ -184,7 +184,7 @@ SfxItemSet& ScStyleSheet::GetItemSet()
aBoxInfoItem.SetTable( false );
aBoxInfoItem.SetDist( true );
- aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::DISTANCE, true );
+ aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::DISTANCE );
aPageItem.SetLandscape( false );
diff --git a/sc/source/core/data/tabprotection.cxx b/sc/source/core/data/tabprotection.cxx
index 1c20c26..8dffb4e 100644
--- a/sc/source/core/data/tabprotection.cxx
+++ b/sc/source/core/data/tabprotection.cxx
@@ -135,7 +135,7 @@ Sequence<sal_Int8> ScTableProtectionImpl::hashPassword(const OUString& aPassText
switch (eHash)
{
case PASSHASH_XL:
- aHash = ::comphelper::DocPasswordHelper::GetXLHashAsSequence( aPassText, RTL_TEXTENCODING_UTF8 );
+ aHash = ::comphelper::DocPasswordHelper::GetXLHashAsSequence( aPassText );
break;
case PASSHASH_SHA1:
SvPasswordHelper::GetHashPassword(aHash, aPassText);
commit 8cb23d00070d18268d63a336ebc419c5092fc081
Author: Noel Grandin <noel at peralex.com>
Date: Wed Aug 12 15:10:26 2015 +0200
loplugin: defaultparams
Change-Id: I552e9337fc049aff41904cdcbe09982c97281d61
diff --git a/reportdesign/source/filter/xml/xmlStyleImport.cxx b/reportdesign/source/filter/xml/xmlStyleImport.cxx
index 5ccd4e5..563609c 100644
--- a/reportdesign/source/filter/xml/xmlStyleImport.cxx
+++ b/reportdesign/source/filter/xml/xmlStyleImport.cxx
@@ -99,7 +99,7 @@ void OControlStyleContext::FillPropertySet(const Reference< XPropertySet > & rPr
if ((m_nNumberFormat == -1) && !m_sDataStyleName.isEmpty())
{
SvXMLNumFormatContext* pStyle = const_cast< SvXMLNumFormatContext*>(dynamic_cast<const SvXMLNumFormatContext*>(pStyles->FindStyleChildContext(
- XML_STYLE_FAMILY_DATA_STYLE, m_sDataStyleName, false)));
+ XML_STYLE_FAMILY_DATA_STYLE, m_sDataStyleName)));
if ( !pStyle )
{
OReportStylesContext* pMyStyles = PTR_CAST(OReportStylesContext,GetOwnImport().GetAutoStyles());
diff --git a/reportdesign/source/ui/dlg/GroupsSorting.cxx b/reportdesign/source/ui/dlg/GroupsSorting.cxx
index 6acd0d9..dc604e8 100644
--- a/reportdesign/source/ui/dlg/GroupsSorting.cxx
+++ b/reportdesign/source/ui/dlg/GroupsSorting.cxx
@@ -1334,7 +1334,7 @@ void OGroupsSortingDialog::checkButtons(sal_Int32 _nRow)
if (bEnabled && _nRow > 0 )
{
- m_pToolBox->EnableItem(m_nMoveUpId, true);
+ m_pToolBox->EnableItem(m_nMoveUpId);
}
else
{
@@ -1342,7 +1342,7 @@ void OGroupsSortingDialog::checkButtons(sal_Int32 _nRow)
}
if (bEnabled && _nRow < (nRowCount - 1) )
{
- m_pToolBox->EnableItem(m_nMoveDownId, true);
+ m_pToolBox->EnableItem(m_nMoveDownId);
}
else
{
diff --git a/reportdesign/source/ui/dlg/Navigator.cxx b/reportdesign/source/ui/dlg/Navigator.cxx
index 431d92c..c209273 100644
--- a/reportdesign/source/ui/dlg/Navigator.cxx
+++ b/reportdesign/source/ui/dlg/Navigator.cxx
@@ -291,7 +291,7 @@ void NavigatorTree::Command( const CommandEvent& rEvt )
if ( !IsSelected(ptClickedOn) )
{
SelectAll(false);
- Select(ptClickedOn, true);
+ Select(ptClickedOn);
SetCurEntry(ptClickedOn);
}
}
@@ -484,7 +484,7 @@ void NavigatorTree::_selectionChanged( const lang::EventObject& aEvent ) throw (
SvTreeListEntry* pEntry = find(xSelection);
if ( pEntry && !IsSelected(pEntry) )
{
- Select(pEntry, true);
+ Select(pEntry);
SetCurEntry(pEntry);
}
else if ( !pEntry )
@@ -499,7 +499,7 @@ void NavigatorTree::_selectionChanged( const lang::EventObject& aEvent ) throw (
SvTreeListEntry* pEntry = find(*pIter);
if ( pEntry && !IsSelected(pEntry) )
{
- Select(pEntry, true);
+ Select(pEntry);
SetCurEntry(pEntry);
}
}
diff --git a/reportdesign/source/ui/report/DesignView.cxx b/reportdesign/source/ui/report/DesignView.cxx
index a12453e..4a014c0 100644
--- a/reportdesign/source/ui/report/DesignView.cxx
+++ b/reportdesign/source/ui/report/DesignView.cxx
@@ -141,14 +141,14 @@ void ODesignView::dispose()
if ( m_pAddField )
{
SvtViewOptions aDlgOpt( E_WINDOW, OUString( UID_RPT_RPT_APP_VIEW ) );
- aDlgOpt.SetWindowState(OStringToOUString(m_pAddField->GetWindowState(WINDOWSTATE_MASK_ALL), RTL_TEXTENCODING_ASCII_US));
+ aDlgOpt.SetWindowState(OStringToOUString(m_pAddField->GetWindowState(), RTL_TEXTENCODING_ASCII_US));
notifySystemWindow(this,m_pAddField,::comphelper::mem_fun(&TaskPaneList::RemoveWindow));
m_pAddField.disposeAndClear();
}
if ( m_pReportExplorer )
{
SvtViewOptions aDlgOpt(E_WINDOW, OStringToOUString(m_pReportExplorer->GetHelpId(), RTL_TEXTENCODING_UTF8));
- aDlgOpt.SetWindowState(OStringToOUString(m_pReportExplorer->GetWindowState(WINDOWSTATE_MASK_ALL), RTL_TEXTENCODING_ASCII_US));
+ aDlgOpt.SetWindowState(OStringToOUString(m_pReportExplorer->GetWindowState(), RTL_TEXTENCODING_ASCII_US));
notifySystemWindow(this,m_pReportExplorer,::comphelper::mem_fun(&TaskPaneList::RemoveWindow));
m_pReportExplorer.disposeAndClear();
}
diff --git a/reportdesign/source/ui/report/EndMarker.cxx b/reportdesign/source/ui/report/EndMarker.cxx
index d6137e3..a16d89b 100644
--- a/reportdesign/source/ui/report/EndMarker.cxx
+++ b/reportdesign/source/ui/report/EndMarker.cxx
@@ -79,7 +79,7 @@ void OEndMarker::Paint(vcl::RenderContext& rRenderContext, const Rectangle& /*rR
void OEndMarker::ImplInitSettings()
{
- EnableChildTransparentMode( true );
+ EnableChildTransparentMode();
SetParentClipMode( ParentClipMode::NoClip );
SetPaintTransparent( true );
diff --git a/reportdesign/source/ui/report/ReportController.cxx b/reportdesign/source/ui/report/ReportController.cxx
index 05f56ba..38c4c9a 100644
--- a/reportdesign/source/ui/report/ReportController.cxx
+++ b/reportdesign/source/ui/report/ReportController.cxx
@@ -338,7 +338,7 @@ void OReportController::disposing()
if ( m_pGroupsFloater )
{
SvtViewOptions aDlgOpt(E_WINDOW, OStringToOUString(m_pGroupsFloater->GetHelpId(), RTL_TEXTENCODING_UTF8));
- aDlgOpt.SetWindowState(OStringToOUString(m_pGroupsFloater->GetWindowState(WINDOWSTATE_MASK_ALL), RTL_TEXTENCODING_ASCII_US));
+ aDlgOpt.SetWindowState(OStringToOUString(m_pGroupsFloater->GetWindowState(), RTL_TEXTENCODING_ASCII_US));
m_pGroupsFloater.disposeAndClear();
}
@@ -2505,7 +2505,7 @@ void OReportController::openPageDialog(const uno::Reference<report::XSection>& _
if ( SfxItemState::SET == pSet->GetItemState( RPTUI_ID_SIZE,true,&pItem))
{
uno::Any aValue;
- static_cast<const SvxSizeItem*>(pItem)->QueryValue(aValue,MID_SIZE_SIZE);
+ static_cast<const SvxSizeItem*>(pItem)->QueryValue(aValue);
xProp->setPropertyValue(PROPERTY_PAPERSIZE,aValue);
resetZoomType();
}
diff --git a/reportdesign/source/ui/report/ReportSection.cxx b/reportdesign/source/ui/report/ReportSection.cxx
index 38d8aa5..7c5ef02 100644
--- a/reportdesign/source/ui/report/ReportSection.cxx
+++ b/reportdesign/source/ui/report/ReportSection.cxx
@@ -229,7 +229,7 @@ void OReportSection::fill()
// LLA: TODO
// m_pPage->SetUppBorder(-10000);
- m_pView->SetDesignMode( true );
+ m_pView->SetDesignMode();
m_pView->StartListening( *m_pModel );
m_pPage->SetSize( Size( getStyleProperty<awt::Size>(xReportDefinition,PROPERTY_PAPERSIZE).Width,5*m_xSection->getHeight()) );
diff --git a/reportdesign/source/ui/report/SectionWindow.cxx b/reportdesign/source/ui/report/SectionWindow.cxx
index a495fe1..4a66469 100644
--- a/reportdesign/source/ui/report/SectionWindow.cxx
+++ b/reportdesign/source/ui/report/SectionWindow.cxx
@@ -207,7 +207,7 @@ void OSectionWindow::ImplInitSettings()
static bool t = false;
if ( t )
{
- EnableChildTransparentMode( true );
+ EnableChildTransparentMode();
SetParentClipMode( ParentClipMode::NoClip );
SetPaintTransparent( true );
}
diff --git a/reportdesign/source/ui/report/StartMarker.cxx b/reportdesign/source/ui/report/StartMarker.cxx
index fb6ad49..dc2b4fe 100644
--- a/reportdesign/source/ui/report/StartMarker.cxx
+++ b/reportdesign/source/ui/report/StartMarker.cxx
@@ -73,7 +73,7 @@ OStartMarker::OStartMarker(OSectionWindow* _pParent,const OUString& _sColorEntry
m_aVRuler->SetMargin2();
const MeasurementSystem eSystem = SvtSysLocale().GetLocaleData().getMeasurementSystemEnum();
m_aVRuler->SetUnit(MEASURE_METRIC == eSystem ? FUNIT_CM : FUNIT_INCH);
- EnableChildTransparentMode( true );
+ EnableChildTransparentMode();
SetParentClipMode( ParentClipMode::NoClip );
SetPaintTransparent( true );
}
diff --git a/reportdesign/source/ui/report/ViewsWindow.cxx b/reportdesign/source/ui/report/ViewsWindow.cxx
index eef1d57..5542cfd 100644
--- a/reportdesign/source/ui/report/ViewsWindow.cxx
+++ b/reportdesign/source/ui/report/ViewsWindow.cxx
@@ -284,7 +284,7 @@ void OViewsWindow::Paint(vcl::RenderContext& rRenderContext, const Rectangle& rR
void OViewsWindow::ImplInitSettings()
{
- EnableChildTransparentMode(true);
+ EnableChildTransparentMode();
}
void OViewsWindow::DataChanged( const DataChangedEvent& rDCEvt )
@@ -410,7 +410,7 @@ void OViewsWindow::Paste()
if ( aCopies.getLength() > 1 )
::std::for_each(m_aSections.begin(),m_aSections.end(),
[&aCopies] (const TSectionsMap::value_type& sectionPtr) {
- sectionPtr->getReportSection().Paste(aCopies, false);
+ sectionPtr->getReportSection().Paste(aCopies);
});
else
{
@@ -1286,7 +1286,7 @@ void OViewsWindow::EndDragObj(bool _bControlKeyPressed, const OSectionView* _pSe
rReportSection.Copy(aAllreadyCopiedObjects,true);
}
else
- pInSection->EndDragObj(false);
+ pInSection->EndDragObj();
}
if ( aAllreadyCopiedObjects.getLength() )
@@ -1630,7 +1630,7 @@ void OViewsWindow::handleKey(const vcl::KeyCode& _rCode)
// switch snapping off
if ( !bWasNoSnap )
- ((SdrDragStat&)rDragStat).SetNoSnap( true );
+ ((SdrDragStat&)rDragStat).SetNoSnap();
if ( bWasSnapEnabled )
rView.SetSnapEnabled( false );
diff --git a/reportdesign/source/ui/report/dlgedfunc.cxx b/reportdesign/source/ui/report/dlgedfunc.cxx
index 40ef759..553d096 100644
--- a/reportdesign/source/ui/report/dlgedfunc.cxx
+++ b/reportdesign/source/ui/report/dlgedfunc.cxx
@@ -649,14 +649,14 @@ bool DlgEdFunc::setMovementPointer(const MouseEvent& rMEvt)
DlgEdFuncInsert::DlgEdFuncInsert( OReportSection* _pParent ) :
DlgEdFunc( _pParent )
{
- m_rView.SetCreateMode( true );
+ m_rView.SetCreateMode();
}
DlgEdFuncInsert::~DlgEdFuncInsert()
{
- m_rView.SetEditMode( true );
+ m_rView.SetEditMode();
}
@@ -708,7 +708,7 @@ bool DlgEdFuncInsert::MouseButtonUp( const MouseEvent& rMEvt )
{
m_pParent->getSectionWindow()->getViewsWindow()->BrkAction();
// BrkAction disables the create mode
- m_rView.SetCreateMode( true );
+ m_rView.SetCreateMode();
return true;
}
commit 1656a7ff431df8e1d65698953051086fbf90a266
Author: Noel Grandin <noel at peralex.com>
Date: Wed Aug 12 15:10:21 2015 +0200
loplugin: defaultparams
Change-Id: Iabcea466cb23e7a7a432f953cc03aaa1c2dc1d65
diff --git a/lotuswordpro/source/filter/lwpbulletstylemgr.cxx b/lotuswordpro/source/filter/lwpbulletstylemgr.cxx
index 0854ad1..2c7a86e 100644
--- a/lotuswordpro/source/filter/lwpbulletstylemgr.cxx
+++ b/lotuswordpro/source/filter/lwpbulletstylemgr.cxx
@@ -297,7 +297,7 @@ XFContentContainer* LwpBulletStyleMgr::AddBulletList(
if ((nC == nLevel-1) && bIsBulletSkiped)
{
- theItem->SetIsHeader(true);
+ theItem->SetIsHeader();
theList->SetContinueNumber(true);
}
diff --git a/lotuswordpro/source/filter/lwpdrawobj.cxx b/lotuswordpro/source/filter/lwpdrawobj.cxx
index 9a605b6..2fb00d2 100644
--- a/lotuswordpro/source/filter/lwpdrawobj.cxx
+++ b/lotuswordpro/source/filter/lwpdrawobj.cxx
@@ -716,7 +716,7 @@ XFFrame* LwpDrawRectangle::CreateDrawObj(const OUString& rStyleName)
}
pRect->LineTo(XFPoint((double)m_aVector[0].x/TWIPS_PER_CM * m_pTransData->fScaleX,
(double)m_aVector[0].y/TWIPS_PER_CM * m_pTransData->fScaleY));
- pRect->ClosePath(true);
+ pRect->ClosePath();
this->SetPosition(pRect);
pRect->SetStyleName(rStyleName);
@@ -760,7 +760,7 @@ XFFrame* LwpDrawRectangle::CreateRoundedRect(const OUString& rStyleName)
pRoundedRect->LineTo(XFPoint((double)m_aVector[0].x/TWIPS_PER_CM * m_pTransData->fScaleX,
(double)m_aVector[0].y/TWIPS_PER_CM * m_pTransData->fScaleY));
- pRoundedRect->ClosePath(true);
+ pRoundedRect->ClosePath();
this->SetPosition(pRoundedRect);
pRoundedRect->SetStyleName(rStyleName);
@@ -877,7 +877,7 @@ XFFrame* LwpDrawEllipse::CreateDrawObj(const OUString& rStyleName )
pEllipse->CurveTo(aDest, aCtrl1, aCtrl2);
}
- pEllipse->ClosePath(true);
+ pEllipse->ClosePath();
this->SetPosition(pEllipse);
pEllipse->SetStyleName(rStyleName);
diff --git a/lotuswordpro/source/filter/lwpframelayout.cxx b/lotuswordpro/source/filter/lwpframelayout.cxx
index 4eec2c7..bf72f62 100644
--- a/lotuswordpro/source/filter/lwpframelayout.cxx
+++ b/lotuswordpro/source/filter/lwpframelayout.cxx
@@ -222,7 +222,7 @@ void LwpFrame::RegisterStyle(XFFrameStyle* pFrameStyle)
nFirst++;
if(nFirst <= nLast)
{
- m_pLayout->XFConvertFrame(pCont, nFirst, nLast, false);
+ m_pLayout->XFConvertFrame(pCont, nFirst, nLast);
}
}
}
diff --git a/lotuswordpro/source/filter/lwpfribmark.cxx b/lotuswordpro/source/filter/lwpfribmark.cxx
index a5d5d13..cbdb20d 100644
--- a/lotuswordpro/source/filter/lwpfribmark.cxx
+++ b/lotuswordpro/source/filter/lwpfribmark.cxx
@@ -378,7 +378,7 @@ void LwpFribField::RegisterTimeField(LwpFieldMark* pFieldMark)
sal_Int32 index;
sal_Unicode ch1(0x0020);//space
OUString tag;
- index = sFormula.indexOf(ch1,0);
+ index = sFormula.indexOf(ch1);
if (index < 0)
return;
diff --git a/lotuswordpro/source/filter/lwplnopts.cxx b/lotuswordpro/source/filter/lwplnopts.cxx
index b8f5a75..d177951 100644
--- a/lotuswordpro/source/filter/lwplnopts.cxx
+++ b/lotuswordpro/source/filter/lwplnopts.cxx
@@ -84,11 +84,11 @@ void LwpLineNumberOptions::RegisterStyle()
pLineNumber->SetNumberOffset(LwpTools::ConvertFromUnitsToMetric(m_nDistance));
pLineNumber->SetNumberIncrement(m_nSeparator);
if (m_nFlags & LN_RESETEACHPAGE)
- pLineNumber->SetRestartOnPage(true);
+ pLineNumber->SetRestartOnPage();
else
pLineNumber->SetRestartOnPage(false);
if (m_nFlags & LN_COUNTBLANKLINES)
- pLineNumber->SetCountEmptyLines(true);
+ pLineNumber->SetCountEmptyLines();
else
pLineNumber->SetCountEmptyLines(false);
diff --git a/lotuswordpro/source/filter/lwpmarker.cxx b/lotuswordpro/source/filter/lwpmarker.cxx
index cfc82dc..e04d5ec 100644
--- a/lotuswordpro/source/filter/lwpmarker.cxx
+++ b/lotuswordpro/source/filter/lwpmarker.cxx
@@ -380,7 +380,7 @@ void LwpFieldMark::ParseIndex(OUString& sKey1,OUString& sKey2)
OUString sFormula = m_Formula.str();
sal_Int32 index[4];
sal_Unicode ch(0x0022);//"
- index[0] = sFormula.indexOf(ch,0);
+ index[0] = sFormula.indexOf(ch);
index[1] = sFormula.indexOf(ch,index[0]+1);
index[2] = sFormula.indexOf(ch,index[1]+1);
@@ -402,7 +402,7 @@ void LwpFieldMark::ParseTOC(OUString& sLevel,OUString& sText)
sal_Unicode ch1(0x0020);//space
sal_Unicode ch2(0x0022);//"
- index[0] = sFormula.indexOf(ch1,0);
+ index[0] = sFormula.indexOf(ch1);
index[1] = sFormula.indexOf(ch1,index[0]+1);
index[2] = sFormula.indexOf(ch2,index[1]+1);
@@ -431,7 +431,7 @@ bool LwpFieldMark::IsDateTimeField(sal_uInt8& type,OUString& formula)
sal_Unicode ch1(0x0020);//space
OUString tag;
- index = sFormula.indexOf(ch1,0);
+ index = sFormula.indexOf(ch1);
if (index < 0)
{
if (sFormula == "TotalEditingTime")
@@ -478,7 +478,7 @@ bool LwpFieldMark::IsCrossRefField(sal_uInt8& nType, OUString& sMarkName)
sal_Unicode ch1(0x0020);//space
OUString tag;
- index = sFormula.indexOf(ch1,0);
+ index = sFormula.indexOf(ch1);
if (index < 0)
{
LwpGlobalMgr* pGlobal = LwpGlobalMgr::GetInstance();
diff --git a/lotuswordpro/source/filter/lwptools.cxx b/lotuswordpro/source/filter/lwptools.cxx
index acb6b31..4838521 100644
--- a/lotuswordpro/source/filter/lwptools.cxx
+++ b/lotuswordpro/source/filter/lwptools.cxx
@@ -325,9 +325,9 @@ XFDateStyle* LwpTools::GetSystemDateStyle(bool bLongFormat)
}
}
if (j==1)
- pDateStyle->AddMonth(false,false);
+ pDateStyle->AddMonth(false);
else if (j==2)
- pDateStyle->AddMonth(true,false);
+ pDateStyle->AddMonth(true);
else if (j==3)
pDateStyle->AddMonth(false,true);
else
diff --git a/oox/source/drawingml/customshapegeometry.cxx b/oox/source/drawingml/customshapegeometry.cxx
index b8857c0..256fcec 100644
--- a/oox/source/drawingml/customshapegeometry.cxx
+++ b/oox/source/drawingml/customshapegeometry.cxx
@@ -647,8 +647,8 @@ public:
AdjPoint2DContext::AdjPoint2DContext( ContextHandler2Helper& rParent, const AttributeList& rAttribs, CustomShapeProperties& rCustomShapeProperties, EnhancedCustomShapeParameterPair& rAdjPoint2D )
: ContextHandler2( rParent )
{
- rAdjPoint2D.First = GetAdjCoordinate( rCustomShapeProperties, rAttribs.getString( XML_x ).get(), true );
- rAdjPoint2D.Second = GetAdjCoordinate( rCustomShapeProperties, rAttribs.getString( XML_y ).get(), true );
+ rAdjPoint2D.First = GetAdjCoordinate( rCustomShapeProperties, rAttribs.getString( XML_x ).get() );
+ rAdjPoint2D.Second = GetAdjCoordinate( rCustomShapeProperties, rAttribs.getString( XML_y ).get() );
}
// CT_XYAdjustHandle
@@ -675,11 +675,11 @@ XYAdjustHandleContext::XYAdjustHandleContext( ContextHandler2Helper& rParent, co
}
if ( rAttribs.hasAttribute( XML_minX ) )
{
- mrAdjustHandle.min1 = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_minX, aEmptyDefault ), true );
+ mrAdjustHandle.min1 = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_minX, aEmptyDefault ) );
}
if ( rAttribs.hasAttribute( XML_maxX ) )
{
- mrAdjustHandle.max1 = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_maxX, aEmptyDefault ), true );
+ mrAdjustHandle.max1 = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_maxX, aEmptyDefault ) );
}
if ( rAttribs.hasAttribute( XML_gdRefY ) )
{
@@ -687,11 +687,11 @@ XYAdjustHandleContext::XYAdjustHandleContext( ContextHandler2Helper& rParent, co
}
if ( rAttribs.hasAttribute( XML_minY ) )
{
- mrAdjustHandle.min2 = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_minY, aEmptyDefault ), true );
+ mrAdjustHandle.min2 = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_minY, aEmptyDefault ) );
}
if ( rAttribs.hasAttribute( XML_maxY ) )
{
- mrAdjustHandle.max2 = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_maxY, aEmptyDefault ), true );
+ mrAdjustHandle.max2 = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_maxY, aEmptyDefault ) );
}
}
@@ -726,11 +726,11 @@ PolarAdjustHandleContext::PolarAdjustHandleContext( ContextHandler2Helper& rPare
}
if ( rAttribs.hasAttribute( XML_minR ) )
{
- mrAdjustHandle.min1 = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_minR, aEmptyDefault ), true );
+ mrAdjustHandle.min1 = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_minR, aEmptyDefault ) );
}
if ( rAttribs.hasAttribute( XML_maxR ) )
{
- mrAdjustHandle.max1 = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_maxR, aEmptyDefault ), true );
+ mrAdjustHandle.max1 = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_maxR, aEmptyDefault ) );
}
if ( rAttribs.hasAttribute( XML_gdRefAng ) )
{
@@ -1063,8 +1063,8 @@ ContextHandlerRef Path2DContext::onCreateContext( sal_Int32 aElementToken,
EnhancedCustomShapeParameterPair aScale;
EnhancedCustomShapeParameterPair aAngles;
- aScale.First = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_wR ).get(), true );
- aScale.Second = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_hR ).get(), true );
+ aScale.First = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_wR ).get() );
+ aScale.Second = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_hR ).get() );
CustomShapeGuide aGuide;
sal_Int32 nArcNum = mrCustomShapeProperties.getArcNum();
@@ -1194,10 +1194,10 @@ ContextHandlerRef CustomShapeGeometryContext::onCreateContext( sal_Int32 aElemen
case A_TOKEN( rect ): // CT_GeomRectList geometry rect list
{
GeomRect aGeomRect;
- aGeomRect.l = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_l ).get(), true );
- aGeomRect.t = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_t ).get(), true );
- aGeomRect.r = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_r ).get(), true );
- aGeomRect.b = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_b ).get(), true );
+ aGeomRect.l = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_l ).get() );
+ aGeomRect.t = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_t ).get() );
+ aGeomRect.r = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_r ).get() );
+ aGeomRect.b = GetAdjCoordinate( mrCustomShapeProperties, rAttribs.getString( XML_b ).get() );
mrCustomShapeProperties.getTextRect() = aGeomRect;
}
break;
diff --git a/oox/source/drawingml/diagram/diagramdefinitioncontext.cxx b/oox/source/drawingml/diagram/diagramdefinitioncontext.cxx
index 88b69f2..f3868f1 100644
--- a/oox/source/drawingml/diagram/diagramdefinitioncontext.cxx
+++ b/oox/source/drawingml/diagram/diagramdefinitioncontext.cxx
@@ -50,7 +50,7 @@ DiagramDefinitionContext::~DiagramDefinitionContext()
{
LayoutNodePtr node = mpLayout->getNode();
if (node)
- node->dump(0);
+ node->dump();
}
ContextHandlerRef
diff --git a/oox/source/drawingml/effectproperties.cxx b/oox/source/drawingml/effectproperties.cxx
index 88638b88..3fd3882 100644
--- a/oox/source/drawingml/effectproperties.cxx
+++ b/oox/source/drawingml/effectproperties.cxx
@@ -56,7 +56,7 @@ void EffectProperties::pushToPropMap( PropertyMap& rPropMap,
rPropMap.setProperty( PROP_Shadow, true );
rPropMap.setProperty( PROP_ShadowXDistance, nXDist);
rPropMap.setProperty( PROP_ShadowYDistance, nYDist);
- rPropMap.setProperty( PROP_ShadowColor, it->moColor.getColor(rGraphicHelper, -1 ) );
+ rPropMap.setProperty( PROP_ShadowColor, it->moColor.getColor(rGraphicHelper ) );
rPropMap.setProperty( PROP_ShadowTransparence, it->moColor.getTransparency());
}
}
diff --git a/oox/source/drawingml/hyperlinkcontext.cxx b/oox/source/drawingml/hyperlinkcontext.cxx
index 8dfb90c..dc4f79c 100644
--- a/oox/source/drawingml/hyperlinkcontext.cxx
+++ b/oox/source/drawingml/hyperlinkcontext.cxx
@@ -80,10 +80,10 @@ HyperLinkContext::HyperLinkContext( ContextHandler2Helper& rParent,
// ppaction://program
const OUString sPPAction( "ppaction://" );
- if ( aAction.matchIgnoreAsciiCase( sPPAction, 0 ) )
+ if ( aAction.matchIgnoreAsciiCase( sPPAction ) )
{
OUString aPPAct( aAction.copy( sPPAction.getLength() ) );
- sal_Int32 nIndex = aPPAct.indexOf( '?', 0 );
+ sal_Int32 nIndex = aPPAct.indexOf( '?' );
OUString aPPAction( nIndex > 0 ? aPPAct.copy( 0, nIndex ) : aPPAct );
const OUString sHlinkshowjump( "hlinkshowjump" );
diff --git a/oox/source/dump/dumperbase.cxx b/oox/source/dump/dumperbase.cxx
index 7c21551..046f7dc 100644
--- a/oox/source/dump/dumperbase.cxx
+++ b/oox/source/dump/dumperbase.cxx
@@ -1092,7 +1092,7 @@ OUString FlagsList::implGetName( const Config& /*rCfg*/, sal_Int64 nKey ) const
{
OUStringBuffer aUnknown( OOX_DUMP_UNKNOWN );
aUnknown.append( OOX_DUMP_ITEMSEP );
- StringHelper::appendShortHex( aUnknown, nKey, true );
+ StringHelper::appendShortHex( aUnknown, nKey );
StringHelper::enclose( aUnknown, '(', ')' );
StringHelper::appendToken( aName, aUnknown.makeStringAndClear() );
}
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index b5ef21f..01d5cd0 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -3271,7 +3271,7 @@ OString DrawingML::WriteWdpPicture( const OUString& rFileId, const Sequence< sal
sId = mpFB->addRelation( mpFS->getOutputStream(),
"http://schemas.microsoft.com/office/2007/relationships/hdphoto",
- sFileName, false );
+ sFileName );
maWdpCache[rFileId] = sId;
return OUStringToOString( sId, RTL_TEXTENCODING_UTF8 );
diff --git a/oox/source/export/shapes.cxx b/oox/source/export/shapes.cxx
index 158de6b..f9072e4 100644
--- a/oox/source/export/shapes.cxx
+++ b/oox/source/export/shapes.cxx
@@ -487,9 +487,9 @@ ShapeExport& ShapeExport::WriteCustomShape( Reference< XShape > xShape )
pFS->startElementNS( mnXmlNamespace, XML_spPr, FSEND );
// moon is flipped in MSO, and mso-spt89 (right up arrow) is mapped to leftUpArrow
if ( sShapeType == "moon" || sShapeType == "mso-spt89" )
- WriteShapeTransformation( xShape, XML_a, !bFlipH, bFlipV, false);
+ WriteShapeTransformation( xShape, XML_a, !bFlipH, bFlipV );
else
- WriteShapeTransformation( xShape, XML_a, bFlipH, bFlipV, false);
+ WriteShapeTransformation( xShape, XML_a, bFlipH, bFlipV );
// we export non-primitive shapes to custom geometry
// we also export non-ooxml shapes which have handles/equations to custom geometry, because
@@ -576,7 +576,7 @@ ShapeExport& ShapeExport::WriteEllipseShape( Reference< XShape > xShape )
// visual shape properties
pFS->startElementNS( mnXmlNamespace, XML_spPr, FSEND );
- WriteShapeTransformation( xShape, XML_a, false, false, false);
+ WriteShapeTransformation( xShape, XML_a, false, false);
WritePresetShape( "ellipse" );
Reference< XPropertySet > xProps( xShape, UNO_QUERY );
if( xProps.is() )
@@ -684,7 +684,7 @@ void ShapeExport::WriteGraphicObjectShapePart( Reference< XShape > xShape, const
// visual shape properties
pFS->startElementNS( mnXmlNamespace, XML_spPr, FSEND );
- WriteShapeTransformation( xShape, XML_a, false, false, false);
+ WriteShapeTransformation( xShape, XML_a, false, false);
WritePresetShape( "rect" );
// graphic object can come with the frame (bnc#654525)
WriteOutline( xShapeProps );
@@ -897,7 +897,7 @@ ShapeExport& ShapeExport::WriteRectangleShape( Reference< XShape > xShape )
// visual shape properties
pFS->startElementNS( mnXmlNamespace, XML_spPr, FSEND );
- WriteShapeTransformation( xShape, XML_a, false, false, false);
+ WriteShapeTransformation( xShape, XML_a, false, false);
WritePresetShape( "rect" );
Reference< XPropertySet > xProps( xShape, UNO_QUERY );
if( xProps.is() )
@@ -1338,7 +1338,7 @@ ShapeExport& ShapeExport::WriteTextShape( Reference< XShape > xShape )
// visual shape properties
pFS->startElementNS( mnXmlNamespace, XML_spPr, FSEND );
- WriteShapeTransformation( xShape, XML_a, false, false, false);
+ WriteShapeTransformation( xShape, XML_a, false, false);
WritePresetShape( "rect" );
uno::Reference<beans::XPropertySet> xPropertySet(xShape, UNO_QUERY);
WriteBlipOrNormalFill(xPropertySet, "GraphicURL");
diff --git a/oox/source/helper/textinputstream.cxx b/oox/source/helper/textinputstream.cxx
index d5e7894..b292e56 100644
--- a/oox/source/helper/textinputstream.cxx
+++ b/oox/source/helper/textinputstream.cxx
@@ -70,21 +70,21 @@ sal_Int32 SAL_CALL UnoBinaryInputStream::readBytes( Sequence< sal_Int8 >& rData,
throw (NotConnectedException, BufferSizeExceededException, IOException, RuntimeException, std::exception)
{
ensureConnected();
- return mpInStrm->readData( rData, nBytesToRead, 1 );
+ return mpInStrm->readData( rData, nBytesToRead );
}
sal_Int32 SAL_CALL UnoBinaryInputStream::readSomeBytes( Sequence< sal_Int8 >& rData, sal_Int32 nMaxBytesToRead )
throw (NotConnectedException, BufferSizeExceededException, IOException, RuntimeException, std::exception)
{
ensureConnected();
- return mpInStrm->readData( rData, nMaxBytesToRead, 1 );
+ return mpInStrm->readData( rData, nMaxBytesToRead );
}
void SAL_CALL UnoBinaryInputStream::skipBytes( sal_Int32 nBytesToSkip )
throw (NotConnectedException, BufferSizeExceededException, IOException, RuntimeException, std::exception)
{
ensureConnected();
- mpInStrm->skip( nBytesToSkip, 1 );
+ mpInStrm->skip( nBytesToSkip );
}
sal_Int32 SAL_CALL UnoBinaryInputStream::available() throw (NotConnectedException, IOException, RuntimeException, std::exception)
diff --git a/oox/source/helper/zipstorage.cxx b/oox/source/helper/zipstorage.cxx
index d535ac6..dc98654 100644
--- a/oox/source/helper/zipstorage.cxx
+++ b/oox/source/helper/zipstorage.cxx
@@ -58,8 +58,7 @@ ZipStorage::ZipStorage( const Reference< XComponentContext >& rxContext, const R
implementation of relations handling.
*/
mxStorage = ::comphelper::OStorageHelper::GetStorageOfFormatFromInputStream(
- ZIP_STORAGE_FORMAT_STRING, rxInStream, rxContext,
- false ); // DEV300_m80: Was sal_True, but DOCX and others did not load
+ ZIP_STORAGE_FORMAT_STRING, rxInStream, rxContext );
}
catch (Exception const& e)
{
diff --git a/oox/source/vml/vmlformatting.cxx b/oox/source/vml/vmlformatting.cxx
index 6dcbf3e..1d1dedb 100644
--- a/oox/source/vml/vmlformatting.cxx
+++ b/oox/source/vml/vmlformatting.cxx
@@ -219,7 +219,7 @@ Color ConversionHelper::decodeColor( const GraphicHelper& rGraphicHelper,
sal_Int32 nColorToken = AttributeConversion::decodeToken( aColorName );
sal_Int32 nRgbValue = Color::getVmlPresetColor( nColorToken, API_RGB_TRANSPARENT );
if( nRgbValue == API_RGB_TRANSPARENT )
- nRgbValue = rGraphicHelper.getSystemColor( nColorToken, API_RGB_TRANSPARENT );
+ nRgbValue = rGraphicHelper.getSystemColor( nColorToken );
if( nRgbValue != API_RGB_TRANSPARENT )
{
aDmlColor.setSrgbClr( nRgbValue );
commit 9e1d98fec2884e4c401aa0d5396612aa01773dc8
Author: Noel Grandin <noel at peralex.com>
Date: Wed Aug 12 15:10:16 2015 +0200
loplugin: defaultparams
Change-Id: I320eb6149793689c496b14090e8e0243397d01ba
diff --git a/i18npool/source/breakiterator/breakiteratorImpl.cxx b/i18npool/source/breakiterator/breakiteratorImpl.cxx
index e07c2ba..afae133 100644
--- a/i18npool/source/breakiterator/breakiteratorImpl.cxx
+++ b/i18npool/source/breakiterator/breakiteratorImpl.cxx
@@ -73,13 +73,13 @@ static sal_Int32 skipSpace(const OUString& Text, sal_Int32 nPos, sal_Int32 len,
switch (rWordType) {
case WordType::ANYWORD_IGNOREWHITESPACES:
if (bDirection)
- while (nPos < len && (u_isWhitespace(ch = Text.iterateCodePoints(&pos, 1)) || isZWSP(ch))) nPos=pos;
+ while (nPos < len && (u_isWhitespace(ch = Text.iterateCodePoints(&pos)) || isZWSP(ch))) nPos=pos;
else
while (nPos > 0 && (u_isWhitespace(ch = Text.iterateCodePoints(&pos, -1)) || isZWSP(ch))) nPos=pos;
break;
case WordType::DICTIONARY_WORD:
if (bDirection)
- while (nPos < len && (u_isWhitespace(ch = Text.iterateCodePoints(&pos, 1)) || isZWSP(ch) ||
+ while (nPos < len && (u_isWhitespace(ch = Text.iterateCodePoints(&pos)) || isZWSP(ch) ||
! (ch == 0x002E || u_isalnum(ch)))) nPos=pos;
else
while (nPos > 0 && (u_isWhitespace(ch = Text.iterateCodePoints(&pos, -1)) || isZWSP(ch) ||
@@ -87,7 +87,7 @@ static sal_Int32 skipSpace(const OUString& Text, sal_Int32 nPos, sal_Int32 len,
break;
case WordType::WORD_COUNT:
if (bDirection)
- while (nPos < len && (u_isUWhiteSpace(ch = Text.iterateCodePoints(&pos, 1)) || isZWSP(ch))) nPos=pos;
+ while (nPos < len && (u_isUWhiteSpace(ch = Text.iterateCodePoints(&pos)) || isZWSP(ch))) nPos=pos;
else
while (nPos > 0 && (u_isUWhiteSpace(ch = Text.iterateCodePoints(&pos, -1)) || isZWSP(ch))) nPos=pos;
break;
diff --git a/i18npool/source/breakiterator/breakiterator_cjk.cxx b/i18npool/source/breakiterator/breakiterator_cjk.cxx
index 487f06f..8983053 100644
--- a/i18npool/source/breakiterator/breakiterator_cjk.cxx
+++ b/i18npool/source/breakiterator/breakiterator_cjk.cxx
@@ -96,7 +96,7 @@ LineBreakResults SAL_CALL BreakIterator_CJK::getLineBreak(
if (bOptions.allowPunctuationOutsideMargin &&
hangingCharacters.indexOf(Text[nStartPos]) != -1 &&
- (Text.iterateCodePoints( &nStartPos, 1), nStartPos == Text.getLength())) {
+ (Text.iterateCodePoints( &nStartPos ), nStartPos == Text.getLength())) {
; // do nothing
} else if (bOptions.applyForbiddenRules && 0 < nStartPos && nStartPos < Text.getLength()) {
while (nStartPos > 0 &&
diff --git a/i18npool/source/breakiterator/breakiterator_unicode.cxx b/i18npool/source/breakiterator/breakiterator_unicode.cxx
index 126114c..262f06a 100644
--- a/i18npool/source/breakiterator/breakiterator_unicode.cxx
+++ b/i18npool/source/breakiterator/breakiterator_unicode.cxx
@@ -217,7 +217,7 @@ sal_Int32 SAL_CALL BreakIterator_Unicode::nextCharacters( const OUString& Text,
}
} else { // for CHARACTER mode
for (nDone = 0; nDone < nCount && nStartPos < Text.getLength(); nDone++)
- Text.iterateCodePoints(&nStartPos, 1);
+ Text.iterateCodePoints(&nStartPos);
}
return nStartPos;
}
@@ -331,8 +331,8 @@ sal_Int32 SAL_CALL BreakIterator_Unicode::beginOfSentence( const OUString& Text,
nStartPos = sentence.aBreakIterator->preceding(nStartPos);
// skip preceding space.
- sal_uInt32 ch = Text.iterateCodePoints(&nStartPos, 1);
- while (nStartPos < len && u_isWhitespace(ch)) ch = Text.iterateCodePoints(&nStartPos, 1);
+ sal_uInt32 ch = Text.iterateCodePoints(&nStartPos);
+ while (nStartPos < len && u_isWhitespace(ch)) ch = Text.iterateCodePoints(&nStartPos);
Text.iterateCodePoints(&nStartPos, -1);
return nStartPos;
diff --git a/i18npool/source/breakiterator/xdictionary.cxx b/i18npool/source/breakiterator/xdictionary.cxx
index 142ec98..322239c 100644
--- a/i18npool/source/breakiterator/xdictionary.cxx
+++ b/i18npool/source/breakiterator/xdictionary.cxx
@@ -283,7 +283,7 @@ bool xdictionary::seekSegment(const OUString &rText, sal_Int32 pos,
segBoundary.startPos = segmentCachedBoundary.startPos;
segBoundary.endPos = segmentCachedBoundary.endPos;
indexUtf16 = segmentCachedBoundary.startPos;
- rText.iterateCodePoints(&indexUtf16, 1);
+ rText.iterateCodePoints(&indexUtf16);
return segmentCachedBoundary.endPos > indexUtf16;
}
}
@@ -303,7 +303,7 @@ bool xdictionary::seekSegment(const OUString &rText, sal_Int32 pos,
indexUtf16 = pos;
while (indexUtf16 < rText.getLength())
{
- sal_uInt32 ch = rText.iterateCodePoints(&indexUtf16, 1);
+ sal_uInt32 ch = rText.iterateCodePoints(&indexUtf16);
if (u_isWhitespace(ch) || exists(ch))
segBoundary.endPos = indexUtf16;
else
@@ -315,7 +315,7 @@ bool xdictionary::seekSegment(const OUString &rText, sal_Int32 pos,
segmentCachedBoundary.endPos = segBoundary.endPos;
indexUtf16 = segBoundary.startPos;
- rText.iterateCodePoints(&indexUtf16, 1);
+ rText.iterateCodePoints(&indexUtf16);
return segBoundary.endPos > indexUtf16;
}
@@ -419,8 +419,8 @@ Boundary xdictionary::nextWord(const OUString& rText, sal_Int32 anyPos, sal_Int1
const sal_Int32 nLen = rText.getLength();
if (anyPos < nLen) {
// looknig for the first non-whitespace character from anyPos
- sal_uInt32 ch = rText.iterateCodePoints(&anyPos, 1);
- while (u_isWhitespace(ch) && (anyPos < nLen)) ch=rText.iterateCodePoints(&anyPos, 1);
+ sal_uInt32 ch = rText.iterateCodePoints(&anyPos);
+ while (u_isWhitespace(ch) && (anyPos < nLen)) ch=rText.iterateCodePoints(&anyPos);
if (anyPos > 0)
rText.iterateCodePoints(&anyPos, -1);
}
@@ -445,7 +445,7 @@ Boundary xdictionary::getWordBoundary(const OUString& rText, sal_Int32 anyPos, s
if (!bDirection && startPos > 0 && startPos == (anyPos - boundary.startPos))
{
sal_Int32 indexUtf16 = anyPos-1;
- sal_uInt32 ch = rText.iterateCodePoints(&indexUtf16, 1);
+ sal_uInt32 ch = rText.iterateCodePoints(&indexUtf16);
if (u_isWhitespace(ch))
i--;
}
@@ -456,7 +456,7 @@ Boundary xdictionary::getWordBoundary(const OUString& rText, sal_Int32 anyPos, s
} else {
boundary.startPos = anyPos;
- if (anyPos < len) rText.iterateCodePoints(&anyPos, 1);
+ if (anyPos < len) rText.iterateCodePoints(&anyPos);
boundary.endPos = anyPos < len ? anyPos : len;
}
if (wordType == WordType::WORD_COUNT) {
@@ -464,7 +464,7 @@ Boundary xdictionary::getWordBoundary(const OUString& rText, sal_Int32 anyPos, s
while (boundary.endPos < len)
{
sal_Int32 indexUtf16 = boundary.endPos;
- if (u_ispunct(rText.iterateCodePoints(&indexUtf16, 1)))
+ if (u_ispunct(rText.iterateCodePoints(&indexUtf16)))
boundary.endPos = indexUtf16;
else
break;
diff --git a/i18npool/source/indexentry/indexentrysupplier_asian.cxx b/i18npool/source/indexentry/indexentrysupplier_asian.cxx
index a41e8cb..4216e40 100644
--- a/i18npool/source/indexentry/indexentrysupplier_asian.cxx
+++ b/i18npool/source/indexentry/indexentrysupplier_asian.cxx
@@ -182,7 +182,7 @@ IndexEntrySupplier_asian::getPhoneticCandidate( const OUString& rIndexEntry,
sal_Int16 max_index;
sal_uInt16** idx=func(&max_index);
for (sal_Int32 i=0,j=0; i < rIndexEntry.getLength(); i=j) {
- sal_uInt32 ch = rIndexEntry.iterateCodePoints(&j, 1);
+ sal_uInt32 ch = rIndexEntry.iterateCodePoints(&j);
if (((sal_Int16)(ch>>8)) <= max_index) {
sal_uInt16 address = idx[0][ch>>8];
if (address != 0xFFFF) {
diff --git a/io/source/acceptor/acc_pipe.cxx b/io/source/acceptor/acc_pipe.cxx
index 28a7cd2..1265d0e 100644
--- a/io/source/acceptor/acc_pipe.cxx
+++ b/io/source/acceptor/acc_pipe.cxx
@@ -75,8 +75,7 @@ namespace io_acceptor
m_sDescription += ",uniqueValue=";
m_sDescription += OUString::number(
sal::static_int_cast<sal_Int64 >(
- reinterpret_cast< sal_IntPtr >(&m_pipe)),
- 10 );
+ reinterpret_cast< sal_IntPtr >(&m_pipe)) );
}
PipeConnection::~PipeConnection()
diff --git a/io/source/acceptor/acc_socket.cxx b/io/source/acceptor/acc_socket.cxx
index 5e37462..aaecf3c 100644
--- a/io/source/acceptor/acc_socket.cxx
+++ b/io/source/acceptor/acc_socket.cxx
@@ -166,8 +166,7 @@ namespace io_acceptor {
m_sDescription += ",uniqueValue=" ;
m_sDescription += OUString::number(
sal::static_int_cast< sal_Int64 >(
- reinterpret_cast< sal_IntPtr >(&m_socket)),
- 10 );
+ reinterpret_cast< sal_IntPtr >(&m_socket)) );
}
SocketConnection::~SocketConnection()
diff --git a/io/source/connector/ctr_pipe.cxx b/io/source/connector/ctr_pipe.cxx
index 0829b0f..f9b19ea 100644
--- a/io/source/connector/ctr_pipe.cxx
+++ b/io/source/connector/ctr_pipe.cxx
@@ -36,8 +36,7 @@ namespace stoc_connector {
m_sDescription += ",uniqueValue=";
m_sDescription += OUString::number(
sal::static_int_cast< sal_Int64 >(
- reinterpret_cast< sal_IntPtr >(&m_pipe)),
- 10 );
+ reinterpret_cast< sal_IntPtr >(&m_pipe)) );
}
PipeConnection::~PipeConnection()
diff --git a/io/source/connector/ctr_socket.cxx b/io/source/connector/ctr_socket.cxx
index 76dcb31..c23c896 100644
--- a/io/source/connector/ctr_socket.cxx
+++ b/io/source/connector/ctr_socket.cxx
@@ -87,8 +87,7 @@ namespace stoc_connector {
m_sDescription += ",uniqueValue=";
m_sDescription += OUString::number(
sal::static_int_cast< sal_Int64 >(
- reinterpret_cast< sal_IntPtr >(&m_socket)),
- 10 );
+ reinterpret_cast< sal_IntPtr >(&m_socket)) );
}
SocketConnection::~SocketConnection()
commit 371a535afbccd1cc405117ad5529fc980e041e68
Author: Noel Grandin <noel at peralex.com>
Date: Wed Aug 12 15:10:10 2015 +0200
loplugin: defaultparams
Change-Id: I0538bbb2e121d8feeff03535cb327c957e03de1b
diff --git a/fpicker/source/office/OfficeControlAccess.cxx b/fpicker/source/office/OfficeControlAccess.cxx
index f2116e7..63cde88 100644
--- a/fpicker/source/office/OfficeControlAccess.cxx
+++ b/fpicker/source/office/OfficeControlAccess.cxx
@@ -399,7 +399,7 @@ namespace svt
{
Any aRet;
- Control* pControl = m_pFilePickerController->getControl( _nControlId, false );
+ Control* pControl = m_pFilePickerController->getControl( _nControlId );
DBG_ASSERT( pControl, "OControlAccess::GetValue: don't have this control in the current mode!" );
if ( pControl )
{
diff --git a/fpicker/source/office/OfficeFilePicker.cxx b/fpicker/source/office/OfficeFilePicker.cxx
index 3e2d345..f52cdfe 100644
--- a/fpicker/source/office/OfficeFilePicker.cxx
+++ b/fpicker/source/office/OfficeFilePicker.cxx
@@ -449,7 +449,7 @@ sal_Int16 SvtFilePicker::implExecutePicker( )
prepareExecute();
- getDialog()->EnableAutocompletion( true );
+ getDialog()->EnableAutocompletion();
// now we are ready to execute the dialog
sal_Int16 nRet = getDialog()->Execute();
@@ -530,7 +530,7 @@ void SAL_CALL SvtFilePicker::startExecuteModal( const Reference< ::com::sun::sta
m_xDlgClosedListener = xListener;
prepareDialog();
prepareExecute();
- getDialog()->EnableAutocompletion( true );
+ getDialog()->EnableAutocompletion();
getDialog()->StartExecuteModal( LINK( this, SvtFilePicker, DialogClosedHdl ) );
}
diff --git a/fpicker/source/office/OfficeFolderPicker.cxx b/fpicker/source/office/OfficeFolderPicker.cxx
index 33a3e53..6fbb642 100644
--- a/fpicker/source/office/OfficeFolderPicker.cxx
+++ b/fpicker/source/office/OfficeFolderPicker.cxx
@@ -65,7 +65,7 @@ void SAL_CALL SvtFolderPicker::startExecuteModal( const Reference< ::com::sun::s
m_xListener = xListener;
prepareDialog();
prepareExecute();
- getDialog()->EnableAutocompletion( true );
+ getDialog()->EnableAutocompletion();
getDialog()->StartExecuteModal( LINK( this, SvtFolderPicker, DialogClosedHdl ) );
}
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx b/fpicker/source/office/RemoteFilesDialog.cxx
index 98ef36f..cce10e6 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -1102,7 +1102,7 @@ IMPL_LINK_NOARG ( RemoteFilesDialog, CancelHdl )
}
else
{
- EndDialog( RET_CANCEL );
+ EndDialog();
}
return 1;
}
diff --git a/fpicker/source/office/commonpicker.cxx b/fpicker/source/office/commonpicker.cxx
index 8048506..451231e 100644
--- a/fpicker/source/office/commonpicker.cxx
+++ b/fpicker/source/office/commonpicker.cxx
@@ -120,7 +120,7 @@ namespace svt
{
::osl::MutexGuard aOwnGuard( m_aMutex );
if ( m_bExecuting && m_pDlg )
- m_pDlg->EndDialog( RET_CANCEL );
+ m_pDlg->EndDialog();
}
m_pDlg.disposeAndClear();
@@ -404,7 +404,7 @@ namespace svt
OSL_ENSURE( getDialog(), "OCommonPicker::OnCancelPicker: executing, but no dialog!" );
if ( getDialog() )
- getDialog()->EndDialog( RET_CANCEL );
+ getDialog()->EndDialog();
return 0L;
}
diff --git a/fpicker/source/office/iodlg.cxx b/fpicker/source/office/iodlg.cxx
index 6d1e1a1..123f96f 100644
--- a/fpicker/source/office/iodlg.cxx
+++ b/fpicker/source/office/iodlg.cxx
@@ -823,7 +823,7 @@ IMPL_LINK_NOARG(SvtFileDialog, CancelHdl_Impl)
}
else
{
- EndDialog( RET_CANCEL );
+ EndDialog();
}
return 1L;
}
@@ -2502,7 +2502,7 @@ Control* SvtFileDialog::getControl( sal_Int16 _nControlId, bool _bLabelControl )
void SvtFileDialog::enableControl( sal_Int16 _nControlId, bool _bEnable )
{
- Control* pControl = getControl( _nControlId, false );
+ Control* pControl = getControl( _nControlId );
if ( pControl )
EnableControl( pControl, _bEnable );
Control* pLabel = getControl( _nControlId, true );
@@ -2550,7 +2550,7 @@ void SvtFileDialog::AddControls_Impl( )
if ( _nExtraBits & SFX_EXTRA_AUTOEXTENSION )
{
_pImp->_pCbAutoExtension->SetText( SvtResId( STR_SVT_FILEPICKER_AUTO_EXTENSION ) );
- _pImp->_pCbAutoExtension->Check( true );
+ _pImp->_pCbAutoExtension->Check();
_pImp->_pCbAutoExtension->SetClickHdl( LINK( this, SvtFileDialog, AutoExtensionHdl_Impl ) );
_pImp->_pCbAutoExtension->Show();
}
diff --git a/framework/source/dispatch/servicehandler.cxx b/framework/source/dispatch/servicehandler.cxx
index 8ef3913..3f700bc 100644
--- a/framework/source/dispatch/servicehandler.cxx
+++ b/framework/source/dispatch/servicehandler.cxx
@@ -186,7 +186,7 @@ css::uno::Reference< css::uno::XInterface > ServiceHandler::implts_dispatch( con
OUString sServiceName;
OUString sArguments;
- sal_Int32 nArgStart = sServiceAndArguments.indexOf('?',0);
+ sal_Int32 nArgStart = sServiceAndArguments.indexOf('?');
if (nArgStart!=-1)
{
sServiceName = sServiceAndArguments.copy(0,nArgStart);
diff --git a/framework/source/uielement/headermenucontroller.cxx b/framework/source/uielement/headermenucontroller.cxx
index abbcac4..0c57b66 100644
--- a/framework/source/uielement/headermenucontroller.cxx
+++ b/framework/source/uielement/headermenucontroller.cxx
@@ -144,7 +144,7 @@ void HeaderMenuController::fillPopupMenu( const Reference< ::com::sun::star::fra
pVCLPopupMenu->SetItemCommand( nId, aCommand );
if ( bHeaderIsOn )
- pVCLPopupMenu->CheckItem( nId, true );
+ pVCLPopupMenu->CheckItem( nId );
++nId;
// Check if all entries have the same state
diff --git a/framework/source/uielement/langselectionmenucontroller.cxx b/framework/source/uielement/langselectionmenucontroller.cxx
index 17b689d..5d89a00 100644
--- a/framework/source/uielement/langselectionmenucontroller.cxx
+++ b/framework/source/uielement/langselectionmenucontroller.cxx
@@ -217,7 +217,7 @@ void LanguageSelectionMenuController::fillPopupMenu( Reference< css::awt::XPopup
if (rStr == m_aCurLang && eMode == MODE_SetLanguageSelectionMenu )
{
//make a sign for the current language
- pPopupMenu->CheckItem( nItemId, true );
+ pPopupMenu->CheckItem( nItemId );
}
++nItemId;
}
commit fceee9237c583f8d95396845a1c1606000df26fb
Author: Noel Grandin <noel at peralex.com>
Date: Fri Aug 14 11:09:40 2015 +0200
loplugin: defaultparams
Change-Id: I4080aece6fec2778a2a8646ddedd280337303591
diff --git a/filter/source/graphicfilter/eps/eps.cxx b/filter/source/graphicfilter/eps/eps.cxx
index 38460b9..bcbb526 100644
--- a/filter/source/graphicfilter/eps/eps.cxx
+++ b/filter/source/graphicfilter/eps/eps.cxx
@@ -1649,7 +1649,7 @@ void PSWriter::ImplPolyPoly( const tools::PolyPolygon & rPolyPoly, bool bTextOut
ImplWriteLineColor( PS_SPACE );
for ( i = 0; i < nPolyCount; i++ )
ImplAddPath( rPolyPoly.GetObject( i ) );
- ImplClosePathDraw( PS_RET );
+ ImplClosePathDraw();
}
}
}
@@ -1685,7 +1685,7 @@ void PSWriter::ImplPolyLine( const Polygon & rPoly )
// #104645# explicitly close path if polygon is closed
if( rPoly[ 0 ] == rPoly[ nPointCount-1 ] )
- ImplClosePathDraw( PS_RET );
+ ImplClosePathDraw();
else
ImplPathDraw();
}
@@ -2438,13 +2438,13 @@ void PSWriter::ImplWriteLineInfo( double fLWidth, double fMLimit,
if ( eLineCap != eLCap )
{
eLineCap = eLCap;
- ImplWriteLong( (sal_Int32)eLineCap, PS_SPACE );
+ ImplWriteLong( (sal_Int32)eLineCap );
ImplWriteLine( "lc", PS_SPACE );
}
if ( eJoinType != eJoin )
{
eJoinType = eJoin;
- ImplWriteLong( (sal_Int32)eJoinType, PS_SPACE );
+ ImplWriteLong( (sal_Int32)eJoinType );
ImplWriteLine( "lj", PS_SPACE );
}
if ( eJoinType == SvtGraphicStroke::joinMiter )
diff --git a/filter/source/graphicfilter/icgm/class4.cxx b/filter/source/graphicfilter/icgm/class4.cxx
index e484e52..0523ada 100644
--- a/filter/source/graphicfilter/icgm/class4.cxx
+++ b/filter/source/graphicfilter/icgm/class4.cxx
@@ -288,7 +288,7 @@ void CGM::ImplDoClass4()
{
aPolygon.SetPoint( pPoints[ i ], i );
}
- aPolyPolygon.Insert( aPolygon, POLYPOLY_APPEND );
+ aPolyPolygon.Insert( aPolygon );
nPoints = 0;
}
}
diff --git a/filter/source/graphicfilter/idxf/dxf2mtf.cxx b/filter/source/graphicfilter/idxf/dxf2mtf.cxx
index 29a67f3..613f76f 100644
--- a/filter/source/graphicfilter/idxf/dxf2mtf.cxx
+++ b/filter/source/graphicfilter/idxf/dxf2mtf.cxx
@@ -614,7 +614,7 @@ void DXF2GDIMetaFile::DrawHatchEntity(const DXFHatchEntity & rE, const DXFTransf
Polygon aPoly( nSize );
for ( i = 0; i < nSize; i++ )
aPoly[ i ] = aPtAry[ i ];
- aPolyPoly.Insert( aPoly, POLYPOLY_APPEND );
+ aPolyPoly.Insert( aPoly );
}
}
if ( aPolyPoly.Count() )
diff --git a/filter/source/msfilter/msvbahelper.cxx b/filter/source/msfilter/msvbahelper.cxx
index ebf458b..8667270 100644
--- a/filter/source/msfilter/msvbahelper.cxx
+++ b/filter/source/msfilter/msvbahelper.cxx
@@ -597,7 +597,7 @@ OUString SAL_CALL VBAMacroResolver::resolveVBAMacroToScriptURL( const OUString&
aMacroName = aMacroName.copy( nDotPos + 1 );
// try to find the macro
- MacroResolvedInfo aInfo = resolveVBAMacro( mpObjShell, aMacroName, false );
+ MacroResolvedInfo aInfo = resolveVBAMacro( mpObjShell, aMacroName );
if( !aInfo.mbFound )
throw lang::IllegalArgumentException();
diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index 8902b4c..43dbec84 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -305,7 +305,7 @@ ImpPDFTabGeneralPage* ImpPDFTabDialog::getGeneralPage() const
IMPL_LINK_NOARG(ImpPDFTabDialog, CancelHdl)
{
- EndDialog( RET_CANCEL );
+ EndDialog();
return 0;
}
@@ -1121,12 +1121,12 @@ void ImpPDFTabViewerPage::SetFilterConfigItem( const ImpPDFTabDialog* paParent
m_pCbTransitionEffects->Enable( mbIsPresentation );
if( paParent->mnOpenBookmarkLevels < 0 )
{
- m_pRbAllBookmarkLevels->Check( true );
+ m_pRbAllBookmarkLevels->Check();
m_pNumBookmarkLevels->Enable( false );
}
else
{
- m_pRbVisibleBookmarkLevels->Check( true );
+ m_pRbVisibleBookmarkLevels->Check();
m_pNumBookmarkLevels->Enable( true );
m_pNumBookmarkLevels->SetValue( paParent->mnOpenBookmarkLevels );
}
diff --git a/filter/source/xsltfilter/OleHandler.cxx b/filter/source/xsltfilter/OleHandler.cxx
index 74d4ea9..55b89b7 100644
--- a/filter/source/xsltfilter/OleHandler.cxx
+++ b/filter/source/xsltfilter/OleHandler.cxx
@@ -76,7 +76,7 @@ namespace XSLT
{
Sequence<sal_Int8> oleData;
::sax::Converter::decodeBase64(oleData, OStringToOUString(
- content, RTL_TEXTENCODING_UTF8, OSTRING_TO_OUSTRING_CVTFLAGS));
+ content, RTL_TEXTENCODING_UTF8));
m_rootStream = createTempFile();
Reference<XOutputStream> xOutput = m_rootStream->getOutputStream();
xOutput->writeBytes(oleData);
diff --git a/forms/source/component/DatabaseForm.cxx b/forms/source/component/DatabaseForm.cxx
index 88ed562..47488b2 100644
--- a/forms/source/component/DatabaseForm.cxx
+++ b/forms/source/component/DatabaseForm.cxx
@@ -1939,7 +1939,7 @@ void SAL_CALL ODatabaseForm::reset() throw( RuntimeException, std::exception )
m_pThread->create();
}
EventObject aEvt;
- m_pThread->addEvent(&aEvt, false);
+ m_pThread->addEvent(&aEvt);
}
else
{
diff --git a/forms/source/component/ListBox.cxx b/forms/source/component/ListBox.cxx
index 724b6c8..752a618 100644
--- a/forms/source/component/ListBox.cxx
+++ b/forms/source/component/ListBox.cxx
@@ -1391,7 +1391,7 @@ namespace frm
{
// the indexes where the current string appears in our string items
Sequence< sal_Int16 > aThisEntryIndexes;
- aThisEntryIndexes = findValue( getStringItemList(), *pSelectEntries++, false );
+ aThisEntryIndexes = findValue( getStringItemList(), *pSelectEntries++ );
// insert all the indexes of this entry into our set
::std::copy(
@@ -1416,7 +1416,7 @@ namespace frm
OUString sStringToSelect;
OSL_VERIFY( _rExternalValue >>= sStringToSelect );
- aSelectIndexes = findValue( getStringItemList(), sStringToSelect, false );
+ aSelectIndexes = findValue( getStringItemList(), sStringToSelect );
}
break;
}
diff --git a/forms/source/xforms/binding.cxx b/forms/source/xforms/binding.cxx
index 5c86447..e145448 100644
--- a/forms/source/xforms/binding.cxx
+++ b/forms/source/xforms/binding.cxx
@@ -170,7 +170,7 @@ css::uno::Reference<css::xml::dom::XNodeList> Binding::getXNodeList()
{
// first make sure we are bound
if( ! maBindingExpression.hasValue() )
- bind( false );
+ bind();
return maBindingExpression.getXNodeList();
}
@@ -309,7 +309,7 @@ EvaluationContext Binding::getEvaluationContext() const
OSL_ENSURE( getModelImpl() != NULL, "need model impl" );
// bind (in case we were not bound before)
- bind( false );
+ bind();
return _getMIPEvaluationContexts();
}
@@ -779,11 +779,11 @@ MIP Binding::getLocalMIP() const
MIP aMIP;
if( maReadonly.hasValue() )
- aMIP.setReadonly( maReadonly.getBool( false ) );
+ aMIP.setReadonly( maReadonly.getBool() );
if( maRelevant.hasValue() )
aMIP.setRelevant( maRelevant.getBool( true ) );
if( maRequired.hasValue() )
- aMIP.setRequired( maRequired.getBool( false ) );
+ aMIP.setRequired( maRequired.getBool() );
if( maConstraint.hasValue() )
{
aMIP.setConstraint( maConstraint.getBool( true ) );
@@ -1252,7 +1252,7 @@ void Binding::handleEvent( const css::uno::Reference<css::xml::dom::events::XEve
}
// if we're a dynamic binding, we better re-bind, too!
- bind( false );
+ bind();
// our value was maybe modified
valueModified();
diff --git a/forms/source/xforms/datatyperepository.cxx b/forms/source/xforms/datatyperepository.cxx
index 55c45b6..8bb0123 100644
--- a/forms/source/xforms/datatyperepository.cxx
+++ b/forms/source/xforms/datatyperepository.cxx
@@ -157,7 +157,7 @@ namespace xforms
Reference< XDataType > SAL_CALL ODataTypeRepository::getDataType( const OUString& typeName ) throw (NoSuchElementException, RuntimeException, std::exception)
{
::osl::MutexGuard aGuard( m_aMutex );
- return implLocate( typeName, false )->second.get();
+ return implLocate( typeName )->second.get();
}
diff --git a/formula/source/core/api/FormulaCompiler.cxx b/formula/source/core/api/FormulaCompiler.cxx
index f0ed8c2..085f1bc 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -1068,11 +1068,11 @@ bool FormulaCompiler::GetToken()
if ( nWasColRowName )
nWasColRowName++;
if ( bAutoCorrect && !pStack )
- CreateStringFromToken( aCorrectedFormula, mpToken.get(), false );
+ CreateStringFromToken( aCorrectedFormula, mpToken.get() );
mpToken = pArr->Next();
}
if ( bAutoCorrect && !pStack && mpToken )
- CreateStringFromToken( aCorrectedSymbol, mpToken.get(), false );
+ CreateStringFromToken( aCorrectedSymbol, mpToken.get() );
if( !mpToken )
{
if( pStack )
More information about the Libreoffice-commits
mailing list