[Libreoffice-commits] cppunit.git: 2 commits - CodingGuideLines.txt README

Markus Mohrhard markus.mohrhard at googlemail.com
Fri Aug 21 12:48:22 PDT 2015


 CodingGuideLines.txt |   28 ++--------------------------
 README               |    2 +-
 2 files changed, 3 insertions(+), 27 deletions(-)

New commits:
commit 5d83af095b987f275ec6f12fd0b7bdc5b7e30b0e
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Thu Aug 20 13:44:22 2015 +0200

    update URL for bug reports

diff --git a/README b/README
index 2e215d2..4156176 100644
--- a/README
+++ b/README
@@ -10,7 +10,7 @@ For other systems -- including cygwin -- see INSTALL and INSTALL-unix.
 
 
 Bug reports are welcome. Please open bug reports for Cppunit at
-bugs.freedesktop.org under the component Libreoffice.
+bugs.documentfoundation.org under the component cppunit.
 
 Email to the current maintainers may be sent to
 <libreoffice at lists.freedesktop.org>
commit 6d13161d2d7abd5a0ce7b15eb26045701575d328
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Thu Aug 20 13:39:41 2015 +0200

    update CodingGuidelines
    
    Nearly all compilers that are in use will support these features. ALso
    mention that c++11/c++14 features are only allowed in optional code.

diff --git a/CodingGuideLines.txt b/CodingGuideLines.txt
index 57b9013..ff3018c 100644
--- a/CodingGuideLines.txt
+++ b/CodingGuideLines.txt
@@ -11,20 +11,8 @@ CppUnit's coding guidelines for portability:
 - don't use the 'using directive', always use full qualification. For STL,
   always use std::.
 
-- don't use C++ style cast directly, instead use CppUnit's cast macro
-  (CPPUNIT_CONST_CAST).
-
 - don't use the mutable keyword, instead do a const cast.
 
-- don't use the typename keyword in template declaration, instead use 'class'.
-
-- don't make use of RTTI (typeid) or dynamic_cast mandatory.
-
-- don't use STL container directly, instead use CppUnit's wrapper located
-  in include/cppunit/portability. This help support compilers that don't 
-  support default template parameter and require an allocator to be 
-  specified.
-
 - don't use default template parameters. If needed, use STLPort wrapper
   technic (see include/cppunit/portability/).
 
@@ -35,31 +23,19 @@ CppUnit's coding guidelines for portability:
 - don't use default parameter value in template function. Not supported
   by all compiler (on OS/390 for instance).
 
-- don't use STL container at() method, instead use the array accessor [].
-  at() is not supported on some gcc versions.
-
 - dereferencing containers must be done by (*ref_ptr).data instead of
   ref_ptr->data.
 
+- don't use C++11/C++14 features in non-optional code
+
 In brief, it should be possible to compile CppUnit on a C++ compiler that do
 not have the following features:
-- C++ style cast
-- mutable and typename keyword
-- RTTI
 - template default parameters
 - templatized member functions (that is a template function declared within a
   class).
-- namespace
 
 As such, usage of those features should always be optional.
 
-Following those guidelines should allow to compile on most compilers, as long
-as STL are available (in std namespace or not), with some form of strstream and
-iostream, as well as exception support.
-
---
-Baptiste Lepilleur <gaiacrtn at free.fr>
-
 CppUnit's version control system management
 --------------------------------------------
 


More information about the Libreoffice-commits mailing list