[Libreoffice-commits] core.git: avmedia/source
Michael Meeks
michael.meeks at collabora.com
Sat Aug 22 11:02:35 PDT 2015
avmedia/source/framework/mediaplayer.cxx | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit 1ce2375b17912622e6db4c2c81afa24527a0104b
Author: Michael Meeks <michael.meeks at collabora.com>
Date: Sat Aug 22 19:07:12 2015 +0100
tdf#93188 - avoid crash in media player.
ToggleFloatingMode can be run during dispose, and should handle that,
thanks to Maxim Monastirsky for the analysis.
Change-Id: I72c5aff9b75fa2c1b6795e239370244dafdafae2
diff --git a/avmedia/source/framework/mediaplayer.cxx b/avmedia/source/framework/mediaplayer.cxx
index 28adf19..b9c2b67 100644
--- a/avmedia/source/framework/mediaplayer.cxx
+++ b/avmedia/source/framework/mediaplayer.cxx
@@ -101,12 +101,16 @@ void MediaFloater::ToggleFloatingMode()
{
::avmedia::MediaItem aRestoreItem;
- mpMediaWindow->updateMediaItem( aRestoreItem );
+ if (mpMediaWindow)
+ mpMediaWindow->updateMediaItem( aRestoreItem );
delete mpMediaWindow;
mpMediaWindow = NULL;
SfxDockingWindow::ToggleFloatingMode();
+ if (isDisposed())
+ return;
+
mpMediaWindow = new MediaWindow( this, true );
mpMediaWindow->setPosSize( Rectangle( Point(), GetOutputSizePixel() ) );
More information about the Libreoffice-commits
mailing list