[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sc/source

[Katarina Behrens]

 sc/source/ui/formdlg/formula.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit d92c8638a186900711faa88be5bed254b0574712
Author: Katarina Behrens <Katarina.Behrens at cib.de>
Date:   Mon Aug 24 13:09:49 2015 +0200

    tdf#93437: release reference held by ScFormulaReferenceHelper
    
    which prevents destructor from being called. It was ScFormulaDlg's
    own m_aHelper member variable holding reference to 'this'
    (extra-wicked, through SetWindow(this)), never releasing it.
    
    Change-Id: I258a280e09674d1a2f1ddebea19ea1b42dcdc777
    Reviewed-on: https://gerrit.libreoffice.org/17954
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
    Tested-by: Michael Meeks <michael.meeks at collabora.com>

diff --git a/sc/source/ui/formdlg/formula.cxx b/sc/source/ui/formdlg/formula.cxx
index 0e216a3..5955afb 100644
--- a/sc/source/ui/formdlg/formula.cxx
+++ b/sc/source/ui/formdlg/formula.cxx
@@ -248,6 +248,7 @@ void ScFormulaDlg::dispose()
 {
     ScModule* pScMod = SC_MOD();
     ScFormEditData* pData = pScMod->GetFormEditData();
+    m_aHelper.dispose();
 
     if (pData) // close dosen't destroy;
     {