[Libreoffice-commits] core.git: 2 commits - vcl/opengl vcl/qa

[Caolán McNamara]

 vcl/opengl/texture.cxx   |   15 +++++++++------
 vcl/qa/cppunit/timer.cxx |    1 +
 2 files changed, 10 insertions(+), 6 deletions(-)

New commits:
commit 2d791401f4e32a260b05b7e21cbfd60baa493b32
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Aug 27 08:09:18 2015 +0100

    coverity#1320471 Infinite loop coverity[loop_top] - Application::Yield
    
    Change-Id: I83634fa276048607cc0572178964417ce7373e0c

diff --git a/vcl/qa/cppunit/timer.cxx b/vcl/qa/cppunit/timer.cxx
index e89a28f..2ec940a 100644
--- a/vcl/qa/cppunit/timer.cxx
+++ b/vcl/qa/cppunit/timer.cxx
@@ -269,6 +269,7 @@ void TimerTest::testMultiAutoTimers()
         AutoTimerCount aCountY(nDurationMsY, nCountY);
 
         AutoTimerCount aCount(nDurationMs, nCount);
+        // coverity[loop_top] - Application::Yield allows the timer to fire and toggle nCount
         while (nCount < nEventsCount) {
             Application::Yield();
         }
commit 52a52a21c6997a6b083985fdcda540d66e86f32e
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Aug 27 08:05:45 2015 +0100

    coverity#1320472 Uninitialized scalar field
    
    Change-Id: I50e07779a541bbea6b285a855fb54d419d4aed13

diff --git a/vcl/opengl/texture.cxx b/vcl/opengl/texture.cxx
index cbb8b07..65a0b69 100644
--- a/vcl/opengl/texture.cxx
+++ b/vcl/opengl/texture.cxx
@@ -169,20 +169,23 @@ OpenGLTexture::OpenGLTexture(ImplOpenGLTexture* pImpl, Rectangle aRectangle, int
         mpImpl->IncreaseRefCount(nSlotNumber);
 }
 
-OpenGLTexture::OpenGLTexture( int nWidth, int nHeight, bool bAllocate ) :
-    maRect( Point( 0, 0 ), Size( nWidth, nHeight ) )
+OpenGLTexture::OpenGLTexture( int nWidth, int nHeight, bool bAllocate )
+    : maRect( Point( 0, 0 ), Size( nWidth, nHeight ) )
+    , mnSlotNumber(-1)
 {
     mpImpl = new ImplOpenGLTexture( nWidth, nHeight, bAllocate );
 }
 
-OpenGLTexture::OpenGLTexture( int nX, int nY, int nWidth, int nHeight ) :
-    maRect( Point( 0, 0 ), Size( nWidth, nHeight ) )
+OpenGLTexture::OpenGLTexture( int nX, int nY, int nWidth, int nHeight )
+    : maRect( Point( 0, 0 ), Size( nWidth, nHeight ) )
+    , mnSlotNumber(-1)
 {
     mpImpl = new ImplOpenGLTexture( nX, nY, nWidth, nHeight );
 }
 
-OpenGLTexture::OpenGLTexture( int nWidth, int nHeight, int nFormat, int nType, sal_uInt8* pData ) :
-    maRect( Point( 0, 0 ), Size( nWidth, nHeight ) )
+OpenGLTexture::OpenGLTexture( int nWidth, int nHeight, int nFormat, int nType, sal_uInt8* pData )
+    : maRect( Point( 0, 0 ), Size( nWidth, nHeight ) )
+    , mnSlotNumber(-1)
 {
     mpImpl = new ImplOpenGLTexture( nWidth, nHeight, nFormat, nType, pData );
 }