[Libreoffice-commits] core.git: qadevOOo/runner
Stephan Bergmann
sbergman at redhat.com
Tue Dec 8 05:26:18 PST 2015
qadevOOo/runner/util/ValueComparer.java | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
New commits:
commit 01d2fccec17091d000906c41ef5fbc4fd31aeec8
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Tue Dec 8 14:24:25 2015 +0100
These compare* calls shall most likely update result
...instead of being removed, a9824e8e05bddbf8ec417c7e5447914dd22cb8e5
"cid#1326591, cid#1326590 useless call"
Change-Id: Ia71abff8fb821cb4904794e1f9cbeb320e17c629
diff --git a/qadevOOo/runner/util/ValueComparer.java b/qadevOOo/runner/util/ValueComparer.java
index 4d54d14..bf783f4 100644
--- a/qadevOOo/runner/util/ValueComparer.java
+++ b/qadevOOo/runner/util/ValueComparer.java
@@ -239,13 +239,10 @@ public class ValueComparer {
result = true;
else if(XInterface.class.isAssignableFrom(op1.getClass()) && XInterface.class.isAssignableFrom(op2.getClass()))
- {
- // ignore
- }
+ result = compareInterfaces((XInterface)op1, (XInterface)op2);
+
else if(Enum.class.isAssignableFrom(op1.getClass()) && Enum.class.isAssignableFrom(op2.getClass()))
- {
- // ignore
- }
+ result = compareEnums((Enum)op1, (Enum)op2);
else if(op1.getClass() == String.class && op2.getClass() == String.class) // is it a String ?
result = ((String)op1).equals(op2);
More information about the Libreoffice-commits
mailing list