[Libreoffice-commits] core.git: 3 commits - sw/source

Michael Stahl mstahl at redhat.com
Tue Feb 10 05:12:28 PST 2015


 sw/source/core/undo/undobj.cxx |    3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 835db319f7cd1ea135350df0a28a7fb72d0027fd
Author: Michael Stahl <mstahl at redhat.com>
Date:   Tue Feb 10 13:28:04 2015 +0100

    coverity#1267639: logically dead code in SwUndo::UndoWithContext()
    
    Change-Id: I5e41337705bb2952a98e7e5778a217cfb2caccdb

diff --git a/sw/source/core/undo/undobj.cxx b/sw/source/core/undo/undobj.cxx
index 0072ced..f98c6f6 100644
--- a/sw/source/core/undo/undobj.cxx
+++ b/sw/source/core/undo/undobj.cxx
@@ -210,7 +210,6 @@ void SwUndo::UndoWithContext(SfxUndoContext & rContext)
     ::sw::UndoRedoContext *const pContext(
             dynamic_cast< ::sw::UndoRedoContext * >(& rContext));
     assert(pContext);
-    if (!pContext) { return; }
     const UndoRedoRedlineGuard aUndoRedoRedlineGuard(*pContext, *this);
     UndoImpl(*pContext);
 }
commit a8788866a3a7735918a1c184677632e1ffa0befd
Author: Michael Stahl <mstahl at redhat.com>
Date:   Tue Feb 10 13:27:03 2015 +0100

    coverity#1267638: logically dead code in SwUndo::RedoWithContext()
    
    Change-Id: Iab669a18ed990a23c77b5bb3d6b0a935a8af2c5d

diff --git a/sw/source/core/undo/undobj.cxx b/sw/source/core/undo/undobj.cxx
index d2724dd..0072ced 100644
--- a/sw/source/core/undo/undobj.cxx
+++ b/sw/source/core/undo/undobj.cxx
@@ -220,7 +220,6 @@ void SwUndo::RedoWithContext(SfxUndoContext & rContext)
     ::sw::UndoRedoContext *const pContext(
             dynamic_cast< ::sw::UndoRedoContext * >(& rContext));
     assert(pContext);
-    if (!pContext) { return; }
     const UndoRedoRedlineGuard aUndoRedoRedlineGuard(*pContext, *this);
     RedoImpl(*pContext);
 }
commit a3a783f9ebf1990b05e0ad60c723e6f7c2902d0a
Author: Michael Stahl <mstahl at redhat.com>
Date:   Tue Feb 10 13:26:07 2015 +0100

    coverity#1267637: logically dead code in SwUndo::Repeat()
    
    Change-Id: I85b0d880b0579f33a6e874ca250d343f7761dbcc

diff --git a/sw/source/core/undo/undobj.cxx b/sw/source/core/undo/undobj.cxx
index 855795d..d2724dd 100644
--- a/sw/source/core/undo/undobj.cxx
+++ b/sw/source/core/undo/undobj.cxx
@@ -230,7 +230,6 @@ void SwUndo::Repeat(SfxRepeatTarget & rContext)
     ::sw::RepeatContext *const pRepeatContext(
             dynamic_cast< ::sw::RepeatContext * >(& rContext));
     assert(pRepeatContext);
-    if (!pRepeatContext) { return; }
     RepeatImpl(*pRepeatContext);
 }
 


More information about the Libreoffice-commits mailing list