[Libreoffice-commits] core.git: sc/source

Stephan Bergmann sbergman at redhat.com
Wed Feb 18 03:21:04 PST 2015


 sc/source/core/tool/grouparealistener.cxx |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 0a8bcd8256f2618b30c9767d5eaddb51ec3d9a8e
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Wed Feb 18 12:20:08 2015 +0100

    Avoid numeric overflow when printing BCA_LISTEN_ALWAYS range
    
    ...where nRow=SCROW_MAX, so lcl_a1_append_r (sc/source/core/tool/address.cxx)
    would attempt rString.append( nRow + 1 ); not sure such formatting of
    BCA_LISTEN_ALWAYS should be special-cased more centrally.
    
    Change-Id: I338a953a82245c65d116746b101bbc52cf73d3f6

diff --git a/sc/source/core/tool/grouparealistener.cxx b/sc/source/core/tool/grouparealistener.cxx
index 656c931..6ff467c 100644
--- a/sc/source/core/tool/grouparealistener.cxx
+++ b/sc/source/core/tool/grouparealistener.cxx
@@ -86,7 +86,7 @@ FormulaGroupAreaListener::FormulaGroupAreaListener( const ScRange& rRange, const
     assert(mpColumn);
     SAL_INFO( "sc.core.grouparealistener",
             "FormulaGroupAreaListener ctor this " << this <<
-            " range " << maRange.Format(SCA_VALID) <<
+            " range " << (maRange == BCA_LISTEN_ALWAYS ? "LISTEN-ALWAYS" : maRange.Format(SCA_VALID)) <<
             " mnTopCellRow " << mnTopCellRow << " length " << mnGroupLen);
 }
 
@@ -94,7 +94,7 @@ FormulaGroupAreaListener::~FormulaGroupAreaListener()
 {
     SAL_INFO( "sc.core.grouparealistener",
             "FormulaGroupAreaListener dtor this " << this <<
-            " range " << maRange.Format(SCA_VALID) <<
+            " range " << (maRange == BCA_LISTEN_ALWAYS ? "LISTEN-ALWAYS" : maRange.Format(SCA_VALID)) <<
             " mnTopCellRow " << mnTopCellRow << " length " << mnGroupLen);
 }
 
@@ -184,7 +184,7 @@ void FormulaGroupAreaListener::collectFormulaCells(
 {
     SAL_INFO( "sc.core.grouparealistener",
             "FormulaGroupAreaListener::collectFormulaCells() this " << this <<
-            " range " << maRange.Format(SCA_VALID) <<
+            " range " << (maRange == BCA_LISTEN_ALWAYS ? "LISTEN-ALWAYS" : maRange.Format(SCA_VALID)) <<
             " mnTopCellRow " << mnTopCellRow << " length " << mnGroupLen);
 
     ScFormulaCell* const * pp = mpColumn->GetFormulaCellBlockAddress( mnTopCellRow);


More information about the Libreoffice-commits mailing list