[Libreoffice-commits] core.git: editeng/source

Julien Nabet serval2412 at yahoo.fr
Mon Jan 5 01:23:11 PST 2015


 editeng/source/editeng/impedit4.cxx |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 31de7888660f551597263413bfdf467aade36680
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Mon Feb 2 18:02:50 2015 +0100

    Resolves fdo#87968 : Assertion failed: false rtl_uString_newFromSubString
    
    aNewText already contains the good string so calling copy method is wrong
    (same pb for i18n::TransliterationModulesExtra::TITLE_CASE and
    i18n::TransliterationModulesExtra::SENTENCE_CASE)
    
    Change-Id: Ifce92f33e98af3a58a70d25da9c60cf3d584a001
    Reviewed-on: https://gerrit.libreoffice.org/13724
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/editeng/source/editeng/impedit4.cxx b/editeng/source/editeng/impedit4.cxx
index 5494413..d721ca3 100644
--- a/editeng/source/editeng/impedit4.cxx
+++ b/editeng/source/editeng/impedit4.cxx
@@ -2818,7 +2818,7 @@ EditSelection ImpEditEngine::TransliterateText( const EditSelection& rSelection,
                         GetLanguage( EditPaM( pNode, nCurrentStart + 1 ) ),
                         nCurrentStart, nLen, &aOffsets ));
 
-                if (aNodeStr != aNewText.copy( nCurrentStart, nLen ))
+                if (aNodeStr != aNewText)
                 {
                     aChgData.nStart     = nCurrentStart;
                     aChgData.nLen       = nLen;
@@ -2906,7 +2906,7 @@ EditSelection ImpEditEngine::TransliterateText( const EditSelection& rSelection,
                         GetLanguage( EditPaM( pNode, nCurrentStart + 1 ) ),
                         nCurrentStart, nLen, &aOffsets ));
 
-                if ( aNodeStr != aNewText.copy( nCurrentStart, nLen ))
+                if (aNodeStr != aNewText)
                 {
                     aChgData.nStart     = nCurrentStart;
                     aChgData.nLen       = nLen;
@@ -2944,7 +2944,7 @@ EditSelection ImpEditEngine::TransliterateText( const EditSelection& rSelection,
                 Sequence< sal_Int32 > aOffsets;
                 OUString aNewText( aTransliterationWrapper.transliterate( aNodeStr, nLanguage, nCurrentStart, nLen, &aOffsets ) );
 
-                if (aNodeStr != aNewText.copy( nCurrentStart, nLen ))
+                if (aNodeStr != aNewText)
                 {
                     aChgData.nStart     = nCurrentStart;
                     aChgData.nLen       = nLen;


More information about the Libreoffice-commits mailing list