[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - basegfx/source

Caolán McNamara caolanm at redhat.com
Tue Jan 13 05:02:54 PST 2015


 basegfx/source/tools/unotools.cxx |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 1d372a219a412f2710a1c7e7b794ea58dd1dcba9
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Jan 8 20:58:24 2015 +0000

    asan: global-buffer-overflow on fdo55736-1.docx
    
    throws on master, be more conservative here
    
    (cherry picked from commit 6b084f0001fc15112bf3c40d20a0c7096c83b7fe)
    
    Change-Id: If69a57aa9ff011cc670f868cb87b3a1c4d904435
    Reviewed-on: https://gerrit.libreoffice.org/13818
    Reviewed-by: Michael Stahl <mstahl at redhat.com>
    Tested-by: Michael Stahl <mstahl at redhat.com>

diff --git a/basegfx/source/tools/unotools.cxx b/basegfx/source/tools/unotools.cxx
index d4ff311..f6b1ba8 100644
--- a/basegfx/source/tools/unotools.cxx
+++ b/basegfx/source/tools/unotools.cxx
@@ -53,7 +53,10 @@ namespace unotools
         {
             const sal_Int32 nInnerSequenceCount(pInnerSequence->getLength());
 
-            if(pInnerSequenceFlags->getLength() != nInnerSequenceCount)
+            if (!nInnerSequenceCount)
+                break;
+
+            if (pInnerSequenceFlags->getLength() != nInnerSequenceCount)
                 throw lang::IllegalArgumentException();
 
             // prepare new polygon


More information about the Libreoffice-commits mailing list