[Libreoffice-commits] core.git: sc/source

[Eike Rathke]

 sc/source/core/tool/compiler.cxx |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 8825e95a44395b5c4675f077e99fe4d9fb47c62f
Author: Eike Rathke <erack at redhat.com>
Date:   Tue Jan 20 19:45:08 2015 +0100

    change assert() to SAL_WARN_IF()
    
    It's a valid condition in some cases.
    
    Change-Id: I9c9bbcf0b506a88f89e4a420dd544e4bc6502e58

diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index e53a509..fee4159 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -4160,7 +4160,11 @@ void ScCompiler::CreateStringFromExternal(OUStringBuffer& rBuffer, FormulaToken*
         {
             vector<OUString> aTabNames;
             pRefMgr->getAllCachedTableNames(nFileId, aTabNames);
-            assert(!aTabNames.empty()); // something is seriously wrong, but continue
+            // No sheet names is a valid case if external sheets were not
+            // cached in this document and external document is not reachable,
+            // else not and worth to be investigated.
+            SAL_WARN_IF( aTabNames.empty(), "sc.core", "wrecked cache of external document? '" <<
+                    *pFileName << "' '" << t->GetString().getString() << "'");
 
             pConv->makeExternalRefStr(
                 rBuffer, GetPos(), nFileId, *pFileName, aTabNames, t->GetString().getString(),