[Libreoffice-commits] core.git: basic/source

Tor Lillqvist tml at collabora.com
Fri Jan 23 22:11:41 PST 2015


 basic/source/runtime/methods.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b5938bf4b3dc63d907e2527b0e26c5e3397c50c8
Author: Tor Lillqvist <tml at collabora.com>
Date:   Sat Jan 24 07:59:58 2015 +0200

    WaE: rewrite call of rtl::OUString::operator= ...
    
    ... with empty string constant argument as call of rtl::OUString::clear
    [loplugin:stringconstant].
    
    Actually, no need to clear the string here as it already is empty, surely?
    
    Change-Id: Ib4b1a6e1b0c0f59c1c964fe58d26058b492c3821

diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index d3928a5..a86a743 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -1281,7 +1281,7 @@ RTLFUNC(Mid)
                 OUString aResultStr;
                 if (nStartPos > aArgStr.getLength())
                 {
-                    aResultStr = "";
+                    // do nothing
                 }
                 else if(nArgCount == 2)
                 {


More information about the Libreoffice-commits mailing list