[Libreoffice-commits] core.git: 4 commits - lotuswordpro/source sc/source sfx2/source sw/source

[Caolán McNamara]

 lotuswordpro/source/filter/lwppara.cxx   |    4 +---
 sc/source/core/opencl/op_statistical.cxx |    2 +-
 sfx2/source/control/bindings.cxx         |    1 -
 sfx2/source/view/viewfrm.cxx             |    6 ++----
 sw/source/core/doc/docredln.cxx          |    4 +---
 5 files changed, 5 insertions(+), 12 deletions(-)

New commits:
commit 5c85b4eacbabf651c3b49f00c30532a86c133510
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sun Jan 25 14:09:45 2015 +0000

    coverity#1266509 Useless call
    
    Change-Id: Ie2b17f067e5f9a7bacc5e6488e142d0171741106

diff --git a/sc/source/core/opencl/op_statistical.cxx b/sc/source/core/opencl/op_statistical.cxx
index 1f667f5..04dcf60 100644
--- a/sc/source/core/opencl/op_statistical.cxx
+++ b/sc/source/core/opencl/op_statistical.cxx
@@ -4626,7 +4626,7 @@ void OpRsq::GenSlidingWindowFunction(
     ss << "    double fInx;\n";
     ss << "    double fIny;\n";
     ss << "    double tmp0,tmp1;\n";
-    vSubArguments.size();
+
     ss <<"\n";
 
     ss << "   for(int i=0; i<"<<nCurWindowSize<<"; i++)\n";
commit 7185e84b862cf486900a009b4ebfe3e0042fbc3e
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sun Jan 25 14:08:29 2015 +0000

    coverity#1266510 Useless call
    
    Change-Id: I4e3127243b103ea77a56aa9cfbcb61793a644ce3

diff --git a/sfx2/source/control/bindings.cxx b/sfx2/source/control/bindings.cxx
index fe51948..466d818 100644
--- a/sfx2/source/control/bindings.cxx
+++ b/sfx2/source/control/bindings.cxx
@@ -1106,7 +1106,6 @@ const SfxPoolItem* SfxBindings::Execute_Impl( sal_uInt16 nId, const SfxPoolItem*
 
     SfxDispatcher &rDispatcher = *pDispatcher;
     rDispatcher.Flush();
-    rDispatcher.GetFrame();  // -Wall is this required???
 
     // get SlotServer (Slot+ShellLevel) and Shell from cache
     ::boost::scoped_ptr<SfxStateCache> xCache;
diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index 77a15b5..de07b92 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -845,15 +845,15 @@ void SfxViewFrame::ExecReload_Impl( SfxRequest& rReq )
     }
 }
 
-
 void SfxViewFrame::StateReload_Impl( SfxItemSet& rSet )
 {
     SfxObjectShell* pSh = GetObjectShell();
     if ( !pSh )
+    {
         // I'm just on reload and am yielding myself ...
         return;
+    }
 
-    GetFrame().GetParentFrame();
     SfxWhichIter aIter( rSet );
     for ( sal_uInt16 nWhich = aIter.FirstWhich(); nWhich; nWhich = aIter.NextWhich() )
     {
@@ -925,8 +925,6 @@ void SfxViewFrame::StateReload_Impl( SfxItemSet& rSet )
     }
 }
 
-
-
 void SfxViewFrame::ExecHistory_Impl( SfxRequest &rReq )
 {
     // Is there an Undo-Manager on the top Shell?
commit 80c0d3de5c855386ccf079501f3d6d77babb81e1
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sun Jan 25 14:07:50 2015 +0000

    coverity#1266511 Useless call
    
    Change-Id: I0ca967e6e07cc00159612dd8e19648445e0a011a

diff --git a/lotuswordpro/source/filter/lwppara.cxx b/lotuswordpro/source/filter/lwppara.cxx
index 22cf028..b2326f0 100644
--- a/lotuswordpro/source/filter/lwppara.cxx
+++ b/lotuswordpro/source/filter/lwppara.cxx
@@ -578,8 +578,6 @@ void LwpPara::RegisterStyle()
                     LwpNumberingOverride* pNumbering = this->GetParaNumbering();
                     sal_uInt16 nPosition = pNumbering->GetPosition();
                     bool bLesser = m_pSilverBullet->IsLesserLevel(nPosition);
-                    /*sal_Bool bResetSection =*/ m_pSilverBullet->IsNewSection(nPosition);
-                    bool bHeading;
                     LwpPara* pPara = this;
                     LwpPara* pPrePara = NULL;
                     sal_uInt16 nNum = 0, nLevel = 0, nFoundLevel = 0xffff, nFoundBound = 0;
@@ -589,7 +587,7 @@ void LwpPara::RegisterStyle()
                     {
                         nFoundBound++;
                     }
-                    bHeading = pNumbering->IsHeading();
+                    bool bHeading = pNumbering->IsHeading();
 
                     while(true)
                     {
commit f0fdd59f0ec88ef69b463d73963a0f3f81e1d78a
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sun Jan 25 14:05:02 2015 +0000

    coverity#1266513 Useless call
    
    Change-Id: Icbfa17fc28b9ba3f2472d9042bc6c422b5c79b46

diff --git a/sw/source/core/doc/docredln.cxx b/sw/source/core/doc/docredln.cxx
index b2f1eea..52e2e80 100644
--- a/sw/source/core/doc/docredln.cxx
+++ b/sw/source/core/doc/docredln.cxx
@@ -747,10 +747,8 @@ SwRedlineExtraData* SwRedlineExtraData_FormattingChanges::CreateNew() const
     return new SwRedlineExtraData_FormattingChanges( *this );
 }
 
-void SwRedlineExtraData_FormattingChanges::Reject( SwPaM& rPam ) const
+void SwRedlineExtraData_FormattingChanges::Reject(SwPaM&) const
 {
-    rPam.GetDoc();  // This is here just to prevent build 'warning'
-
     // ToDo: Add 'Reject' logic
 }