[Libreoffice-commits] core.git: dbaccess/source

Lionel Elie Mamane lionel at mamane.lu
Sun Jan 25 10:18:54 PST 2015


 dbaccess/source/core/api/RowSetBase.cxx |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

New commits:
commit 3d12bdfb243e1efbc368d95d3e42e7d713b63b45
Author: Lionel Elie Mamane <lionel at mamane.lu>
Date:   Sun Jan 25 19:01:52 2015 +0100

    when beforeFirst/afterLast, there is no value, so none to notify
    
    Change-Id: I599f8efae98e7cc7f65f47cec7f342c8b3dc8282
    Reviewed-on: https://gerrit.libreoffice.org/14177
    Reviewed-by: Lionel Elie Mamane <lionel at mamane.lu>
    Tested-by: Lionel Elie Mamane <lionel at mamane.lu>

diff --git a/dbaccess/source/core/api/RowSetBase.cxx b/dbaccess/source/core/api/RowSetBase.cxx
index 3dbd6a0..53be639 100644
--- a/dbaccess/source/core/api/RowSetBase.cxx
+++ b/dbaccess/source/core/api/RowSetBase.cxx
@@ -1055,6 +1055,12 @@ void ORowSetBase::setCurrentRow( bool _bMoved, bool _bDoNotify, const ORowSetRow
         ORowSetRow rRow = (*m_aCurrentRow);
         OSL_ENSURE(rRow.is() ,"Invalid size of vector!");
 #endif
+
+        // notification order
+        // - column values
+        if ( _bDoNotify )
+            firePropertyChange(_rOldValues);
+
     }
     else
     {
@@ -1064,11 +1070,6 @@ void ORowSetBase::setCurrentRow( bool _bMoved, bool _bDoNotify, const ORowSetRow
         m_aCurrentRow.setBookmark(m_aBookmark);
     }
 
-    // notification order
-    // - column values
-    if ( _bDoNotify )
-        firePropertyChange(_rOldValues);
-
     // TODO: can this be done before the notifications?
     if(!(m_bBeforeFirst || m_bAfterLast) && !m_aCurrentRow.isNull() && m_aCurrentRow->is() && m_aCurrentRow != m_pCache->getEnd())
         m_aOldRow->setRow(new ORowSetValueVector( *(*m_aCurrentRow) ));


More information about the Libreoffice-commits mailing list