[Libreoffice-commits] core.git: sc/source

Caolán McNamara caolanm at redhat.com
Sat Jan 31 11:00:22 PST 2015


 sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx |    2 +-
 sc/source/ui/inc/RandomNumberGeneratorDialog.hxx               |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 4ad4540e33c431a8b4b5b1692cee3432de88b3f1
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Jan 31 18:57:25 2015 +0000

    coverity#1267677 Big parameter passed by value
    
    Change-Id: I04a96e13eb4f17a6fa91435eff104fd95a902cf2

diff --git a/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx b/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx
index 954cadd..ee906d4 100644
--- a/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx
@@ -252,7 +252,7 @@ void ScRandomNumberGeneratorDialog::SelectGeneratorAndGenerateNumbers()
 }
 
 template<class RNG>
-void ScRandomNumberGeneratorDialog::GenerateNumbers(RNG randomGenerator, const sal_Int16 aDistributionStringId, boost::optional<sal_Int8> aDecimalPlaces)
+void ScRandomNumberGeneratorDialog::GenerateNumbers(RNG& randomGenerator, const sal_Int16 aDistributionStringId, boost::optional<sal_Int8> aDecimalPlaces)
 {
     OUString aUndo = SC_STRLOAD(RID_STATISTICS_DLGS, STR_UNDO_DISTRIBUTION_TEMPLATE);
     OUString aDistributionName = SC_STRLOAD(RID_STATISTICS_DLGS, aDistributionStringId);
diff --git a/sc/source/ui/inc/RandomNumberGeneratorDialog.hxx b/sc/source/ui/inc/RandomNumberGeneratorDialog.hxx
index d940b39..b1736b2 100644
--- a/sc/source/ui/inc/RandomNumberGeneratorDialog.hxx
+++ b/sc/source/ui/inc/RandomNumberGeneratorDialog.hxx
@@ -65,7 +65,7 @@ private:
 
     template<class RNG>
 
-    void GenerateNumbers(RNG randomGenerator, const sal_Int16 aDistributionStringId, const boost::optional<sal_Int8> aDecimalPlaces);
+    void GenerateNumbers(RNG& randomGenerator, const sal_Int16 aDistributionStringId, const boost::optional<sal_Int8> aDecimalPlaces);
 
     void SelectGeneratorAndGenerateNumbers();
 


More information about the Libreoffice-commits mailing list