[Libreoffice-commits] core.git: 7 commits - include/svtools svtools/source
Stephan Bergmann
sbergman at redhat.com
Thu Jul 16 01:14:50 PDT 2015
include/svtools/ServerDetailsControls.hxx | 2 +-
include/svtools/breadcrumb.hxx | 4 ++--
include/svtools/foldertree.hxx | 4 ++--
svtools/source/contnr/foldertree.cxx | 4 ++--
svtools/source/control/breadcrumb.cxx | 6 +++---
svtools/source/dialogs/ServerDetailsControls.cxx | 2 +-
6 files changed, 11 insertions(+), 11 deletions(-)
New commits:
commit f1fbd6af4f796c53667fbf56b8b5e5dcbcabe45f
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Thu Jul 16 10:13:45 2015 +0200
loplugin:stringconstant
Change-Id: Ifd9517672252cdbf4957cd23dbd9177aed8631da
diff --git a/svtools/source/control/breadcrumb.cxx b/svtools/source/control/breadcrumb.cxx
index 3685c1a..564c968 100644
--- a/svtools/source/control/breadcrumb.cxx
+++ b/svtools/source/control/breadcrumb.cxx
@@ -149,7 +149,7 @@ void Breadcrumb::SetURL( const OUString& rURL )
{
unsigned int nIndex = nSegments + i;
- if( m_aLinks[nIndex]->GetText() == "" )
+ if( m_aLinks[nIndex]->GetText().isEmpty() )
{
bRight = false;
}
commit 21b8cb7ff4907c6ff4d79d892d10feec7557ed34
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Thu Jul 16 10:13:14 2015 +0200
loplugin:loopvartoosmall
Change-Id: Ia314ea7e924b2096c121d9cfda2c64e6d523a987
diff --git a/svtools/source/control/breadcrumb.cxx b/svtools/source/control/breadcrumb.cxx
index 8b43fa1..3685c1a 100644
--- a/svtools/source/control/breadcrumb.cxx
+++ b/svtools/source/control/breadcrumb.cxx
@@ -23,7 +23,7 @@ Breadcrumb::~Breadcrumb()
void Breadcrumb::dispose()
{
- for( unsigned int i = 0; i < m_aLinks.size(); i++ )
+ for( std::vector<VclPtr<FixedHyperlink>>::size_type i = 0; i < m_aLinks.size(); i++ )
{
m_aSeparators[i].disposeAndClear();
m_aLinks[i].disposeAndClear();
@@ -93,7 +93,7 @@ void Breadcrumb::SetURL( const OUString& rURL )
// clear unused fields
- for( unsigned int i = nSegments + 1; i < m_aLinks.size(); i++ )
+ for( std::vector<VclPtr<FixedHyperlink>>::size_type i = nSegments + 1; i < m_aLinks.size(); i++ )
{
if( bClear )
m_aLinks[i]->SetText( "" );
commit 97a3ea0a2d9194003d67fb3f6bb6f1a5c145440b
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Thu Jul 16 10:12:09 2015 +0200
loplugin:saloverride
Change-Id: Ia3f3fbc7a0cd936b9cb6e89a15dd08fb4b73332e
diff --git a/include/svtools/breadcrumb.hxx b/include/svtools/breadcrumb.hxx
index ff08994..6e6ac5f 100644
--- a/include/svtools/breadcrumb.hxx
+++ b/include/svtools/breadcrumb.hxx
@@ -47,9 +47,9 @@ class SVT_DLLPUBLIC Breadcrumb : public VclHBox
public:
Breadcrumb( vcl::Window* pParent, WinBits nWinStyle = 0 );
- ~Breadcrumb();
+ virtual ~Breadcrumb();
- void dispose();
+ void dispose() SAL_OVERRIDE;
void SetClickHdl( const Link<>& rLink );
OUString GetHdlURL();
commit 109ca5b630018dad9ad4001724abd410886974cd
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Thu Jul 16 10:11:22 2015 +0200
loplugin:loopvartoosmall
Change-Id: Iaeb3e12f9e83328c9ffd4718e7907bd7c7a39910
diff --git a/svtools/source/contnr/foldertree.cxx b/svtools/source/contnr/foldertree.cxx
index c1e038d..5c8ee46 100644
--- a/svtools/source/contnr/foldertree.cxx
+++ b/svtools/source/contnr/foldertree.cxx
@@ -50,7 +50,7 @@ void FolderTree::FillTreeEntry( SvTreeListEntry* pEntry )
if ( SUCCESS == eResult )
{
- for( unsigned int i = 0; i < aContent.size(); i++ )
+ for( std::vector<SortingData_Impl *>::size_type i = 0; i < aContent.size(); i++ )
{
if( aContent[i]->mbIsFolder )
{
commit a9c4476cbb1babdc45695601e92e98ca5ac072a2
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Thu Jul 16 10:10:30 2015 +0200
loplugin:saloverride
Change-Id: Id6e434c0261dbba88b1ec1b98534e4f63db6dcda
diff --git a/include/svtools/foldertree.hxx b/include/svtools/foldertree.hxx
index bd066d7..e430072 100644
--- a/include/svtools/foldertree.hxx
+++ b/include/svtools/foldertree.hxx
@@ -44,7 +44,7 @@ private:
public:
FolderTree( vcl::Window* pParent, WinBits nBits );
- virtual void RequestingChildren( SvTreeListEntry* pEntry );
+ virtual void RequestingChildren( SvTreeListEntry* pEntry ) SAL_OVERRIDE;
void FillTreeEntry( SvTreeListEntry* pEntry );
void SetTreePath( OUString const & sUrl );
commit ef6d7c50e05e09fc33f50a876e709a7587df4ff0
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Thu Jul 16 10:09:57 2015 +0200
loplugin:passstuffbyref
Change-Id: Iddd06dcc2bf4744ae9d70b54e4c58a9a468c1461
diff --git a/include/svtools/foldertree.hxx b/include/svtools/foldertree.hxx
index 213c254..bd066d7 100644
--- a/include/svtools/foldertree.hxx
+++ b/include/svtools/foldertree.hxx
@@ -47,7 +47,7 @@ public:
virtual void RequestingChildren( SvTreeListEntry* pEntry );
void FillTreeEntry( SvTreeListEntry* pEntry );
- void SetTreePath( OUString sUrl );
+ void SetTreePath( OUString const & sUrl );
void SetBlackList( const ::com::sun::star::uno::Sequence< OUString >& rBlackList );
};
diff --git a/svtools/source/contnr/foldertree.cxx b/svtools/source/contnr/foldertree.cxx
index b4c27fd..c1e038d 100644
--- a/svtools/source/contnr/foldertree.cxx
+++ b/svtools/source/contnr/foldertree.cxx
@@ -65,7 +65,7 @@ void FolderTree::FillTreeEntry( SvTreeListEntry* pEntry )
}
}
-void FolderTree::SetTreePath( OUString sUrl )
+void FolderTree::SetTreePath( OUString const & sUrl )
{
INetURLObject aUrl( sUrl );
aUrl.setFinalSlash();
commit b65c6c84a231340d45b8fb3029d9cc3d65f9bd42
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Thu Jul 16 10:08:51 2015 +0200
loplugin:passstuffbyref
Change-Id: I61656dc160a716ddd2cdec2a630e6868703f4428
diff --git a/include/svtools/ServerDetailsControls.hxx b/include/svtools/ServerDetailsControls.hxx
index 5df8a36..8043d46 100644
--- a/include/svtools/ServerDetailsControls.hxx
+++ b/include/svtools/ServerDetailsControls.hxx
@@ -127,7 +127,7 @@ class CmisDetailsContainer : public DetailsContainer
VclPtr<Edit> m_pEDRoot;
public:
- CmisDetailsContainer( VclBuilderContainer* pBuilder, OUString sBinding );
+ CmisDetailsContainer( VclBuilderContainer* pBuilder, OUString const & sBinding );
virtual ~CmisDetailsContainer( ) { };
virtual void show( bool bShow = true ) SAL_OVERRIDE;
diff --git a/svtools/source/dialogs/ServerDetailsControls.cxx b/svtools/source/dialogs/ServerDetailsControls.cxx
index e2f3ddc..71eab33 100644
--- a/svtools/source/dialogs/ServerDetailsControls.cxx
+++ b/svtools/source/dialogs/ServerDetailsControls.cxx
@@ -248,7 +248,7 @@ bool SmbDetailsContainer::setUrl( const INetURLObject& rUrl )
return bSuccess;
}
-CmisDetailsContainer::CmisDetailsContainer( VclBuilderContainer* pBuilder, OUString sBinding ) :
+CmisDetailsContainer::CmisDetailsContainer( VclBuilderContainer* pBuilder, OUString const & sBinding ) :
DetailsContainer( pBuilder, "CmisDetails" ),
m_sUsername( ),
m_xCmdEnv( ),
More information about the Libreoffice-commits
mailing list