[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sw/source

Caolán McNamara caolanm at redhat.com
Thu Jul 16 02:04:50 PDT 2015


 sw/source/core/access/accnotextframe.cxx |    3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 03e115e51e5102ffd9c8498f865ed9e768f4f490
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Jul 13 12:38:18 2015 +0100

    fix a11y crash seen on close of tdf#92573
    
    its not the reported crash, which has "gone away" which might
    be a duplicate of tdf#90502
    
    the switch only handled RES_TITLE_CHANGED and RES_DESCRIPTION_CHANGED so if its
    anything else, e.g. OBJ_DYING, then don't attempt GetNoTextNode
    
    (cherry picked from commit 7de992bcc66c973bb6b247184cac38f01cd1104a)
    
    Change-Id: I642beb66613481cbc7ee18647f0204a67d670a84
    Reviewed-on: https://gerrit.libreoffice.org/16991
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
    Tested-by: Michael Meeks <michael.meeks at collabora.com>

diff --git a/sw/source/core/access/accnotextframe.cxx b/sw/source/core/access/accnotextframe.cxx
index 9e92a91..8d06a70 100644
--- a/sw/source/core/access/accnotextframe.cxx
+++ b/sw/source/core/access/accnotextframe.cxx
@@ -102,6 +102,9 @@ void SwAccessibleNoTextFrame::Modify( const SfxPoolItem* pOld, const SfxPoolItem
             return; // probably was deleted - avoid doing anything
     }
 
+    if (nWhich != RES_TITLE_CHANGED || nWhich != RES_DESCRIPTION_CHANGED)
+        return;
+
     const SwNoTxtNode *pNd = GetNoTxtNode();
     OSL_ENSURE( pNd == aDepend.GetRegisteredIn(), "invalid frame" );
     switch( nWhich )


More information about the Libreoffice-commits mailing list