[Libreoffice-commits] core.git: svx/source

Caolán McNamara caolanm at redhat.com
Thu Jun 4 12:25:22 PDT 2015


 svx/source/sidebar/text/TextPropertyPanel.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 85e926ff2ebfb793f4e7852edde50bc6783ed5e3
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Jun 4 20:23:19 2015 +0100

    coverity#1304135 Missing break in switch
    
    from
    
    commit 0e2ef262bea4cbc7cb04cfcd1d47f2a9d6092398
    Date:   Thu May 21 13:58:52 2015 +0200
    
        tdf#88276: Add background colour toolbar and sidebar buttons
    
        but they do nothing yet, follow-up commit(s) add real functionality
        to them
    
    I take it that bNeedTextSpacing = true where it used to be mpToolBoxSpacing->Enable()
    so fall-through that happens anyway also sets bNeedTextSpacing so presumably
    everything is ok here
    
    Change-Id: I8f1d4137a74fcc2c7ba6959e5b5c4b1f7464643c

diff --git a/svx/source/sidebar/text/TextPropertyPanel.cxx b/svx/source/sidebar/text/TextPropertyPanel.cxx
index 0166136..a831ab9 100644
--- a/svx/source/sidebar/text/TextPropertyPanel.cxx
+++ b/svx/source/sidebar/text/TextPropertyPanel.cxx
@@ -157,7 +157,6 @@ void TextPropertyPanel::HandleContextChange (
 
         case CombinedEnumContext(Application_Calc, Context_EditCell):
         case CombinedEnumContext(Application_Calc, Context_DrawText):
-            bNeedTextSpacing = true;
 
         case CombinedEnumContext(Application_WriterVariants, Context_DrawText):
         case CombinedEnumContext(Application_WriterVariants, Context_Annotation):


More information about the Libreoffice-commits mailing list