[Libreoffice-commits] core.git: 3 commits - sc/source

Miklos Vajna vmiklos at collabora.co.uk
Fri Jun 5 03:35:21 PDT 2015


 sc/source/filter/html/htmlpars.cxx |   34 +++++++++++++---------------------
 1 file changed, 13 insertions(+), 21 deletions(-)

New commits:
commit 1af10d4012aa84a26568bac42bb47a267342afd5
Author: Miklos Vajna <vmiklos at collabora.co.uk>
Date:   Fri Jun 5 12:34:37 2015 +0200

    sc: loplugin:staticmethods
    
    Change-Id: Ib9689c77cfc8c24b86db7fe6a13f66386d1b0eb8

diff --git a/sc/source/filter/html/htmlpars.cxx b/sc/source/filter/html/htmlpars.cxx
index c343e3b..ae0ce82 100644
--- a/sc/source/filter/html/htmlpars.cxx
+++ b/sc/source/filter/html/htmlpars.cxx
@@ -3164,31 +3164,31 @@ public:
     }
 
     // new members
-    void simple_selector_type(const char* /*p*/, size_t /*n*/) {}
+    static void simple_selector_type(const char* /*p*/, size_t /*n*/) {}
 
-    void simple_selector_class(const char* /*p*/, size_t /*n*/) {}
+    static void simple_selector_class(const char* /*p*/, size_t /*n*/) {}
 
-    void simple_selector_pseudo_element(orcus::css::pseudo_element_t /*pe*/) {}
+    static void simple_selector_pseudo_element(orcus::css::pseudo_element_t /*pe*/) {}
 
-    void simple_selector_pseudo_class(orcus::css::pseudo_class_t /*pc*/) {}
+    static void simple_selector_pseudo_class(orcus::css::pseudo_class_t /*pc*/) {}
 
-    void simple_selector_id(const char* /*p*/, size_t /*n*/) {}
+    static void simple_selector_id(const char* /*p*/, size_t /*n*/) {}
 
-    void end_simple_selector() {}
+    static void end_simple_selector() {}
 
-    void end_selector() {}
+    static void end_selector() {}
 
-    void combinator(orcus::css::combinator_t /*combinator*/) {}
+    static void combinator(orcus::css::combinator_t /*combinator*/) {}
 
-    void rgb(uint8_t /*red*/ , uint8_t /*green*/ , uint8_t /*blue*/ ) {}
+    static void rgb(uint8_t /*red*/ , uint8_t /*green*/ , uint8_t /*blue*/ ) {}
 
-    void rgba(uint8_t /*red*/ , uint8_t /*green*/ , uint8_t /*blue*/ , double /*alpha*/ ) {}
+    static void rgba(uint8_t /*red*/ , uint8_t /*green*/ , uint8_t /*blue*/ , double /*alpha*/ ) {}
 
-    void hsl(uint8_t /*hue*/ , uint8_t /*sat*/ , uint8_t /*light*/ ) {}
+    static void hsl(uint8_t /*hue*/ , uint8_t /*sat*/ , uint8_t /*light*/ ) {}
 
-    void hsla(uint8_t /*hue*/ , uint8_t /*sat*/ , uint8_t /*light*/ , double /*alpha*/ ) {}
+    static void hsla(uint8_t /*hue*/ , uint8_t /*sat*/ , uint8_t /*light*/ , double /*alpha*/ ) {}
 
-    void url(const char* /*p*/, size_t /*n*/) {}
+    static void url(const char* /*p*/, size_t /*n*/) {}
 
 };
 
commit 9eeac5506bd726350b51cb0c36606646f04cbae9
Author: Miklos Vajna <vmiklos at collabora.co.uk>
Date:   Fri Jun 5 12:32:10 2015 +0200

    sc: another loplugin:unreffun
    
    Change-Id: Ic60d05d64c7584b45d69148d29155b04524ab011

diff --git a/sc/source/filter/html/htmlpars.cxx b/sc/source/filter/html/htmlpars.cxx
index c61271b..c343e3b 100644
--- a/sc/source/filter/html/htmlpars.cxx
+++ b/sc/source/filter/html/htmlpars.cxx
@@ -3100,7 +3100,6 @@ class CSSHandler
 
         MemStr() : mp(NULL), mn(0) {}
         MemStr(const char* p, size_t n) : mp(p), mn(n) {}
-        MemStr(const MemStr& r) : mp(r.mp), mn(r.mn) {}
         MemStr& operator=(const MemStr& r)
         {
             mp = r.mp;
commit c76a8580c62299f310e7e43927afc133e2f02350
Author: Miklos Vajna <vmiklos at collabora.co.uk>
Date:   Fri Jun 5 12:29:36 2015 +0200

    sc: loplugin:unreffun
    
    Change-Id: I6fce9c390aea3f8b2590bc2e1241e0b2b45af51c

diff --git a/sc/source/filter/html/htmlpars.cxx b/sc/source/filter/html/htmlpars.cxx
index e418ed8..c61271b 100644
--- a/sc/source/filter/html/htmlpars.cxx
+++ b/sc/source/filter/html/htmlpars.cxx
@@ -3124,13 +3124,6 @@ public:
         // TODO: For now, we ignore at-rule properties.
     }
 
-    void selector_name(const char* p_elem, size_t n_elem, const char* p_class, size_t n_class)
-    {
-        MemStr aElem(p_elem, n_elem), aClass(p_class, n_class);
-        SelectorName aName(aElem, aClass);
-        maSelectorNames.push_back(aName);
-    }
-
     void property_name(const char* p, size_t n)
     {
         maPropName = MemStr(p, n);


More information about the Libreoffice-commits mailing list