[Libreoffice-commits] core.git: sc/inc sc/source

Stephan Bergmann sbergman at redhat.com
Wed Jun 10 23:47:01 PDT 2015


 sc/inc/externalrefmgr.hxx                |    1 -
 sc/source/ui/docshell/externalrefmgr.cxx |   11 ++++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

New commits:
commit c82c94b40157c08bbbc524b2dc02714cbe82dc65
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Jun 11 08:46:23 2015 +0200

    loplugin:staticmethods
    
    Change-Id: If54b3017296f5bcea01b3b0d24d9ac821f6a24e9

diff --git a/sc/inc/externalrefmgr.hxx b/sc/inc/externalrefmgr.hxx
index 792c005..cd94c73 100644
--- a/sc/inc/externalrefmgr.hxx
+++ b/sc/inc/externalrefmgr.hxx
@@ -794,7 +794,6 @@ private:
      */
     void transformUnsavedRefToSavedRef( SfxObjectShell* pShell );
 
-    void insertRefCell(RefCellMap::iterator& itr, ScFormulaCell* pCell);
 private:
     ScDocument* mpDoc;
 
diff --git a/sc/source/ui/docshell/externalrefmgr.cxx b/sc/source/ui/docshell/externalrefmgr.cxx
index 442ff2f..042201d 100644
--- a/sc/source/ui/docshell/externalrefmgr.cxx
+++ b/sc/source/ui/docshell/externalrefmgr.cxx
@@ -2038,7 +2038,10 @@ void ScExternalRefManager::refreshAllRefCells(sal_uInt16 nFileId)
     pVShell->PaintGrid();
 }
 
-void ScExternalRefManager::insertRefCell(RefCellMap::iterator& itr, ScFormulaCell* pCell)
+namespace {
+
+void insertRefCellByIterator(
+    ScExternalRefManager::RefCellMap::iterator& itr, ScFormulaCell* pCell)
 {
     if (pCell)
     {
@@ -2047,6 +2050,8 @@ void ScExternalRefManager::insertRefCell(RefCellMap::iterator& itr, ScFormulaCel
     }
 }
 
+}
+
 void ScExternalRefManager::insertRefCell(sal_uInt16 nFileId, const ScAddress& rCell)
 {
     RefCellMap::iterator itr = maRefCells.find(nFileId);
@@ -2062,7 +2067,7 @@ void ScExternalRefManager::insertRefCell(sal_uInt16 nFileId, const ScAddress& rC
         itr = r.first;
     }
 
-    insertRefCell(itr, mpDoc->GetFormulaCell(rCell));
+    insertRefCellByIterator(itr, mpDoc->GetFormulaCell(rCell));
 }
 
 void ScExternalRefManager::insertRefCellFromTemplate( ScFormulaCell* pTemplateCell, ScFormulaCell* pCell )
@@ -2073,7 +2078,7 @@ void ScExternalRefManager::insertRefCellFromTemplate( ScFormulaCell* pTemplateCe
     for (RefCellMap::iterator itr = maRefCells.begin(); itr != maRefCells.end(); ++itr)
     {
         if (itr->second.find(pTemplateCell) != itr->second.end())
-            insertRefCell(itr, pCell);
+            insertRefCellByIterator(itr, pCell);
     }
 }
 


More information about the Libreoffice-commits mailing list