[Libreoffice-commits] core.git: sc/source

Eike Rathke erack at redhat.com
Sat Jun 13 06:14:58 PDT 2015


 sc/source/core/tool/token.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c1fc84ac140d519e0bfa7a607e36771682b08eed
Author: Eike Rathke <erack at redhat.com>
Date:   Sat Jun 13 15:12:32 2015 +0200

    do not access token data after token has been destroyed
    
    Change-Id: I624e64745fd3874be3e1bd3df6bac18dfb17aebb

diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx
index 727a3d6..bcb7a7b 100644
--- a/sc/source/core/tool/token.cxx
+++ b/sc/source/core/tool/token.cxx
@@ -2345,9 +2345,9 @@ void ScTokenArray::ReadjustAbsolute3DReferences( const ScDocument* pOldDoc, cons
                     OUString aTabName;
                     sal_uInt16 nFileId;
                     GetExternalTableData(pOldDoc, pNewDoc, rRef1.Tab(), aTabName, nFileId);
-                    pCode[j]->DecRef();
                     ScExternalDoubleRefToken* pToken = new ScExternalDoubleRefToken(nFileId, aTabName, rRef);
                     pToken->IncRef();
+                    pCode[j]->DecRef(); // ATTENTION: rRef can't be used after this point
                     pCode[j] = pToken;
                 }
             }


More information about the Libreoffice-commits mailing list