[Libreoffice-commits] core.git: compilerplugins/clang

Stephan Bergmann sbergman at redhat.com
Thu Jun 25 06:59:36 PDT 2015


 compilerplugins/clang/stringconstant.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d4ad86dac6e8971a4f21168051876a0d68f48649
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Jun 25 15:59:01 2015 +0200

    ...in case this ever gets used with an unsigned APSInt of bitwidth < 7
    
    Change-Id: Ic9436529321e523edd25d0f83ac09a0e22a44013

diff --git a/compilerplugins/clang/stringconstant.cxx b/compilerplugins/clang/stringconstant.cxx
index 20ff2a9..1280ce1 100644
--- a/compilerplugins/clang/stringconstant.cxx
+++ b/compilerplugins/clang/stringconstant.cxx
@@ -1191,7 +1191,7 @@ void StringConstant::handleOUStringCtor(
         && e3->getArg(0)->IgnoreParenImpCasts()->isIntegerConstantExpr(
             res, compiler.getASTContext()))
     {
-        if (res.getSExtValue() > 0 && res.getSExtValue() <= 127) {
+        if (res.getZExtValue() > 0 && res.getZExtValue() <= 127) {
             report(
                 DiagnosticsEngine::Warning,
                 ("in call of %0, replace OUString constructed from a (non-NUL)"


More information about the Libreoffice-commits mailing list