[Libreoffice-commits] core.git: xmloff/source

Caolán McNamara caolanm at redhat.com
Tue Jun 30 09:32:50 PDT 2015


 xmloff/source/draw/shapeimport.cxx |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit ab23efcc2bb9ca178dee16b3d01eabb3f80d8e17
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue Jun 30 17:31:27 2015 +0100

    coverity#1308431 wiggle code to see if this silences coverity
    
    Change-Id: I44eae735b710332d87f2f642911e988c796457cd

diff --git a/xmloff/source/draw/shapeimport.cxx b/xmloff/source/draw/shapeimport.cxx
index c155b54..322d27c 100644
--- a/xmloff/source/draw/shapeimport.cxx
+++ b/xmloff/source/draw/shapeimport.cxx
@@ -874,8 +874,10 @@ void ShapeSortContext::popGroupAndSort()
     {
         while( nIndex < rHint.nShould && !maUnsortedList.empty() )
         {
-            ZOrderHint aGapHint( *maUnsortedList.begin() );
-            maUnsortedList.erase(maUnsortedList.begin());
+            auto it = maUnsortedList.begin();
+
+            ZOrderHint aGapHint(*it);
+            maUnsortedList.erase(it);
 
             moveShape( aGapHint.nIs, nIndex++ );
         }


More information about the Libreoffice-commits mailing list