[Libreoffice-commits] core.git: sc/inc sc/source xmlsecurity/source

Caolán McNamara caolanm at redhat.com
Thu Mar 5 09:17:34 PST 2015


 sc/inc/viewuno.hxx                                |    5 ++---
 sc/source/core/opencl/formulagroupcl.cxx          |    2 +-
 sc/source/ui/unoobj/viewuno.cxx                   |    4 ++--
 sc/source/ui/view/drawvie4.cxx                    |    4 ++--
 xmlsecurity/source/helper/xmlsignaturehelper2.cxx |    2 +-
 xmlsecurity/source/helper/xmlsignaturehelper2.hxx |    2 +-
 6 files changed, 9 insertions(+), 10 deletions(-)

New commits:
commit 2c0e1917c18711d6762e12042794b745f08cf62f
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Mar 5 16:29:42 2015 +0000

    V801: Decreased performance
    
    Change-Id: I48c716d87ce3e46f61393ae140bf2e05d9fd6241

diff --git a/sc/inc/viewuno.hxx b/sc/inc/viewuno.hxx
index 9a489f9..7d8131a 100644
--- a/sc/inc/viewuno.hxx
+++ b/sc/inc/viewuno.hxx
@@ -390,9 +390,8 @@ public:
                                     sal_Int8 >& aIdentifier )
                                 throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
 
-    static const com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId();
-    static ScTabViewObj* getImplementation( const com::sun::star::uno::Reference<
-                                    com::sun::star::uno::XInterface> xObj );
+    static const css::uno::Sequence<sal_Int8>& getUnoTunnelId();
+    static ScTabViewObj* getImplementation(const css::uno::Reference<css::uno::XInterface>& rObj);
 
                             // XTypeProvider
     virtual ::com::sun::star::uno::Sequence< ::com::sun::star::uno::Type > SAL_CALL getTypes()
diff --git a/sc/source/core/opencl/formulagroupcl.cxx b/sc/source/core/opencl/formulagroupcl.cxx
index 8305dd1..e83069d 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -135,7 +135,7 @@ std::string StackVarEnumToString(StackVar const e)
 }
 
 #ifdef SAL_DETAIL_ENABLE_LOG_INFO
-std::string linenumberify(const std::string s)
+std::string linenumberify(const std::string& s)
 {
     std::stringstream ss;
     int linenumber = 1;
diff --git a/sc/source/ui/unoobj/viewuno.cxx b/sc/source/ui/unoobj/viewuno.cxx
index 83902ca..c15c8cd 100644
--- a/sc/source/ui/unoobj/viewuno.cxx
+++ b/sc/source/ui/unoobj/viewuno.cxx
@@ -2231,10 +2231,10 @@ const uno::Sequence<sal_Int8>& ScTabViewObj::getUnoTunnelId()
     return theScTabViewObjUnoTunnelId::get().getSeq();
 }
 
-ScTabViewObj* ScTabViewObj::getImplementation( const uno::Reference<uno::XInterface> xObj )
+ScTabViewObj* ScTabViewObj::getImplementation(const uno::Reference<uno::XInterface>& rObj)
 {
     ScTabViewObj* pRet = NULL;
-    uno::Reference<lang::XUnoTunnel> xUT( xObj, uno::UNO_QUERY );
+    uno::Reference<lang::XUnoTunnel> xUT(rObj, uno::UNO_QUERY);
     if (xUT.is())
         pRet = reinterpret_cast<ScTabViewObj*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething(getUnoTunnelId())));
     return pRet;
diff --git a/sc/source/ui/view/drawvie4.cxx b/sc/source/ui/view/drawvie4.cxx
index b3b6e84..108d714 100644
--- a/sc/source/ui/view/drawvie4.cxx
+++ b/sc/source/ui/view/drawvie4.cxx
@@ -164,9 +164,9 @@ void getRangeFromDataSource( uno::Reference< chart2::data::XDataSource > xDataSo
     }
 }
 
-void getRangeFromErrorBar(const uno::Reference< chart2::XChartDocument > xChartDoc, std::vector<OUString>& rRangeRep)
+void getRangeFromErrorBar(const uno::Reference< chart2::XChartDocument >& rChartDoc, std::vector<OUString>& rRangeRep)
 {
-    uno::Reference <chart2::XDiagram > xDiagram = xChartDoc->getFirstDiagram();
+    uno::Reference <chart2::XDiagram > xDiagram = rChartDoc->getFirstDiagram();
     if(!xDiagram.is())
         return;
 
diff --git a/xmlsecurity/source/helper/xmlsignaturehelper2.cxx b/xmlsecurity/source/helper/xmlsignaturehelper2.cxx
index 5fd84a7..64e3dea 100644
--- a/xmlsecurity/source/helper/xmlsignaturehelper2.cxx
+++ b/xmlsecurity/source/helper/xmlsignaturehelper2.cxx
@@ -32,7 +32,7 @@
 
 using namespace com::sun::star;
 
-ImplXMLSignatureListener::ImplXMLSignatureListener( const Link& rCreationResultListenerListener, const Link rVerifyResultListenerListener, const Link rStartSignatureElement )
+ImplXMLSignatureListener::ImplXMLSignatureListener(const Link& rCreationResultListenerListener, const Link& rVerifyResultListenerListener, const Link& rStartSignatureElement)
 {
     maCreationResultListenerListener = rCreationResultListenerListener;
     maVerifyResultListenerListener = rVerifyResultListenerListener;
diff --git a/xmlsecurity/source/helper/xmlsignaturehelper2.hxx b/xmlsecurity/source/helper/xmlsignaturehelper2.hxx
index e58a5fc..abe0a39 100644
--- a/xmlsecurity/source/helper/xmlsignaturehelper2.hxx
+++ b/xmlsecurity/source/helper/xmlsignaturehelper2.hxx
@@ -57,7 +57,7 @@ private:
         com::sun::star::xml::sax::XDocumentHandler > m_xNextHandler;
 
 public:
-    ImplXMLSignatureListener( const Link& rCreationResultListenerListener, const Link rVerifyResultListenerListener, const Link rStartVerifySignatureElement );
+    ImplXMLSignatureListener(const Link& rCreationResultListenerListener, const Link& rVerifyResultListenerListener, const Link& rStartVerifySignatureElement);
     virtual ~ImplXMLSignatureListener();
 
     void setNextHandler(com::sun::star::uno::Reference<


More information about the Libreoffice-commits mailing list