[Libreoffice-commits] core.git: canvas/source connectivity/source embeddedobj/source extensions/source include/connectivity include/sax include/svl include/toolkit include/vcl linguistic/source slideshow/source svl/source toolkit/source vcl/headless vcl/inc vcl/opengl vcl/quartz vcl/source vcl/unx vcl/win

Caolán McNamara caolanm at redhat.com
Mon Mar 9 13:58:51 PDT 2015


 canvas/source/directx/dx_spritehelper.cxx                              |    2 +-
 canvas/source/directx/dx_spritehelper.hxx                              |    2 +-
 canvas/source/tools/pagemanager.hxx                                    |    8 ++------
 canvas/source/tools/surfaceproxymanager.cxx                            |    4 ++--
 connectivity/source/commontools/parameters.cxx                         |    2 +-
 connectivity/source/drivers/hsqldb/HConnection.cxx                     |    2 +-
 connectivity/source/inc/resource/sharedresources.hxx                   |    2 +-
 connectivity/source/resource/sharedresources.cxx                       |    6 +++---
 embeddedobj/source/commonembedding/persistence.cxx                     |    8 ++++----
 extensions/source/update/check/updatehdl.cxx                           |    4 ++--
 include/connectivity/parameters.hxx                                    |    2 +-
 include/sax/tools/documenthandleradapter.hxx                           |    2 +-
 include/svl/numuno.hxx                                                 |    2 +-
 include/toolkit/controls/stdtabcontrollermodel.hxx                     |    2 +-
 include/vcl/seleng.hxx                                                 |    2 +-
 include/vcl/splitwin.hxx                                               |    4 ++--
 linguistic/source/dicimp.cxx                                           |    2 +-
 linguistic/source/dicimp.hxx                                           |    2 +-
 slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx |    2 +-
 svl/source/numbers/numuno.cxx                                          |    4 ++--
 toolkit/source/controls/stdtabcontrollermodel.cxx                      |    4 ++--
 vcl/headless/svpbmp.cxx                                                |    2 +-
 vcl/inc/dndevdis.hxx                                                   |    2 +-
 vcl/inc/headless/svpbmp.hxx                                            |    2 +-
 vcl/inc/opengl/salbmp.hxx                                              |    2 +-
 vcl/inc/quartz/salbmp.h                                                |    2 +-
 vcl/inc/salbmp.hxx                                                     |    2 +-
 vcl/inc/unx/salbmp.h                                                   |    2 +-
 vcl/inc/win/salbmp.h                                                   |    2 +-
 vcl/opengl/salbmp.cxx                                                  |    2 +-
 vcl/quartz/salbmp.cxx                                                  |    2 +-
 vcl/source/gdi/bitmapex.cxx                                            |    4 ++--
 vcl/source/window/dndevdis.cxx                                         |    2 +-
 vcl/source/window/splitwin.cxx                                         |    6 +++---
 vcl/unx/generic/gdi/salbmp.cxx                                         |    4 ++--
 vcl/win/source/gdi/salbmp.cxx                                          |    4 ++--
 36 files changed, 52 insertions(+), 56 deletions(-)

New commits:
commit 924b2923b8b1515a4c37079e72a2a9cc6010a4f4
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Mar 9 16:52:13 2015 +0000

    V801: Decreased performance
    
    Change-Id: I9e9a00acf9503980f0c6c7cd0a20378e5ca7390d

diff --git a/canvas/source/directx/dx_spritehelper.cxx b/canvas/source/directx/dx_spritehelper.cxx
index 481e8a4..6b45d38 100644
--- a/canvas/source/directx/dx_spritehelper.cxx
+++ b/canvas/source/directx/dx_spritehelper.cxx
@@ -54,7 +54,7 @@ namespace dxcanvas
     void SpriteHelper::init( const geometry::RealSize2D&     rSpriteSize,
                              const SpriteCanvasRef&          rSpriteCanvas,
                              const IDXRenderModuleSharedPtr& rRenderModule,
-                             const DXSurfaceBitmapSharedPtr  rBitmap,
+                             const DXSurfaceBitmapSharedPtr& rBitmap,
                              bool                            bShowSpriteBounds )
     {
         ENSURE_OR_THROW( rSpriteCanvas.get() &&
diff --git a/canvas/source/directx/dx_spritehelper.hxx b/canvas/source/directx/dx_spritehelper.hxx
index ced65e1..1cf85d7 100644
--- a/canvas/source/directx/dx_spritehelper.hxx
+++ b/canvas/source/directx/dx_spritehelper.hxx
@@ -70,7 +70,7 @@ namespace dxcanvas
         void init( const ::com::sun::star::geometry::RealSize2D&    rSpriteSize,
                    const SpriteCanvasRef&                           rSpriteCanvas,
                    const IDXRenderModuleSharedPtr&                  rRenderModule,
-                   const DXSurfaceBitmapSharedPtr                   rBitmap,
+                   const DXSurfaceBitmapSharedPtr&                  rBitmap,
                    bool                                             bShowSpriteBounds );
 
         void disposing();
diff --git a/canvas/source/tools/pagemanager.hxx b/canvas/source/tools/pagemanager.hxx
index 5e90601..06756dd 100644
--- a/canvas/source/tools/pagemanager.hxx
+++ b/canvas/source/tools/pagemanager.hxx
@@ -28,16 +28,12 @@
 
 namespace canvas
 {
-
-
     // PageManager
-
-
     class PageManager
     {
     public:
-        PageManager( const canvas::IRenderModuleSharedPtr pRenderModule ) :
-            mpRenderModule(pRenderModule)
+        PageManager(const canvas::IRenderModuleSharedPtr& rRenderModule)
+            : mpRenderModule(rRenderModule)
         {
         }
 
diff --git a/canvas/source/tools/surfaceproxymanager.cxx b/canvas/source/tools/surfaceproxymanager.cxx
index 72eb5c4..7c0ac71 100644
--- a/canvas/source/tools/surfaceproxymanager.cxx
+++ b/canvas/source/tools/surfaceproxymanager.cxx
@@ -33,8 +33,8 @@ namespace canvas
     {
     public:
 
-        SurfaceProxyManager( const IRenderModuleSharedPtr pRenderModule ) :
-            mpPageManager( new PageManager(pRenderModule) )
+        SurfaceProxyManager( const IRenderModuleSharedPtr& rRenderModule ) :
+            mpPageManager( new PageManager(rRenderModule) )
         {
         }
 
diff --git a/connectivity/source/commontools/parameters.cxx b/connectivity/source/commontools/parameters.cxx
index 25c7da5..d520e37 100644
--- a/connectivity/source/commontools/parameters.cxx
+++ b/connectivity/source/commontools/parameters.cxx
@@ -618,7 +618,7 @@ namespace dbtools
     }
 
 
-    bool ParameterManager::completeParameters( const Reference< XInteractionHandler >& _rxCompletionHandler, const Reference< XConnection > _rxConnection )
+    bool ParameterManager::completeParameters( const Reference< XInteractionHandler >& _rxCompletionHandler, const Reference< XConnection >& _rxConnection )
     {
         OSL_PRECOND( isAlive(), "ParameterManager::completeParameters: not initialized, or already disposed!" );
         OSL_ENSURE ( _rxCompletionHandler.is(), "ParameterManager::completeParameters: invalid interaction handler!" );
diff --git a/connectivity/source/drivers/hsqldb/HConnection.cxx b/connectivity/source/drivers/hsqldb/HConnection.cxx
index 836a20d..e2b618a 100644
--- a/connectivity/source/drivers/hsqldb/HConnection.cxx
+++ b/connectivity/source/drivers/hsqldb/HConnection.cxx
@@ -90,7 +90,7 @@ namespace connectivity { namespace hsqldb
         OConnectionWrapper::disposing();
     }
 
-    OHsqlConnection::OHsqlConnection( const Reference< XDriver > _rxDriver,
+    OHsqlConnection::OHsqlConnection( const Reference< XDriver >& _rxDriver,
         const Reference< XConnection >& _xConnection ,const Reference< XComponentContext >& _rxContext )
         :OHsqlConnection_BASE( m_aMutex )
         ,m_aFlushListeners( m_aMutex )
diff --git a/connectivity/source/inc/resource/sharedresources.hxx b/connectivity/source/inc/resource/sharedresources.hxx
index 76cd950..6ecd048 100644
--- a/connectivity/source/inc/resource/sharedresources.hxx
+++ b/connectivity/source/inc/resource/sharedresources.hxx
@@ -142,7 +142,7 @@ namespace connectivity
                 the string from the resource file, with applied string substitution
         */
         OUString getResourceStringWithSubstitution( ResourceId _nResId,
-                    const ::std::list< ::std::pair<const sal_Char* , OUString > > _aStringToSubstitutes) const;
+                    const ::std::list< ::std::pair<const sal_Char* , OUString > >& _rStringToSubstitutes) const;
     };
 
 
diff --git a/connectivity/source/resource/sharedresources.cxx b/connectivity/source/resource/sharedresources.cxx
index c3c0896..1275774 100644
--- a/connectivity/source/resource/sharedresources.cxx
+++ b/connectivity/source/resource/sharedresources.cxx
@@ -204,11 +204,11 @@ namespace connectivity
     }
 
     OUString SharedResources::getResourceStringWithSubstitution( ResourceId _nResId,
-                    const ::std::list< ::std::pair<const sal_Char* , OUString > > _aStringToSubstitutes) const
+                    const ::std::list< ::std::pair<const sal_Char* , OUString > >& _rStringToSubstitutes) const
     {
         OUString sString( SharedResources_Impl::getInstance().getResourceString( _nResId ) );
-        ::std::list< ::std::pair<const sal_Char* , OUString > >::const_iterator aIter = _aStringToSubstitutes.begin();
-        ::std::list< ::std::pair<const sal_Char* , OUString > >::const_iterator aEnd  = _aStringToSubstitutes.end();
+        ::std::list< ::std::pair<const sal_Char* , OUString > >::const_iterator aIter = _rStringToSubstitutes.begin();
+        ::std::list< ::std::pair<const sal_Char* , OUString > >::const_iterator aEnd  = _rStringToSubstitutes.end();
         for(;aIter != aEnd; ++aIter)
             OSL_VERIFY( lcl_substitute( sString, aIter->first, aIter->second ) );
 
diff --git a/embeddedobj/source/commonembedding/persistence.cxx b/embeddedobj/source/commonembedding/persistence.cxx
index 9ac7dd2..4f1adda 100644
--- a/embeddedobj/source/commonembedding/persistence.cxx
+++ b/embeddedobj/source/commonembedding/persistence.cxx
@@ -217,20 +217,20 @@ static uno::Reference< util::XCloseable > CreateDocument( const uno::Reference<
 }
 
 
-static void SetDocToEmbedded( const uno::Reference< frame::XModel > xDocument, const OUString& aModuleName )
+static void SetDocToEmbedded( const uno::Reference< frame::XModel >& rDocument, const OUString& aModuleName )
 {
-    if ( xDocument.is() )
+    if (rDocument.is())
     {
         uno::Sequence< beans::PropertyValue > aSeq( 1 );
         aSeq[0].Name = "SetEmbedded";
         aSeq[0].Value <<= sal_True;
-        xDocument->attachResource( OUString(), aSeq );
+        rDocument->attachResource( OUString(), aSeq );
 
         if ( !aModuleName.isEmpty() )
         {
             try
             {
-                uno::Reference< frame::XModule > xModule( xDocument, uno::UNO_QUERY_THROW );
+                uno::Reference< frame::XModule > xModule( rDocument, uno::UNO_QUERY_THROW );
                 xModule->setIdentifier( aModuleName );
             }
             catch( const uno::Exception& )
diff --git a/extensions/source/update/check/updatehdl.cxx b/extensions/source/update/check/updatehdl.cxx
index 6bc0b3a..9e69e82 100644
--- a/extensions/source/update/check/updatehdl.cxx
+++ b/extensions/source/update/check/updatehdl.cxx
@@ -606,7 +606,7 @@ void UpdateHandler::updateState( UpdateState eState )
 }
 
 
-OUString UpdateHandler::loadString( const uno::Reference< resource::XResourceBundle > xBundle,
+OUString UpdateHandler::loadString( const uno::Reference< resource::XResourceBundle >& rBundle,
                                          sal_Int32 nResourceId ) const
 {
     OUString sString;
@@ -614,7 +614,7 @@ OUString UpdateHandler::loadString( const uno::Reference< resource::XResourceBun
 
     try
     {
-        OSL_VERIFY( xBundle->getByName( sKey ) >>= sString );
+        OSL_VERIFY( rBundle->getByName( sKey ) >>= sString );
     }
     catch( const uno::Exception& )
     {
diff --git a/include/connectivity/parameters.hxx b/include/connectivity/parameters.hxx
index 9af2b77..c1f8390 100644
--- a/include/connectivity/parameters.hxx
+++ b/include/connectivity/parameters.hxx
@@ -349,7 +349,7 @@ namespace dbtools
         */
         bool    completeParameters(
                     const ::com::sun::star::uno::Reference< ::com::sun::star::task::XInteractionHandler >& _rxCompletionHandler,
-                    const ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XConnection > _rxConnection
+                    const ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XConnection >& _rxConnection
                 );
 
         /** asks the parameter listeners to fill in final values
diff --git a/include/sax/tools/documenthandleradapter.hxx b/include/sax/tools/documenthandleradapter.hxx
index bba7c97..aedb236 100644
--- a/include/sax/tools/documenthandleradapter.hxx
+++ b/include/sax/tools/documenthandleradapter.hxx
@@ -205,7 +205,7 @@ namespace sax
         {
         }
         ExtendedDocumentHandlerAdapter(
-                const ::com::sun::star::uno::Reference< ::com::sun::star::xml::sax::XExtendedDocumentHandler > delegate) :
+                const ::com::sun::star::uno::Reference< ::com::sun::star::xml::sax::XExtendedDocumentHandler >& delegate) :
             m_handler(delegate)
         {
         }
diff --git a/include/svl/numuno.hxx b/include/svl/numuno.hxx
index 8a3f7ab..d358f77 100644
--- a/include/svl/numuno.hxx
+++ b/include/svl/numuno.hxx
@@ -82,7 +82,7 @@ public:
 
     static const com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId();
     static SvNumberFormatsSupplierObj* getImplementation( const com::sun::star::uno::Reference<
-                                    com::sun::star::util::XNumberFormatsSupplier> xObj );
+                                    com::sun::star::util::XNumberFormatsSupplier>& rObj );
 
     ::comphelper::SharedMutex&  getSharedMutex() const;
 };
diff --git a/include/toolkit/controls/stdtabcontrollermodel.hxx b/include/toolkit/controls/stdtabcontrollermodel.hxx
index 6dab218..f03ae4e 100644
--- a/include/toolkit/controls/stdtabcontrollermodel.hxx
+++ b/include/toolkit/controls/stdtabcontrollermodel.hxx
@@ -95,7 +95,7 @@ protected:
     sal_uInt32              ImplGetControlCount( const UnoControlModelEntryList& rList ) const;
     void                    ImplGetControlModels( ::com::sun::star::uno::Reference< ::com::sun::star::awt::XControlModel > ** pRefs, const UnoControlModelEntryList& rList ) const;
     void                    ImplSetControlModels( UnoControlModelEntryList& rList, const ::com::sun::star::uno::Sequence< ::com::sun::star::uno::Reference< ::com::sun::star::awt::XControlModel > >& Controls ) const;
-    sal_uInt32              ImplGetControlPos( const ::com::sun::star::uno::Reference< ::com::sun::star::awt::XControlModel >  xCtrl, const UnoControlModelEntryList& rList ) const;
+    sal_uInt32              ImplGetControlPos( const ::com::sun::star::uno::Reference< ::com::sun::star::awt::XControlModel >& rCtrl, const UnoControlModelEntryList& rList ) const;
 
 public:
                             StdTabControllerModel();
diff --git a/include/vcl/seleng.hxx b/include/vcl/seleng.hxx
index 141a686..cbfd9c3 100644
--- a/include/vcl/seleng.hxx
+++ b/include/vcl/seleng.hxx
@@ -119,7 +119,7 @@ public:
 
     // is needed to generate a Move event via a Timer
     // when the mouse is outside the area
-    void                SetVisibleArea( const Rectangle rNewArea )
+    void                SetVisibleArea( const Rectangle& rNewArea )
                             { aArea = rNewArea; }
     const Rectangle&    GetVisibleArea() const { return aArea; }
 
diff --git a/include/vcl/splitwin.hxx b/include/vcl/splitwin.hxx
index 715b083..157f0c2 100644
--- a/include/vcl/splitwin.hxx
+++ b/include/vcl/splitwin.hxx
@@ -161,11 +161,11 @@ public:
         upper and a lower bound (both are valid values themselves.)
         @param nId
             Id of the item for which the size limits are set.
-        @param aRange
+        @param rRange
             Values of -1 define missing bounds, thus setting a range (-1,-1)
             (the default) removes the size limitiation.
     */
-    void                SetItemSizeRange (sal_uInt16 nId, const Range aRange);
+    void                SetItemSizeRange (sal_uInt16 nId, const Range& rRange);
     /** Return the current size limits for the specified item.
     */
     long                GetItemSize( sal_uInt16 nId, SplitWindowItemBits nBits ) const;
diff --git a/linguistic/source/dicimp.cxx b/linguistic/source/dicimp.cxx
index bdc8dd9..07ce3eb 100644
--- a/linguistic/source/dicimp.cxx
+++ b/linguistic/source/dicimp.cxx
@@ -682,7 +682,7 @@ bool DictionaryNeo::isSorted()
     return bRes;
 }
 
-bool DictionaryNeo::addEntry_Impl(const uno::Reference< XDictionaryEntry > xDicEntry,
+bool DictionaryNeo::addEntry_Impl(const uno::Reference< XDictionaryEntry >& xDicEntry,
         bool bIsLoadEntries)
 {
     MutexGuard  aGuard( GetLinguMutex() );
diff --git a/linguistic/source/dicimp.hxx b/linguistic/source/dicimp.hxx
index 29b1ecb..fc6647c 100644
--- a/linguistic/source/dicimp.hxx
+++ b/linguistic/source/dicimp.hxx
@@ -76,7 +76,7 @@ class DictionaryNeo :
     bool                        isSorted();
 
     bool                    addEntry_Impl(const ::com::sun::star::uno::Reference<
-        ::com::sun::star::linguistic2::XDictionaryEntry > xDicEntry,
+        ::com::sun::star::linguistic2::XDictionaryEntry >& rDicEntry,
                                           bool bIsLoadEntries = false);
 
 public:
diff --git a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx
index 6d2e668..cfaff62 100644
--- a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx
+++ b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx
@@ -552,7 +552,7 @@ void OGLTransitionerImpl::impl_finishTransition()
         mpTransition->finish();
 }
 
-void OGLTransitionerImpl::setTransition( boost::shared_ptr<OGLTransitionImpl> const pTransition )
+void OGLTransitionerImpl::setTransition( boost::shared_ptr<OGLTransitionImpl> pTransition )
 {
     if ( mpTransition ) // already initialized
         return;
diff --git a/svl/source/numbers/numuno.cxx b/svl/source/numbers/numuno.cxx
index 931e5718..0ad66dc 100644
--- a/svl/source/numbers/numuno.cxx
+++ b/svl/source/numbers/numuno.cxx
@@ -125,10 +125,10 @@ const uno::Sequence<sal_Int8>& SvNumberFormatsSupplierObj::getUnoTunnelId()
 
 // static
 SvNumberFormatsSupplierObj* SvNumberFormatsSupplierObj::getImplementation(
-                                const uno::Reference<util::XNumberFormatsSupplier> xObj )
+                                const uno::Reference<util::XNumberFormatsSupplier>& rObj )
 {
     SvNumberFormatsSupplierObj* pRet = NULL;
-    uno::Reference<lang::XUnoTunnel> xUT( xObj, uno::UNO_QUERY );
+    uno::Reference<lang::XUnoTunnel> xUT(rObj, uno::UNO_QUERY);
     if (xUT.is())
         pRet = reinterpret_cast<SvNumberFormatsSupplierObj*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething( getUnoTunnelId() )));
     return pRet;
diff --git a/toolkit/source/controls/stdtabcontrollermodel.cxx b/toolkit/source/controls/stdtabcontrollermodel.cxx
index 1ea8acc..8bac30c 100644
--- a/toolkit/source/controls/stdtabcontrollermodel.cxx
+++ b/toolkit/source/controls/stdtabcontrollermodel.cxx
@@ -144,12 +144,12 @@ void StdTabControllerModel::ImplSetControlModels( UnoControlModelEntryList& rLis
     }
 }
 
-sal_uInt32 StdTabControllerModel::ImplGetControlPos( const ::com::sun::star::uno::Reference< ::com::sun::star::awt::XControlModel >  xCtrl, const UnoControlModelEntryList& rList ) const
+sal_uInt32 StdTabControllerModel::ImplGetControlPos( const ::com::sun::star::uno::Reference< ::com::sun::star::awt::XControlModel >& rCtrl, const UnoControlModelEntryList& rList ) const
 {
     for ( size_t n = rList.size(); n; )
     {
         UnoControlModelEntry* pEntry = rList[ --n ];
-        if ( !pEntry->bGroup && ( *pEntry->pxControl == xCtrl ) )
+        if ( !pEntry->bGroup && ( *pEntry->pxControl == rCtrl ) )
             return n;
     }
     return CONTROLPOS_NOTFOUND;
diff --git a/vcl/headless/svpbmp.cxx b/vcl/headless/svpbmp.cxx
index d9da88b..23dae7e 100644
--- a/vcl/headless/svpbmp.cxx
+++ b/vcl/headless/svpbmp.cxx
@@ -104,7 +104,7 @@ bool SvpSalBitmap::Create( const SalBitmap& /*rSalBmp*/,
     return false;
 }
 
-bool SvpSalBitmap::Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas > /*xBitmapCanvas*/, Size& /*rSize*/, bool /*bMask*/ )
+bool SvpSalBitmap::Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas >& /*xBitmapCanvas*/, Size& /*rSize*/, bool /*bMask*/ )
 {
     return false;
 }
diff --git a/vcl/inc/dndevdis.hxx b/vcl/inc/dndevdis.hxx
index 2f356c7..60b6bb3 100644
--- a/vcl/inc/dndevdis.hxx
+++ b/vcl/inc/dndevdis.hxx
@@ -63,7 +63,7 @@ class DNDEventDispatcher: public ::cppu::WeakImplHelper3<
         const ::com::sun::star::uno::Reference< ::com::sun::star::datatransfer::XTransferable >& xTransferable ) throw(::com::sun::star::uno::RuntimeException);
 
     sal_Int32 fireDragGestureEvent( vcl::Window *pWindow, const ::com::sun::star::uno::Reference< ::com::sun::star::datatransfer::dnd::XDragSource >& xSource,
-        const ::com::sun::star::uno::Any event, const Point& rOrigin, const sal_Int8 nDragAction )throw(::com::sun::star::uno::RuntimeException);
+        const ::com::sun::star::uno::Any& event, const Point& rOrigin, const sal_Int8 nDragAction )throw(::com::sun::star::uno::RuntimeException);
 
 public:
 
diff --git a/vcl/inc/headless/svpbmp.hxx b/vcl/inc/headless/svpbmp.hxx
index 6a80c7c..b0fc076 100644
--- a/vcl/inc/headless/svpbmp.hxx
+++ b/vcl/inc/headless/svpbmp.hxx
@@ -48,7 +48,7 @@ public:
                                     SalGraphics* pGraphics ) SAL_OVERRIDE;
     virtual bool            Create( const SalBitmap& rSalBmp,
                                     sal_uInt16 nNewBitCount ) SAL_OVERRIDE;
-    virtual bool            Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas > xBitmapCanvas,
+    virtual bool            Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas >& rBitmapCanvas,
                                     Size& rSize,
                                     bool bMask = false ) SAL_OVERRIDE;
     virtual void            Destroy() SAL_OVERRIDE;
diff --git a/vcl/inc/opengl/salbmp.hxx b/vcl/inc/opengl/salbmp.hxx
index 84c64ed..e7b3052 100644
--- a/vcl/inc/opengl/salbmp.hxx
+++ b/vcl/inc/opengl/salbmp.hxx
@@ -65,7 +65,7 @@ public:
     bool            Create( const SalBitmap& rSalBmp ) SAL_OVERRIDE;
     bool            Create( const SalBitmap& rSalBmp, SalGraphics* pGraphics ) SAL_OVERRIDE;
     bool            Create( const SalBitmap& rSalBmp, sal_uInt16 nNewBitCount ) SAL_OVERRIDE;
-    virtual bool    Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas > xBitmapCanvas,
+    virtual bool    Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas >& rBitmapCanvas,
                             Size& rSize,
                             bool bMask = false ) SAL_OVERRIDE;
 
diff --git a/vcl/inc/quartz/salbmp.h b/vcl/inc/quartz/salbmp.h
index 1be7b0d..9c2209d 100644
--- a/vcl/inc/quartz/salbmp.h
+++ b/vcl/inc/quartz/salbmp.h
@@ -61,7 +61,7 @@ public:
     bool            Create( const SalBitmap& rSalBmp ) SAL_OVERRIDE;
     bool            Create( const SalBitmap& rSalBmp, SalGraphics* pGraphics ) SAL_OVERRIDE;
     bool            Create( const SalBitmap& rSalBmp, sal_uInt16 nNewBitCount ) SAL_OVERRIDE;
-    virtual bool    Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas > xBitmapCanvas,
+    virtual bool    Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas >& rBitmapCanvas,
                             Size& rSize,
                             bool bMask = false ) SAL_OVERRIDE;
 
diff --git a/vcl/inc/salbmp.hxx b/vcl/inc/salbmp.hxx
index b450594..432c4df 100644
--- a/vcl/inc/salbmp.hxx
+++ b/vcl/inc/salbmp.hxx
@@ -47,7 +47,7 @@ public:
                                     SalGraphics* pGraphics ) = 0;
     virtual bool            Create( const SalBitmap& rSalBmp,
                                     sal_uInt16 nNewBitCount ) = 0;
-    virtual bool            Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas > xBitmapCanvas,
+    virtual bool            Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas >& rBitmapCanvas,
                                     Size& rSize,
                                     bool bMask = false ) = 0;
     virtual void            Destroy() = 0;
diff --git a/vcl/inc/unx/salbmp.h b/vcl/inc/unx/salbmp.h
index 0403b5a..0dc5b36 100644
--- a/vcl/inc/unx/salbmp.h
+++ b/vcl/inc/unx/salbmp.h
@@ -132,7 +132,7 @@ public:
     virtual bool                Create(
                                     const ::com::sun::star::uno::Reference<
                                         ::com::sun::star::rendering::XBitmapCanvas
-                                    > xBitmapCanvas,
+                                    >& rBitmapCanvas,
                                     Size& rSize,
                                     bool bMask = false
                                 ) SAL_OVERRIDE;
diff --git a/vcl/inc/win/salbmp.h b/vcl/inc/win/salbmp.h
index d473469..b7d6622 100644
--- a/vcl/inc/win/salbmp.h
+++ b/vcl/inc/win/salbmp.h
@@ -84,7 +84,7 @@ public:
     virtual bool                Create( const SalBitmap& rSalBmpImpl ) SAL_OVERRIDE;
     virtual bool                Create( const SalBitmap& rSalBmpImpl, SalGraphics* pGraphics ) SAL_OVERRIDE;
     virtual bool                Create( const SalBitmap& rSalBmpImpl, sal_uInt16 nNewBitCount ) SAL_OVERRIDE;
-    virtual bool                Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas > xBitmapCanvas,
+    virtual bool                Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas >& rBitmapCanvas,
                                            Size& rSize,
                                            bool bMask = false ) SAL_OVERRIDE;
 
diff --git a/vcl/opengl/salbmp.cxx b/vcl/opengl/salbmp.cxx
index bc94939..3b60843 100644
--- a/vcl/opengl/salbmp.cxx
+++ b/vcl/opengl/salbmp.cxx
@@ -133,7 +133,7 @@ bool OpenGLSalBitmap::Create( const SalBitmap& rSalBmp, sal_uInt16 nNewBitCount
     return false;
 }
 
-bool OpenGLSalBitmap::Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas > /*xBitmapCanvas*/, Size& /*rSize*/, bool /*bMask*/ )
+bool OpenGLSalBitmap::Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas >& /*xBitmapCanvas*/, Size& /*rSize*/, bool /*bMask*/ )
 {
     // TODO Is this method needed?
     return false;
diff --git a/vcl/quartz/salbmp.cxx b/vcl/quartz/salbmp.cxx
index 1de8195..fd0fe7d 100644
--- a/vcl/quartz/salbmp.cxx
+++ b/vcl/quartz/salbmp.cxx
@@ -184,7 +184,7 @@ bool QuartzSalBitmap::Create( const SalBitmap& rSalBmp, sal_uInt16 nNewBitCount
     return false;
 }
 
-bool QuartzSalBitmap::Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas > /*xBitmapCanvas*/, Size& /*rSize*/, bool /*bMask*/ )
+bool QuartzSalBitmap::Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas >& /*xBitmapCanvas*/, Size& /*rSize*/, bool /*bMask*/ )
 {
     return false;
 }
diff --git a/vcl/source/gdi/bitmapex.cxx b/vcl/source/gdi/bitmapex.cxx
index a95466d..6d35ec6 100644
--- a/vcl/source/gdi/bitmapex.cxx
+++ b/vcl/source/gdi/bitmapex.cxx
@@ -839,11 +839,11 @@ namespace
 {
     Bitmap impTransformBitmap(
         const Bitmap& rSource,
-        const Size aDestinationSize,
+        const Size& rDestinationSize,
         const basegfx::B2DHomMatrix& rTransform,
         bool bSmooth)
     {
-        Bitmap aDestination(aDestinationSize, 24);
+        Bitmap aDestination(rDestinationSize, 24);
         std::unique_ptr<BitmapWriteAccess> xWrite(aDestination.AcquireWriteAccess());
 
         if(xWrite)
diff --git a/vcl/source/window/dndevdis.cxx b/vcl/source/window/dndevdis.cxx
index f422a9d..7ccaa99 100644
--- a/vcl/source/window/dndevdis.cxx
+++ b/vcl/source/window/dndevdis.cxx
@@ -442,7 +442,7 @@ sal_Int32 DNDEventDispatcher::fireDropEvent( vcl::Window *pWindow,
 // DNDEventDispatcher::fireDragGestureRecognized
 
 sal_Int32 DNDEventDispatcher::fireDragGestureEvent( vcl::Window *pWindow,
-    const Reference< XDragSource >& xSource, const Any event,
+    const Reference< XDragSource >& xSource, const Any& event,
     const Point& rOrigin, const sal_Int8 nDragAction
 )
     throw(::com::sun::star::uno::RuntimeException)
diff --git a/vcl/source/window/splitwin.cxx b/vcl/source/window/splitwin.cxx
index 3dd3e8c..c777f37 100644
--- a/vcl/source/window/splitwin.cxx
+++ b/vcl/source/window/splitwin.cxx
@@ -3095,15 +3095,15 @@ long SplitWindow::GetItemSize( sal_uInt16 nId, SplitWindowItemBits nBits ) const
         return 0;
 }
 
-void SplitWindow::SetItemSizeRange (sal_uInt16 nId, const Range aRange)
+void SplitWindow::SetItemSizeRange (sal_uInt16 nId, const Range& rRange)
 {
     sal_uInt16 nPos;
     ImplSplitSet* pSet = ImplFindItem(mpBaseSet, nId, nPos);
 
     if (pSet != NULL)
     {
-        pSet->mpItems[nPos].mnMinSize = aRange.Min();
-        pSet->mpItems[nPos].mnMaxSize = aRange.Max();
+        pSet->mpItems[nPos].mnMinSize = rRange.Min();
+        pSet->mpItems[nPos].mnMaxSize = rRange.Max();
     }
 }
 
diff --git a/vcl/unx/generic/gdi/salbmp.cxx b/vcl/unx/generic/gdi/salbmp.cxx
index 45f0a9c..f301148 100644
--- a/vcl/unx/generic/gdi/salbmp.cxx
+++ b/vcl/unx/generic/gdi/salbmp.cxx
@@ -735,12 +735,12 @@ bool X11SalBitmap::Create( const SalBitmap&, sal_uInt16 )
 }
 
 bool X11SalBitmap::Create(
-    const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas > xBitmapCanvas,
+    const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas >& rBitmapCanvas,
     Size& rSize,
     bool bMask
 ) {
     ::com::sun::star::uno::Reference< ::com::sun::star::beans::XFastPropertySet >
-        xFastPropertySet( xBitmapCanvas, ::com::sun::star::uno::UNO_QUERY );
+        xFastPropertySet( rBitmapCanvas, ::com::sun::star::uno::UNO_QUERY );
 
     if( xFastPropertySet.get() ) {
         sal_Int32 depth;
diff --git a/vcl/win/source/gdi/salbmp.cxx b/vcl/win/source/gdi/salbmp.cxx
index 28764cd..8c81baa 100644
--- a/vcl/win/source/gdi/salbmp.cxx
+++ b/vcl/win/source/gdi/salbmp.cxx
@@ -689,10 +689,10 @@ bool WinSalBitmap::Create( const SalBitmap& rSSalBmp, sal_uInt16 nNewBitCount )
     return bRet;
 }
 
-bool WinSalBitmap::Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas > xBitmapCanvas, Size& /*rSize*/, bool bMask )
+bool WinSalBitmap::Create( const ::com::sun::star::uno::Reference< ::com::sun::star::rendering::XBitmapCanvas >& xBitmapCanvas, Size& /*rSize*/, bool bMask )
 {
     ::com::sun::star::uno::Reference< ::com::sun::star::beans::XFastPropertySet >
-        xFastPropertySet( xBitmapCanvas, ::com::sun::star::uno::UNO_QUERY );
+        xFastPropertySet( rBitmapCanvas, ::com::sun::star::uno::UNO_QUERY );
 
     if( xFastPropertySet.get() ) {
         ::com::sun::star::uno::Sequence< ::com::sun::star::uno::Any > args;


More information about the Libreoffice-commits mailing list