[Libreoffice-commits] core.git: sd/source

Zolnai Tamás zolnaitamas2000 at gmail.com
Thu Mar 19 23:25:41 PDT 2015


 sd/source/ui/dlg/tabtempl.cxx |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 3640717c8153e8b8e212e3aaa505007f7b8b0430
Author: Zolnai Tamás <zolnaitamas2000 at gmail.com>
Date:   Fri Mar 20 07:21:27 2015 +0100

    coverity#1288897 Resource leak
    
    Here pRet was used to change the input set, so
    use SetInputSet to get the same result.
    Plus rename pRet since it's not a return value
    any more.
    
    Change-Id: I9e75abe2a86b372beb6fe5bd211dcf4fbbefb3da

diff --git a/sd/source/ui/dlg/tabtempl.cxx b/sd/source/ui/dlg/tabtempl.cxx
index a213c38..e2e7613 100644
--- a/sd/source/ui/dlg/tabtempl.cxx
+++ b/sd/source/ui/dlg/tabtempl.cxx
@@ -174,15 +174,15 @@ void SdTabTemplateDlg::PageCreated( sal_uInt16 nId, SfxTabPage &rPage )
 
 void SdTabTemplateDlg::RefreshInputSet()
 {
-    SfxItemSet* pRet = GetInputSetImpl();
+    SfxItemSet* pInputSet = GetInputSetImpl();
 
-    if( pRet )
+    if( pInputSet )
     {
-        pRet->ClearItem();
-        pRet->SetParent( GetStyleSheet().GetItemSet().GetParent() );
+        pInputSet->ClearItem();
+        pInputSet->SetParent( GetStyleSheet().GetItemSet().GetParent() );
     }
     else
-        pRet = new SfxItemSet( GetStyleSheet().GetItemSet() );
+        SetInputSet(&GetStyleSheet().GetItemSet());
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


More information about the Libreoffice-commits mailing list