[Libreoffice-commits] core.git: oox/source sc/source

Austin Chen austinchenyw at gmail.com
Wed Mar 25 23:47:09 PDT 2015


 oox/source/drawingml/chart/chartconverter.cxx |    2 +-
 sc/source/filter/oox/formulabase.cxx          |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 0fb66458c08b9c0ce59bca85e77d26fad8b59e4b
Author: Austin Chen <austinchenyw at gmail.com>
Date:   Wed Mar 25 02:43:57 2015 -0700

    tdf#57950: Replace chained O(U)StringBuffer::append() with operator+
    
    Change-Id: Iae8e50864dbd90ff49a4fcc31a06b2158eab4afc
    Reviewed-on: https://gerrit.libreoffice.org/14998
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
    Tested-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/oox/source/drawingml/chart/chartconverter.cxx b/oox/source/drawingml/chart/chartconverter.cxx
index b39ca70..acbe9bb 100644
--- a/oox/source/drawingml/chart/chartconverter.cxx
+++ b/oox/source/drawingml/chart/chartconverter.cxx
@@ -54,7 +54,7 @@ static OUString lclGenerateApiString( const OUString& rString )
     sal_Int32 nQuotePos = aRetString.getLength();
     while( (nQuotePos = aRetString.lastIndexOf( '"', nQuotePos )) >= 0 )
         aRetString = aRetString.replaceAt( nQuotePos, 1, "\"\"" );
-    return OUStringBuffer().append( '"' ).append( aRetString ).append( '"' ).makeStringAndClear();
+    return "\"" + aRetString + "\"";
 }
 
 static OUString lclGenerateApiArray( const Matrix< Any >& rMatrix )
diff --git a/sc/source/filter/oox/formulabase.cxx b/sc/source/filter/oox/formulabase.cxx
index e1237b7..38f0ef2 100644
--- a/sc/source/filter/oox/formulabase.cxx
+++ b/sc/source/filter/oox/formulabase.cxx
@@ -1624,7 +1624,7 @@ OUString FormulaProcessorBase::generateApiString( const OUString& rString )
     sal_Int32 nQuotePos = aRetString.getLength();
     while( (nQuotePos = aRetString.lastIndexOf( '"', nQuotePos )) >= 0 )
         aRetString = aRetString.replaceAt( nQuotePos, 1, OUString( "\"\"" ) );
-    return OUStringBuffer().append( '"' ).append( aRetString ).append( '"' ).makeStringAndClear();
+    return "\"" + aRetString + "\"";
 }
 
 OUString FormulaProcessorBase::generateApiArray( const Matrix< Any >& rMatrix )


More information about the Libreoffice-commits mailing list