[Libreoffice-commits] core.git: 2 commits - connectivity/source sw/source

[Caolán McNamara]

 connectivity/source/drivers/jdbc/tools.cxx       |   11 -----------
 sw/source/core/doc/DocumentStatisticsManager.cxx |    2 +-
 sw/source/core/doc/swstylemanager.cxx            |    2 +-
 sw/source/core/doc/tblafmt.cxx                   |    2 +-
 sw/source/core/doc/tblcpy.cxx                    |    2 +-
 5 files changed, 4 insertions(+), 15 deletions(-)

New commits:
commit ab30dbe70504213ae318baa88bf81e6eda99a429
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon May 4 12:00:41 2015 +0100

    drop useless temp debugging strings
    
    Change-Id: I41c7053296c634c0fed5b31f2e080c3eaf59bbba

diff --git a/connectivity/source/drivers/jdbc/tools.cxx b/connectivity/source/drivers/jdbc/tools.cxx
index ee21f07..7ed32d4 100644
--- a/connectivity/source/drivers/jdbc/tools.cxx
+++ b/connectivity/source/drivers/jdbc/tools.cxx
@@ -194,18 +194,7 @@ bool connectivity::isExceptionOccurred(JNIEnv *pEnv,bool _bClear)
     {
         if ( _bClear )
             pEnv->ExceptionClear();
-#if OSL_DEBUG_LEVEL > 1
-        if(pEnv->IsInstanceOf(pThrowable,java_sql_SQLException_BASE::st_getMyClass()))
-        {
-
-            java_sql_SQLException_BASE* pException = new java_sql_SQLException_BASE(pEnv,pThrowable);
-            OUString sError = pException->getMessage();
-            delete pException;
-        }
-#else
         pEnv->DeleteLocalRef(pThrowable);
-#endif
-
     }
 
     return bRet;
commit 3761cf7660e8329670722973c567235bffe40536
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sun May 3 21:01:56 2015 +0100

    cppcheck: noExplicitConstructor
    
    Change-Id: I1f5272cdf05b36d1c6958159a29c04ed7374592d

diff --git a/sw/source/core/doc/DocumentStatisticsManager.cxx b/sw/source/core/doc/DocumentStatisticsManager.cxx
index 908abb4..8677456 100644
--- a/sw/source/core/doc/DocumentStatisticsManager.cxx
+++ b/sw/source/core/doc/DocumentStatisticsManager.cxx
@@ -44,7 +44,7 @@ namespace
         std::vector<SwViewShell*> m_aViewWasUnLocked;
         SwViewShell* m_pViewShell;
     public:
-        LockAllViews(SwViewShell *pViewShell)
+        explicit LockAllViews(SwViewShell *pViewShell)
             : m_pViewShell(pViewShell)
         {
             if (!m_pViewShell)
diff --git a/sw/source/core/doc/swstylemanager.cxx b/sw/source/core/doc/swstylemanager.cxx
index af8e6d2..11d3b3b 100644
--- a/sw/source/core/doc/swstylemanager.cxx
+++ b/sw/source/core/doc/swstylemanager.cxx
@@ -64,7 +64,7 @@ class SwStyleManager : public IStyleAccess
 
 public:
     // accept empty item set for ignorable paragraph items.
-    SwStyleManager( SfxItemSet* pIgnorableParagraphItems )
+    explicit SwStyleManager( SfxItemSet* pIgnorableParagraphItems )
         : aAutoCharPool(),
           aAutoParaPool( pIgnorableParagraphItems ),
           mpCharCache(0),
diff --git a/sw/source/core/doc/tblafmt.cxx b/sw/source/core/doc/tblafmt.cxx
index 66bc940..f3a732c 100644
--- a/sw/source/core/doc/tblafmt.cxx
+++ b/sw/source/core/doc/tblafmt.cxx
@@ -128,7 +128,7 @@ namespace
     class WriterSpecificAutoFormatBlock : ::boost::noncopyable
     {
     public:
-        WriterSpecificAutoFormatBlock(SvStream &rStream) : _rStream(rStream)
+        explicit WriterSpecificAutoFormatBlock(SvStream &rStream) : _rStream(rStream)
         {
             _whereToWriteEndOfBlock = BeginSwBlock(rStream);
         }
diff --git a/sw/source/core/doc/tblcpy.cxx b/sw/source/core/doc/tblcpy.cxx
index d4b39c2..8dbd572 100644
--- a/sw/source/core/doc/tblcpy.cxx
+++ b/sw/source/core/doc/tblcpy.cxx
@@ -91,7 +91,7 @@ namespace
                      sal_uLong &rnB, sal_uInt16 &rnC, ColumnStructure::iterator& rpCl,
                      BoxStructure::iterator& rpSel, bool &rbSel, bool bCover );
         void incColSpan( sal_uInt16 nLine, sal_uInt16 nCol );
-        TableStructure( const SwTable& rTable );
+        explicit TableStructure( const SwTable& rTable );
         TableStructure( const SwTable& rTable, _FndBox &rFndBox,
                         const SwSelBoxes& rSelBoxes,
                         LineStructure::size_type nMinSize );