[Libreoffice-commits] core.git: 2 commits - basctl/source sc/source

Caolán McNamara caolanm at redhat.com
Wed May 20 01:10:00 PDT 2015


 basctl/source/basicide/basobj3.cxx |    2 +-
 sc/source/ui/miscdlgs/autofmt.cxx  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 3dd259ffa1607fa91d598954b07f9ac8e5c0b08a
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue May 19 21:33:25 2015 +0100

    coverity#1298898 coverity seems a little confused here
    
    Change-Id: Ibc80e242b8fda8fb304ed5cd1a52716d1b7fc33d

diff --git a/basctl/source/basicide/basobj3.cxx b/basctl/source/basicide/basobj3.cxx
index dd700b1..7de0ab3 100644
--- a/basctl/source/basicide/basobj3.cxx
+++ b/basctl/source/basicide/basobj3.cxx
@@ -180,7 +180,7 @@ bool RenameDialog (
     if ( !rDocument.renameDialog( rLibName, rOldName, rNewName, xExistingDialog ) )
         return false;
 
-    if ( pWin )
+    if (pWin && pShell)
     {
         // set new name in window
         pWin->SetName( rNewName );
commit 65f9d502d88e832e8b8af71b7be8f706519f7162
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue May 19 21:31:48 2015 +0100

    tweak to try and silence coverity
    
    Change-Id: I990ad07784266e2b48638ece6a84471b3bef173a

diff --git a/sc/source/ui/miscdlgs/autofmt.cxx b/sc/source/ui/miscdlgs/autofmt.cxx
index e8b3a69..1854318 100644
--- a/sc/source/ui/miscdlgs/autofmt.cxx
+++ b/sc/source/ui/miscdlgs/autofmt.cxx
@@ -330,7 +330,7 @@ void ScAutoFmtPreview::DrawString(vcl::RenderContext& rRenderContext, size_t nCo
                 case SVX_HOR_JUSTIFY_CENTER:
                     aPos.X() += nHorPos;
                     break;
-                // coverity[dead_error_begin] - following conditions exist to avoid compiler warning
+                // coverity[dead_error_line] - following conditions exist to avoid compiler warning
                 case SVX_HOR_JUSTIFY_STANDARD:
                 default:
                     // Standard is not handled here


More information about the Libreoffice-commits mailing list