[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sw/source

[Mark Hung]

 sw/source/core/doc/DocumentRedlineManager.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5b63043dbc12476ad1c1e69558b53d9493c855f1
Author: Mark Hung <marklh9 at gmail.com>
Date:   Wed Mar 25 23:17:11 2015 +0800

    Fix DocumentRedlineManager code that crashes Writer.
    
    One of my document crashes Writer when I delete one table row, with
    change tracking enabled. I observed that in DeleteRedline(),
    either Start or End of the SwRangeRedline object has been changed
    so that it breaks the order of SwRedlineTable.
    
    Change-Id: I6e477488a894996dea4efb433eb3e03edf5fd26d
    Reviewed-on: https://gerrit.libreoffice.org/15002
    Tested-by: Caolán McNamara <caolanm at redhat.com>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    (cherry picked from commit 77cb94613be6315b618783b2aa76226ad3107163)
    Reviewed-on: https://gerrit.libreoffice.org/15820
    Reviewed-by: Michael Stahl <mstahl at redhat.com>
    Tested-by: Michael Stahl <mstahl at redhat.com>

diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx b/sw/source/core/doc/DocumentRedlineManager.cxx
index 873b4d6..3da01cc 100644
--- a/sw/source/core/doc/DocumentRedlineManager.cxx
+++ b/sw/source/core/doc/DocumentRedlineManager.cxx
@@ -1971,7 +1971,7 @@ bool DocumentRedlineManager::DeleteRedline( const SwPaM& rRange, bool bSaveInUnd
                     if( !pRedl->HasValidRange() )
                     {
                         // re-insert
-                        mpRedlineTbl->Remove( pRedl );
+                        mpRedlineTbl->Remove( n );
                         mpRedlineTbl->Insert( pRedl );
                         --n;
                     }