[Libreoffice-commits] core.git: 2 commits - sc/CppunitTest_sc_annotationshapeobj.mk sc/Module_sc.mk sc/qa tools/source tubes/source ucbhelper/source ucb/source unoidl/source unotools/source unoxml/source uui/source
Caolán McNamara
caolanm at redhat.com
Tue May 26 01:57:50 PDT 2015
sc/CppunitTest_sc_annotationshapeobj.mk | 4 +
sc/Module_sc.mk | 3
sc/qa/extras/scannotationshapeobj.cxx | 40 ++++++------
tools/source/inet/inetstrm.cxx | 6 -
tubes/source/contacts.cxx | 2
ucb/source/cacher/cachedcontentresultset.cxx | 2
ucb/source/core/FileAccess.cxx | 2
ucb/source/core/cmdenv.hxx | 2
ucb/source/core/identify.hxx | 2
ucb/source/core/provprox.hxx | 2
ucb/source/core/ucb.hxx | 2
ucb/source/core/ucbcmds.cxx | 2
ucb/source/core/ucbprops.hxx | 2
ucb/source/core/ucbstore.cxx | 12 +--
ucb/source/core/ucbstore.hxx | 2
ucb/source/ucp/cmis/cmis_datasupplier.hxx | 2
ucb/source/ucp/cmis/cmis_provider.hxx | 2
ucb/source/ucp/cmis/cmis_url.hxx | 2
ucb/source/ucp/expand/ucpexpand.cxx | 2
ucb/source/ucp/ext/ucpext_provider.hxx | 2
ucb/source/ucp/file/bc.cxx | 2
ucb/source/ucp/file/filcmd.hxx | 2
ucb/source/ucp/file/filrec.hxx | 2
ucb/source/ucp/file/filtask.hxx | 2
ucb/source/ucp/file/prov.hxx | 2
ucb/source/ucp/file/shell.hxx | 2
ucb/source/ucp/ftp/ftpcontent.cxx | 2
ucb/source/ucp/ftp/ftpcontentidentifier.hxx | 2
ucb/source/ucp/ftp/ftpcontentprovider.hxx | 2
ucb/source/ucp/ftp/ftpresultsetbase.cxx | 2
ucb/source/ucp/ftp/ftpstrcont.hxx | 4 -
ucb/source/ucp/ftp/ftpurl.hxx | 2
ucb/source/ucp/gio/gio_content.cxx | 2
ucb/source/ucp/gio/gio_datasupplier.hxx | 2
ucb/source/ucp/gio/gio_inputstream.hxx | 2
ucb/source/ucp/gio/gio_outputstream.hxx | 2
ucb/source/ucp/gio/gio_provider.hxx | 2
ucb/source/ucp/gio/gio_seekable.hxx | 2
ucb/source/ucp/gvfs/gvfs_content.hxx | 2
ucb/source/ucp/gvfs/gvfs_directory.cxx | 2
ucb/source/ucp/gvfs/gvfs_provider.cxx | 5 -
ucb/source/ucp/hierarchy/hierarchycontent.hxx | 4 -
ucb/source/ucp/hierarchy/hierarchydata.hxx | 2
ucb/source/ucp/hierarchy/hierarchydatasource.hxx | 2
ucb/source/ucp/hierarchy/hierarchydatasupplier.cxx | 2
ucb/source/ucp/hierarchy/hierarchyprovider.hxx | 2
ucb/source/ucp/package/pkgcontent.hxx | 2
ucb/source/ucp/package/pkgdatasupplier.cxx | 2
ucb/source/ucp/package/pkgprovider.hxx | 2
ucb/source/ucp/package/pkguri.hxx | 2
ucb/source/ucp/tdoc/tdoc_datasupplier.cxx | 2
ucb/source/ucp/tdoc/tdoc_docmgr.hxx | 2
ucb/source/ucp/tdoc/tdoc_documentcontentfactory.hxx | 2
ucb/source/ucp/tdoc/tdoc_passwordrequest.cxx | 4 -
ucb/source/ucp/tdoc/tdoc_provider.hxx | 2
ucb/source/ucp/tdoc/tdoc_stgelems.hxx | 2
ucb/source/ucp/webdav-neon/DAVException.hxx | 2
ucb/source/ucp/webdav-neon/DAVResource.hxx | 4 -
ucb/source/ucp/webdav-neon/DAVSession.hxx | 2
ucb/source/ucp/webdav-neon/NeonLockStore.cxx | 8 +-
ucb/source/ucp/webdav-neon/NeonSession.cxx | 4 -
ucb/source/ucp/webdav-neon/NeonUri.hxx | 4 -
ucb/source/ucp/webdav-neon/webdavdatasupplier.cxx | 2
ucb/source/ucp/webdav-neon/webdavprovider.hxx | 2
ucb/source/ucp/webdav/DAVException.hxx | 2
ucb/source/ucp/webdav/DAVResource.hxx | 4 -
ucb/source/ucp/webdav/DAVSession.hxx | 4 -
ucb/source/ucp/webdav/SerfLockStore.cxx | 4 -
ucb/source/ucp/webdav/SerfUri.hxx | 4 -
ucb/source/ucp/webdav/webdavdatasupplier.cxx | 2
ucb/source/ucp/webdav/webdavprovider.hxx | 2
ucb/source/ucp/webdav/webdavresponseparser.cxx | 2
ucbhelper/source/client/content.cxx | 4 -
ucbhelper/source/client/proxydecider.cxx | 4 -
ucbhelper/source/provider/contenthelper.cxx | 2
ucbhelper/source/provider/contentidentifier.cxx | 2
ucbhelper/source/provider/interactionrequest.cxx | 9 --
ucbhelper/source/provider/resultset.cxx | 4 -
ucbhelper/source/provider/resultsetmetadata.cxx | 4 -
ucbhelper/source/provider/simplenameclashresolverequest.cxx | 2
unoidl/source/sourceprovider-scanner.hxx | 4 -
unoidl/source/unoidl-check.cxx | 2
unotools/source/config/configitem.cxx | 16 ++--
unotools/source/config/configvaluecontainer.cxx | 2
unotools/source/config/fltrcfg.cxx | 6 -
unotools/source/config/useroptions.cxx | 2
unotools/source/config/viewoptions.cxx | 2
unotools/source/misc/closeveto.cxx | 2
unotools/source/misc/componentresmodule.cxx | 2
unotools/source/misc/fontcvt.cxx | 2
unotools/source/misc/sharedunocomponent.cxx | 2
unotools/source/ucbhelper/XTempFile.hxx | 2
unotools/source/ucbhelper/ucblockbytes.cxx | 24 +++----
unoxml/source/dom/document.hxx | 2
unoxml/source/dom/documentbuilder.hxx | 2
unoxml/source/dom/elementlist.cxx | 2
unoxml/source/dom/saxbuilder.hxx | 2
unoxml/source/rdf/librdf_repository.cxx | 6 -
unoxml/source/xpath/xpathapi.hxx | 2
uui/source/fltdlg.cxx | 2
uui/source/fltdlg.hxx | 2
uui/source/iahndl.cxx | 2
uui/source/iahndl.hxx | 10 +--
uui/source/interactionhandler.cxx | 2
uui/source/passwordcontainer.hxx | 2
uui/source/requeststringresolver.hxx | 2
106 files changed, 184 insertions(+), 181 deletions(-)
New commits:
commit bb77090deb4843627de51ba90c8fa4935ebe20f6
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon May 25 09:28:52 2015 +0100
FIXME_REMOVE_WHEN_RE_BASE_COMPLETE
this part anyway, the sc/qa/unoapi parts are
still broken
Change-Id: I759c4f82b3bbd4da4dc7d0c9e16aacee02972f51
diff --git a/sc/CppunitTest_sc_annotationshapeobj.mk b/sc/CppunitTest_sc_annotationshapeobj.mk
index 1d95bef..501d52d 100644
--- a/sc/CppunitTest_sc_annotationshapeobj.mk
+++ b/sc/CppunitTest_sc_annotationshapeobj.mk
@@ -65,6 +65,7 @@ $(eval $(call gb_CppunitTest_use_api,sc_annotationshapeobj,\
))
$(eval $(call gb_CppunitTest_use_ure,sc_annotationshapeobj))
+$(eval $(call gb_CppunitTest_use_vcl,sc_annotationshapeobj))
$(eval $(call gb_CppunitTest_use_components,sc_annotationshapeobj,\
basic/util/sb \
@@ -75,6 +76,7 @@ $(eval $(call gb_CppunitTest_use_components,sc_annotationshapeobj,\
forms/util/frm \
framework/util/fwk \
i18npool/util/i18npool \
+ linguistic/source/lng \
oox/util/oox \
package/source/xstor/xstor \
package/util/package2 \
@@ -96,6 +98,8 @@ $(eval $(call gb_CppunitTest_use_components,sc_annotationshapeobj,\
unotools/util/utl \
unoxml/source/rdf/unordf \
unoxml/source/service/unoxml \
+ xmloff/util/xo \
+ svtools/util/svt \
))
$(eval $(call gb_CppunitTest_use_configuration,sc_annotationshapeobj))
diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk
index fc49303..65a278e 100644
--- a/sc/Module_sc.mk
+++ b/sc/Module_sc.mk
@@ -64,12 +64,11 @@ $(eval $(call gb_Module_add_slowcheck_targets,sc, \
# Disabled to allow the check tinderbox execute the sd tests
# CppunitTest_sc_chart_regression_test \
-# FIXME_REMOVE_WHEN_RE_BASE_COMPLETE
-# CppunitTest_sc_annotationshapeobj \
$(eval $(call gb_Module_add_subsequentcheck_targets,sc,\
JunitTest_sc_complex \
JunitTest_sc_unoapi \
+ CppunitTest_sc_annotationshapeobj \
CppunitTest_sc_outlineobj \
CppunitTest_sc_styleloaderobj \
CppunitTest_sc_recordchanges \
diff --git a/sc/qa/extras/scannotationshapeobj.cxx b/sc/qa/extras/scannotationshapeobj.cxx
index 7e3c241..07d3d80 100644
--- a/sc/qa/extras/scannotationshapeobj.cxx
+++ b/sc/qa/extras/scannotationshapeobj.cxx
@@ -7,13 +7,15 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
-#include <test/unoapi_test.hxx>
+#include <test/calc_unoapi_test.hxx>
#include <test/text/xtext.hxx>
#include <com/sun/star/sheet/XSheetAnnotationAnchor.hpp>
+#include <com/sun/star/sheet/XSheetAnnotationsSupplier.hpp>
#include <com/sun/star/sheet/XSheetAnnotationShapeSupplier.hpp>
#include <com/sun/star/sheet/XSpreadsheetDocument.hpp>
#include <com/sun/star/sheet/XSpreadsheet.hpp>
+#include <com/sun/star/table/CellAddress.hpp>
#define NUMBER_OF_TESTS 1
@@ -22,15 +24,15 @@ using namespace css::uno;
namespace sc_apitest {
-class ScAnnotationShapeObj : public UnoApiTest, apitest::XText
+class ScAnnotationShapeObj : public CalcUnoApiTest, apitest::XText
{
public:
ScAnnotationShapeObj();
- virtual void setUp();
- virtual void tearDown();
- virtual uno::Reference<uno::XInterface> init();
- virtual uno::Reference<text::XTextContent> getTextContent();
+ virtual void setUp() SAL_OVERRIDE;
+ virtual void tearDown() SAL_OVERRIDE;
+ virtual uno::Reference<uno::XInterface> init() SAL_OVERRIDE;
+ virtual uno::Reference<text::XTextContent> getTextContent() SAL_OVERRIDE;
CPPUNIT_TEST_SUITE(ScAnnotationShapeObj);
@@ -49,12 +51,15 @@ sal_Int32 ScAnnotationShapeObj::nTest = 0;
uno::Reference<lang::XComponent> ScAnnotationShapeObj::mxComponent;
uno::Reference<text::XTextContent> ScAnnotationShapeObj::mxField;
-ScAnnotationShapeObj::ScAnnotationShapeObj() {}
+ScAnnotationShapeObj::ScAnnotationShapeObj()
+ : CalcUnoApiTest("sc/qa/extras/testdocuments")
+{
+}
void ScAnnotationShapeObj::setUp()
{
++nTest;
- UnoApiTest::setUp();
+ CalcUnoApiTest::setUp();
}
void ScAnnotationShapeObj::tearDown()
@@ -66,12 +71,11 @@ void ScAnnotationShapeObj::tearDown()
mxComponent.clear();
}
- UnoApiTest::tearDown();
+ CalcUnoApiTest::tearDown();
}
uno::Reference<uno::XInterface> ScAnnotationShapeObj::init()
{
-#ifdef FIXME_REMOVE_WHEN_RE_BASE_COMPLETE
if (!mxComponent.is())
// Load an empty document.
mxComponent = loadFromDesktop("private:factory/scalc");
@@ -81,30 +85,32 @@ uno::Reference<uno::XInterface> ScAnnotationShapeObj::init()
uno::Reference<sheet::XSpreadsheet> xSheet(xIA->getByIndex(0), UNO_QUERY_THROW);
// Use cell A1 for this.
+
+ table::CellAddress aNotePos(0, 0, 0);
+ Reference<sheet::XSheetAnnotationsSupplier> xAnnosSupp(xSheet, UNO_QUERY_THROW);
+ Reference<sheet::XSheetAnnotations> xAnnos(xAnnosSupp->getAnnotations(), UNO_SET_THROW);
+ // non-empty string required by note implementation (real text will be added below)
+ xAnnos->insertNew(aNotePos, OUString(' '));
+
uno::Reference<table::XCell> xCell = xSheet->getCellByPosition(0, 0);
uno::Reference<sheet::XSheetAnnotationAnchor> xAnchor(xCell, UNO_QUERY_THROW);
- uno::Reference<sheet::XSheetAnnotation> xAnnotation = xAnchor->getAnnotation();
+ uno::Reference<sheet::XSheetAnnotation> xAnnotation(xAnchor->getAnnotation(), UNO_SET_THROW);
uno::Reference<text::XSimpleText> xAnnoText(xAnnotation, UNO_QUERY_THROW);
xAnnoText->setString("ScAnnotationShapeObj");
uno::Reference<sheet::XSheetAnnotationShapeSupplier> xShapeSupp(xAnnotation, UNO_QUERY_THROW);
- uno::Reference<drawing::XShape> xShape = xShapeSupp->getAnnotationShape();
+ uno::Reference<drawing::XShape> xShape(xShapeSupp->getAnnotationShape(), UNO_SET_THROW);
return xShape;
-#else
- return uno::Reference<drawing::XShape>();
-#endif
}
uno::Reference<text::XTextContent> ScAnnotationShapeObj::getTextContent()
{
-#ifdef FIXME_REMOVE_WHEN_RE_BASE_COMPLETE
if (!mxField.is())
{
uno::Reference<lang::XMultiServiceFactory> xSM(mxComponent, UNO_QUERY_THROW);
mxField.set(xSM->createInstance("com.sun.star.text.TextField.DateTime"), UNO_QUERY_THROW);
}
-#endif
return mxField;
}
commit 6c9dfa8ab7cc25d6cc3ce988803118b5d56ea30b
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon May 25 15:28:47 2015 +0100
cppcheck: noExplicitConstructor
Change-Id: If947733a205e8ece1845079be95cbc2d6cbd5029
diff --git a/tools/source/inet/inetstrm.cxx b/tools/source/inet/inetstrm.cxx
index 80d68a0..4342c67 100644
--- a/tools/source/inet/inetstrm.cxx
+++ b/tools/source/inet/inetstrm.cxx
@@ -52,7 +52,7 @@ class INetMessageEncodeQPStream_Impl : public INetMessageIStream
virtual int GetMsgLine(sal_Char* pData, sal_uIntPtr nSize) SAL_OVERRIDE;
public:
- INetMessageEncodeQPStream_Impl(sal_uIntPtr nMsgBufferSize = 1024);
+ explicit INetMessageEncodeQPStream_Impl(sal_uIntPtr nMsgBufferSize = 1024);
virtual ~INetMessageEncodeQPStream_Impl();
};
@@ -92,7 +92,7 @@ class INetMessageEncode64Stream_Impl : public INetMessageIStream
virtual int GetMsgLine(sal_Char* pData, sal_uIntPtr nSize) SAL_OVERRIDE;
public:
- INetMessageEncode64Stream_Impl(sal_uIntPtr nMsgBufferSize = 2048);
+ explicit INetMessageEncode64Stream_Impl(sal_uIntPtr nMsgBufferSize = 2048);
virtual ~INetMessageEncode64Stream_Impl();
};
@@ -109,7 +109,7 @@ class INetMessageDecode64Stream_Impl : public INetMessageOStream
virtual int PutMsgLine(const sal_Char* pData, sal_uIntPtr nSize) SAL_OVERRIDE;
public:
- INetMessageDecode64Stream_Impl(sal_uIntPtr nMsgBufferSize = 128);
+ explicit INetMessageDecode64Stream_Impl(sal_uIntPtr nMsgBufferSize = 128);
virtual ~INetMessageDecode64Stream_Impl();
};
diff --git a/tubes/source/contacts.cxx b/tubes/source/contacts.cxx
index df99005..0838880 100644
--- a/tubes/source/contacts.cxx
+++ b/tubes/source/contacts.cxx
@@ -106,7 +106,7 @@ class TubeContacts : public ModelessDialog
}
public:
- TubeContacts( Collaboration* pCollaboration ) :
+ explicit TubeContacts( Collaboration* pCollaboration ) :
ModelessDialog( NULL, "ContactsDialog", "tubes/ui/contacts.ui" ),
mpCollaboration( pCollaboration )
{
diff --git a/ucb/source/cacher/cachedcontentresultset.cxx b/ucb/source/cacher/cachedcontentresultset.cxx
index dfa021a..97e4832 100644
--- a/ucb/source/cacher/cachedcontentresultset.cxx
+++ b/ucb/source/cacher/cachedcontentresultset.cxx
@@ -407,7 +407,7 @@ private:
impl_isMyPropertyName( const OUString& rName );
public:
- CCRS_PropertySetInfo( Reference<
+ explicit CCRS_PropertySetInfo( Reference<
XPropertySetInfo > xPropertySetInfoOrigin );
virtual ~CCRS_PropertySetInfo();
diff --git a/ucb/source/core/FileAccess.cxx b/ucb/source/core/FileAccess.cxx
index 543f00a..292939a 100644
--- a/ucb/source/core/FileAccess.cxx
+++ b/ucb/source/core/FileAccess.cxx
@@ -94,7 +94,7 @@ class OFileAccess : public FileAccessHelper
throw ( Exception );
public:
- OFileAccess( const Reference< XComponentContext > & xContext )
+ explicit OFileAccess( const Reference< XComponentContext > & xContext )
: m_xContext( xContext), mpEnvironment( NULL ) {}
// Methods
virtual void SAL_CALL copy( const OUString& SourceURL, const OUString& DestURL ) throw(::com::sun::star::ucb::CommandAbortedException, ::com::sun::star::uno::Exception, ::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
diff --git a/ucb/source/core/cmdenv.hxx b/ucb/source/core/cmdenv.hxx
index 4bdcca1..b9234cf 100644
--- a/ucb/source/core/cmdenv.hxx
+++ b/ucb/source/core/cmdenv.hxx
@@ -40,7 +40,7 @@ class UcbCommandEnvironment :
com::sun::star::ucb::XProgressHandler > m_xPH;
public:
- UcbCommandEnvironment(
+ explicit UcbCommandEnvironment(
const com::sun::star::uno::Reference<
com::sun::star::lang::XMultiServiceFactory >& rXSMgr );
virtual ~UcbCommandEnvironment();
diff --git a/ucb/source/core/identify.hxx b/ucb/source/core/identify.hxx
index 91b9855..375d2c9 100644
--- a/ucb/source/core/identify.hxx
+++ b/ucb/source/core/identify.hxx
@@ -29,7 +29,7 @@ class ContentIdentifier : public cppu::WeakImplHelper1 <
css::ucb::XContentIdentifier >
{
public:
- ContentIdentifier( const OUString& ContentId );
+ explicit ContentIdentifier( const OUString& ContentId );
virtual ~ContentIdentifier();
// XContentIdentifier
diff --git a/ucb/source/core/provprox.hxx b/ucb/source/core/provprox.hxx
index 88cf5c1f..e217e96 100644
--- a/ucb/source/core/provprox.hxx
+++ b/ucb/source/core/provprox.hxx
@@ -53,7 +53,7 @@ class UcbContentProviderProxyFactory : public cppu::WeakImplHelper2 <
m_xSMgr;
public:
- UcbContentProviderProxyFactory(
+ explicit UcbContentProviderProxyFactory(
const com::sun::star::uno::Reference<
com::sun::star::lang::XMultiServiceFactory >& rxSMgr );
virtual ~UcbContentProviderProxyFactory();
diff --git a/ucb/source/core/ucb.hxx b/ucb/source/core/ucb.hxx
index fe3dec5..784c055 100644
--- a/ucb/source/core/ucb.hxx
+++ b/ucb/source/core/ucb.hxx
@@ -62,7 +62,7 @@ class UniversalContentBroker :
public com::sun::star::util::XChangesListener
{
public:
- UniversalContentBroker( const com::sun::star::uno::Reference< com::sun::star::uno::XComponentContext >& xContext );
+ explicit UniversalContentBroker( const com::sun::star::uno::Reference< com::sun::star::uno::XComponentContext >& xContext );
virtual ~UniversalContentBroker();
// XInterface
diff --git a/ucb/source/core/ucbcmds.cxx b/ucb/source/core/ucbcmds.cxx
index e0974e1..28a254f 100644
--- a/ucb/source/core/ucbcmds.cxx
+++ b/ucb/source/core/ucbcmds.cxx
@@ -99,7 +99,7 @@ class InteractionHandlerProxy :
uno::Reference< task::XInteractionHandler > m_xOrig;
public:
- InteractionHandlerProxy(
+ explicit InteractionHandlerProxy(
const uno::Reference< task::XInteractionHandler > & xOrig )
: m_xOrig( xOrig ) {}
diff --git a/ucb/source/core/ucbprops.hxx b/ucb/source/core/ucbprops.hxx
index 3708f06..9b320bb 100644
--- a/ucb/source/core/ucbprops.hxx
+++ b/ucb/source/core/ucbprops.hxx
@@ -51,7 +51,7 @@ private:
com::sun::star::beans::Property& rProp );
public:
- UcbPropertiesManager( const com::sun::star::uno::Reference<
+ explicit UcbPropertiesManager( const com::sun::star::uno::Reference<
com::sun::star::lang::XMultiServiceFactory >&
rxSMgr );
virtual ~UcbPropertiesManager();
diff --git a/ucb/source/core/ucbstore.cxx b/ucb/source/core/ucbstore.cxx
index 98fb48a..51eebb1 100644
--- a/ucb/source/core/ucbstore.cxx
+++ b/ucb/source/core/ucbstore.cxx
@@ -242,18 +242,14 @@ struct PropertySetRegistry_Impl
bool m_bTriedToGetRootReadAccess; // #82494#
bool m_bTriedToGetRootWriteAccess; // #82494#
- PropertySetRegistry_Impl( const Sequence< Any > &rInitArgs )
- : m_aInitArgs( rInitArgs ),
- m_bTriedToGetRootReadAccess( false ),
- m_bTriedToGetRootWriteAccess( false )
+ explicit PropertySetRegistry_Impl(const Sequence<Any> &rInitArgs)
+ : m_aInitArgs(rInitArgs)
+ , m_bTriedToGetRootReadAccess(false)
+ , m_bTriedToGetRootWriteAccess(false)
{
}
};
-
-
-
-
// PropertySetRegistry Implementation.
diff --git a/ucb/source/core/ucbstore.hxx b/ucb/source/core/ucbstore.hxx
index 83f27d8..78e94bb 100644
--- a/ucb/source/core/ucbstore.hxx
+++ b/ucb/source/core/ucbstore.hxx
@@ -57,7 +57,7 @@ class UcbStore : public cppu::WeakImplHelper3 <
UcbStore_Impl* m_pImpl;
public:
- UcbStore(
+ explicit UcbStore(
const com::sun::star::uno::Reference<
com::sun::star::uno::XComponentContext >& xContext );
virtual ~UcbStore();
diff --git a/ucb/source/ucp/cmis/cmis_datasupplier.hxx b/ucb/source/ucp/cmis/cmis_datasupplier.hxx
index d90f24d..200fbe5 100644
--- a/ucb/source/ucp/cmis/cmis_datasupplier.hxx
+++ b/ucb/source/ucp/cmis/cmis_datasupplier.hxx
@@ -26,7 +26,7 @@ namespace cmis
com::sun::star::uno::Reference< com::sun::star::ucb::XContent > xContent;
com::sun::star::uno::Reference< com::sun::star::sdbc::XRow > xRow;
- ResultListEntry( com::sun::star::uno::Reference< com::sun::star::ucb::XContent > xCnt ) : xContent( xCnt )
+ explicit ResultListEntry( com::sun::star::uno::Reference< com::sun::star::ucb::XContent > xCnt ) : xContent( xCnt )
{
}
diff --git a/ucb/source/ucp/cmis/cmis_provider.hxx b/ucb/source/ucp/cmis/cmis_provider.hxx
index b0e7fec..efbd439 100644
--- a/ucb/source/ucp/cmis/cmis_provider.hxx
+++ b/ucb/source/ucp/cmis/cmis_provider.hxx
@@ -23,7 +23,7 @@ private:
std::map< OUString, libcmis::Session* > m_aSessionCache;
public:
- ContentProvider( const ::com::sun::star::uno::Reference<
+ explicit ContentProvider( const ::com::sun::star::uno::Reference<
::com::sun::star::uno::XComponentContext >& rxContext );
virtual ~ContentProvider();
diff --git a/ucb/source/ucp/cmis/cmis_url.hxx b/ucb/source/ucp/cmis/cmis_url.hxx
index 0e687f5..56b1fc8 100644
--- a/ucb/source/ucp/cmis/cmis_url.hxx
+++ b/ucb/source/ucp/cmis/cmis_url.hxx
@@ -28,7 +28,7 @@ namespace cmis
OUString m_sPass;
public:
- URL( OUString const & urlStr );
+ explicit URL( OUString const & urlStr );
OUString& getObjectPath( ) { return m_sPath; }
OUString& getObjectId( ) { return m_sId; }
diff --git a/ucb/source/ucp/expand/ucpexpand.cxx b/ucb/source/ucp/expand/ucpexpand.cxx
index 5393a2e..6feebd6 100644
--- a/ucb/source/ucp/expand/ucpexpand.cxx
+++ b/ucb/source/ucp/expand/ucpexpand.cxx
@@ -63,7 +63,7 @@ protected:
virtual void SAL_CALL disposing() SAL_OVERRIDE;
public:
- inline ExpandContentProviderImpl(
+ explicit ExpandContentProviderImpl(
uno::Reference< uno::XComponentContext > const & xComponentContext )
: t_impl_helper( m_mutex ),
m_xComponentContext( xComponentContext ),
diff --git a/ucb/source/ucp/ext/ucpext_provider.hxx b/ucb/source/ucp/ext/ucpext_provider.hxx
index 1b0ae33..5efda9d 100644
--- a/ucb/source/ucp/ext/ucpext_provider.hxx
+++ b/ucb/source/ucp/ext/ucpext_provider.hxx
@@ -34,7 +34,7 @@ namespace ucb { namespace ucp { namespace ext
class ContentProvider : public ContentProvider_Base
{
public:
- ContentProvider( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& rxContext );
+ explicit ContentProvider( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& rxContext );
virtual ~ContentProvider();
// XServiceInfo
diff --git a/ucb/source/ucp/file/bc.cxx b/ucb/source/ucp/file/bc.cxx
index 39a5c8d..f6f086d 100644
--- a/ucb/source/ucp/file/bc.cxx
+++ b/ucb/source/ucp/file/bc.cxx
@@ -61,7 +61,7 @@ class fileaccess::PropertyListeners
: public PropertyListeners_impl
{
public:
- PropertyListeners( ::osl::Mutex& aMutex )
+ explicit PropertyListeners( ::osl::Mutex& aMutex )
: PropertyListeners_impl( aMutex )
{
}
diff --git a/ucb/source/ucp/file/filcmd.hxx b/ucb/source/ucp/file/filcmd.hxx
index 6863f8d..e33a6de 100644
--- a/ucb/source/ucp/file/filcmd.hxx
+++ b/ucb/source/ucp/file/filcmd.hxx
@@ -39,7 +39,7 @@ namespace fileaccess {
{
public:
- XCommandInfo_impl( shell* pMyShell );
+ explicit XCommandInfo_impl( shell* pMyShell );
virtual ~XCommandInfo_impl();
diff --git a/ucb/source/ucp/file/filrec.hxx b/ucb/source/ucp/file/filrec.hxx
index 6d7b8cc..9760c4a 100644
--- a/ucb/source/ucp/file/filrec.hxx
+++ b/ucb/source/ucp/file/filrec.hxx
@@ -39,7 +39,7 @@ class ReconnectingFile
public:
- ReconnectingFile( const OUString& aFileURL )
+ explicit ReconnectingFile( const OUString& aFileURL )
: m_aFile( aFileURL )
, m_nFlags( 0 )
, m_bFlagsSet( false )
diff --git a/ucb/source/ucp/file/filtask.hxx b/ucb/source/ucp/file/filtask.hxx
index acf67c6..928523d 100644
--- a/ucb/source/ucp/file/filtask.hxx
+++ b/ucb/source/ucp/file/filtask.hxx
@@ -61,7 +61,7 @@ namespace fileaccess
public:
- TaskHandling(
+ explicit TaskHandling(
const com::sun::star::uno::Reference< com::sun::star::ucb::XCommandEnvironment >& xCommandEnv
= com::sun::star::uno::Reference< com::sun::star::ucb::XCommandEnvironment >( 0 ) )
: m_bAbort( false ),
diff --git a/ucb/source/ucp/file/prov.hxx b/ucb/source/ucp/file/prov.hxx
index 38d2785..bc5389f 100644
--- a/ucb/source/ucp/file/prov.hxx
+++ b/ucb/source/ucp/file/prov.hxx
@@ -59,7 +59,7 @@ namespace fileaccess {
friend class BaseContent;
public:
- FileProvider( const com::sun::star::uno::Reference< com::sun::star::uno::XComponentContext >& rxContext );
+ explicit FileProvider( const com::sun::star::uno::Reference< com::sun::star::uno::XComponentContext >& rxContext );
virtual ~FileProvider();
// XServiceInfo
diff --git a/ucb/source/ucp/file/shell.hxx b/ucb/source/ucp/file/shell.hxx
index 3d5cfe2..a136bb7 100644
--- a/ucb/source/ucp/file/shell.hxx
+++ b/ucb/source/ucp/file/shell.hxx
@@ -88,7 +88,7 @@ namespace fileaccess {
sal_Int16 Attributes;
public:
MyProperty();
- MyProperty( const OUString& __PropertyName );
+ explicit MyProperty( const OUString& __PropertyName );
MyProperty( const bool& __isNative,
const OUString& __PropertyName,
const sal_Int32& __Handle,
diff --git a/ucb/source/ucp/ftp/ftpcontent.cxx b/ucb/source/ucp/ftp/ftpcontent.cxx
index 59c889a..09a59ca 100644
--- a/ucb/source/ucp/ftp/ftpcontent.cxx
+++ b/ucb/source/ucp/ftp/ftpcontent.cxx
@@ -720,7 +720,7 @@ class InsertData
public:
- InsertData(const Reference<XInputStream>& xInputStream)
+ explicit InsertData(const Reference<XInputStream>& xInputStream)
: m_xInputStream(xInputStream) { }
virtual ~InsertData() {}
diff --git a/ucb/source/ucp/ftp/ftpcontentidentifier.hxx b/ucb/source/ucp/ftp/ftpcontentidentifier.hxx
index e08eae7..38dabce 100644
--- a/ucb/source/ucp/ftp/ftpcontentidentifier.hxx
+++ b/ucb/source/ucp/ftp/ftpcontentidentifier.hxx
@@ -46,7 +46,7 @@ namespace ftp {
{
public:
- FTPContentIdentifier(const OUString& ident);
+ explicit FTPContentIdentifier(const OUString& ident);
virtual ~FTPContentIdentifier();
diff --git a/ucb/source/ucp/ftp/ftpcontentprovider.hxx b/ucb/source/ucp/ftp/ftpcontentprovider.hxx
index d700e85..4f96524 100644
--- a/ucb/source/ucp/ftp/ftpcontentprovider.hxx
+++ b/ucb/source/ucp/ftp/ftpcontentprovider.hxx
@@ -47,7 +47,7 @@ namespace ftp
{
public:
- FTPContentProvider( const css::uno::Reference< css::uno::XComponentContext >& rxContext );
+ explicit FTPContentProvider( const css::uno::Reference< css::uno::XComponentContext >& rxContext );
virtual ~FTPContentProvider();
diff --git a/ucb/source/ucp/ftp/ftpresultsetbase.cxx b/ucb/source/ucp/ftp/ftpresultsetbase.cxx
index ba9f331..2f35a7e 100644
--- a/ucb/source/ucp/ftp/ftpresultsetbase.cxx
+++ b/ucb/source/ucp/ftp/ftpresultsetbase.cxx
@@ -437,7 +437,7 @@ class XPropertySetInfoImpl
{
public:
- XPropertySetInfoImpl( const uno::Sequence< beans::Property >& aSeq )
+ explicit XPropertySetInfoImpl( const uno::Sequence< beans::Property >& aSeq )
: m_aSeq( aSeq )
{
}
diff --git a/ucb/source/ucp/ftp/ftpstrcont.hxx b/ucb/source/ucp/ftp/ftpstrcont.hxx
index 6d9e581..00efa78 100644
--- a/ucb/source/ucp/ftp/ftpstrcont.hxx
+++ b/ucb/source/ucp/ftp/ftpstrcont.hxx
@@ -41,7 +41,7 @@ namespace ftp {
{
public:
- FTPOutputStreamContainer(const com::sun::star::uno::Reference<
+ explicit FTPOutputStreamContainer(const com::sun::star::uno::Reference<
com::sun::star::io::XOutputStream>& out);
virtual ~FTPOutputStreamContainer() {}
@@ -61,7 +61,7 @@ namespace ftp {
{
public:
- FTPInputStreamContainer(FTPInputStream* out);
+ explicit FTPInputStreamContainer(FTPInputStream* out);
virtual ~FTPInputStreamContainer() {}
diff --git a/ucb/source/ucp/ftp/ftpurl.hxx b/ucb/source/ucp/ftp/ftpurl.hxx
index ecb8841..f51ace6 100644
--- a/ucb/source/ucp/ftp/ftpurl.hxx
+++ b/ucb/source/ucp/ftp/ftpurl.hxx
@@ -57,7 +57,7 @@ namespace ftp {
{
public:
- curl_exception(sal_Int32 err)
+ explicit curl_exception(sal_Int32 err)
: n_err(err) { }
sal_Int32 code() const { return n_err; }
diff --git a/ucb/source/ucp/gio/gio_content.cxx b/ucb/source/ucp/gio/gio_content.cxx
index 96c7c4b..b39fada 100644
--- a/ucb/source/ucp/gio/gio_content.cxx
+++ b/ucb/source/ucp/gio/gio_content.cxx
@@ -327,7 +327,7 @@ class MountOperation
GError *mpError;
static void Completed(GObject *source, GAsyncResult *res, gpointer user_data);
public:
- MountOperation(const uno::Reference< ucb::XCommandEnvironment >& xEnv);
+ explicit MountOperation(const uno::Reference< ucb::XCommandEnvironment >& xEnv);
~MountOperation();
GError *Mount(GFile *pFile);
};
diff --git a/ucb/source/ucp/gio/gio_datasupplier.hxx b/ucb/source/ucp/gio/gio_datasupplier.hxx
index c610ed1..15c6142 100644
--- a/ucb/source/ucp/gio/gio_datasupplier.hxx
+++ b/ucb/source/ucp/gio/gio_datasupplier.hxx
@@ -37,7 +37,7 @@ struct ResultListEntry
com::sun::star::uno::Reference< com::sun::star::sdbc::XRow > xRow;
GFileInfo *pInfo;
- ResultListEntry( GFileInfo *pInInfo ) : pInfo(pInInfo)
+ explicit ResultListEntry( GFileInfo *pInInfo ) : pInfo(pInInfo)
{
g_object_ref( pInfo );
}
diff --git a/ucb/source/ucp/gio/gio_inputstream.hxx b/ucb/source/ucp/gio/gio_inputstream.hxx
index bb821f2..a37c2b8 100644
--- a/ucb/source/ucp/gio/gio_inputstream.hxx
+++ b/ucb/source/ucp/gio/gio_inputstream.hxx
@@ -41,7 +41,7 @@ private:
GFileInputStream *mpStream;
public:
- InputStream ( GFileInputStream *pStream );
+ explicit InputStream ( GFileInputStream *pStream );
virtual ~InputStream();
// XInterface
diff --git a/ucb/source/ucp/gio/gio_outputstream.hxx b/ucb/source/ucp/gio/gio_outputstream.hxx
index c5ff0a6..caf8a5f 100644
--- a/ucb/source/ucp/gio/gio_outputstream.hxx
+++ b/ucb/source/ucp/gio/gio_outputstream.hxx
@@ -41,7 +41,7 @@ private:
GFileOutputStream *mpStream;
public:
- OutputStream ( GFileOutputStream *pStream );
+ explicit OutputStream ( GFileOutputStream *pStream );
virtual ~OutputStream();
// XInterface
diff --git a/ucb/source/ucp/gio/gio_provider.hxx b/ucb/source/ucp/gio/gio_provider.hxx
index 1d6a093..848271b 100644
--- a/ucb/source/ucp/gio/gio_provider.hxx
+++ b/ucb/source/ucp/gio/gio_provider.hxx
@@ -30,7 +30,7 @@ namespace gio
class ContentProvider : public ::ucbhelper::ContentProviderImplHelper
{
public:
- ContentProvider( const ::com::sun::star::uno::Reference<
+ explicit ContentProvider( const ::com::sun::star::uno::Reference<
::com::sun::star::uno::XComponentContext >& rxContext );
virtual ~ContentProvider();
diff --git a/ucb/source/ucp/gio/gio_seekable.hxx b/ucb/source/ucp/gio/gio_seekable.hxx
index ea93781..7b0eddb 100644
--- a/ucb/source/ucp/gio/gio_seekable.hxx
+++ b/ucb/source/ucp/gio/gio_seekable.hxx
@@ -39,7 +39,7 @@ class Seekable : public ::com::sun::star::io::XTruncate,
private:
GSeekable *mpStream;
public:
- Seekable( GSeekable *pStream );
+ explicit Seekable( GSeekable *pStream );
virtual ~Seekable();
// XInterface
diff --git a/ucb/source/ucp/gvfs/gvfs_content.hxx b/ucb/source/ucp/gvfs/gvfs_content.hxx
index bae3fca..0b062f4 100644
--- a/ucb/source/ucp/gvfs/gvfs_content.hxx
+++ b/ucb/source/ucp/gvfs/gvfs_content.hxx
@@ -61,7 +61,7 @@ class Authentication
{
public:
// Helper class to make exceptions pleasant
- Authentication( const com::sun::star::uno::Reference<
+ explicit Authentication( const com::sun::star::uno::Reference<
com::sun::star::ucb::XCommandEnvironment > & xEnv );
~Authentication();
};
diff --git a/ucb/source/ucp/gvfs/gvfs_directory.cxx b/ucb/source/ucp/gvfs/gvfs_directory.cxx
index 5f7c70e..dd5c103 100644
--- a/ucb/source/ucp/gvfs/gvfs_directory.cxx
+++ b/ucb/source/ucp/gvfs/gvfs_directory.cxx
@@ -78,7 +78,7 @@ struct ResultListEntry
uno::Reference< sdbc::XRow > xRow;
GnomeVFSFileInfo aInfo;
- ResultListEntry( const GnomeVFSFileInfo *fileInfo)
+ explicit ResultListEntry( const GnomeVFSFileInfo *fileInfo)
{
gnome_vfs_file_info_copy (&aInfo, fileInfo);
}
diff --git a/ucb/source/ucp/gvfs/gvfs_provider.cxx b/ucb/source/ucp/gvfs/gvfs_provider.cxx
index b637223..68789c0 100644
--- a/ucb/source/ucp/gvfs/gvfs_provider.cxx
+++ b/ucb/source/ucp/gvfs/gvfs_provider.cxx
@@ -145,9 +145,8 @@ ContentProvider::queryContent(
//============================ shlib entry points =============================================
-extern "C" SAL_DLLPUBLIC_EXPORT void * SAL_CALL ucpgvfs1_component_getFactory( const sal_Char *pImplName,
- void *pServiceManager,
- void */*pRegistryKey*/ )
+extern "C" SAL_DLLPUBLIC_EXPORT void * SAL_CALL ucpgvfs1_component_getFactory(
+ const sal_Char *pImplName, void* pServiceManager, void* /*pRegistryKey*/)
{
void * pRet = 0;
diff --git a/ucb/source/ucp/hierarchy/hierarchycontent.hxx b/ucb/source/ucp/hierarchy/hierarchycontent.hxx
index 12d60d9..23f5c1c 100644
--- a/ucb/source/ucp/hierarchy/hierarchycontent.hxx
+++ b/ucb/source/ucp/hierarchy/hierarchycontent.hxx
@@ -59,13 +59,13 @@ class HierarchyContentProperties
public:
HierarchyContentProperties() {};
- HierarchyContentProperties( const HierarchyEntryData::Type & rType )
+ explicit HierarchyContentProperties( const HierarchyEntryData::Type & rType )
: m_aData( rType ),
m_aContentType( rType == HierarchyEntryData::FOLDER
? OUString( HIERARCHY_FOLDER_CONTENT_TYPE )
: OUString( HIERARCHY_LINK_CONTENT_TYPE ) ) {}
- HierarchyContentProperties( const HierarchyEntryData & rData )
+ explicit HierarchyContentProperties( const HierarchyEntryData & rData )
: m_aData( rData ),
m_aContentType( rData.getType() == HierarchyEntryData::FOLDER
? OUString( HIERARCHY_FOLDER_CONTENT_TYPE )
diff --git a/ucb/source/ucp/hierarchy/hierarchydata.hxx b/ucb/source/ucp/hierarchy/hierarchydata.hxx
index f6e00e4..15fe58d 100644
--- a/ucb/source/ucp/hierarchy/hierarchydata.hxx
+++ b/ucb/source/ucp/hierarchy/hierarchydata.hxx
@@ -45,7 +45,7 @@ public:
enum Type { NONE, LINK, FOLDER };
HierarchyEntryData() : m_aType( NONE ) {}
- HierarchyEntryData( const Type & rType ) : m_aType( rType ) {}
+ explicit HierarchyEntryData( const Type & rType ) : m_aType( rType ) {}
const OUString & getName() const { return m_aName; }
void setName( const OUString & rName ) { m_aName = rName; }
diff --git a/ucb/source/ucp/hierarchy/hierarchydatasource.hxx b/ucb/source/ucp/hierarchy/hierarchydatasource.hxx
index 4a695a7..1ec3837 100644
--- a/ucb/source/ucp/hierarchy/hierarchydatasource.hxx
+++ b/ucb/source/ucp/hierarchy/hierarchydatasource.hxx
@@ -47,7 +47,7 @@ class HierarchyDataSource : public cppu::OWeakObject,
cppu::OInterfaceContainerHelper * m_pDisposeEventListeners;
public:
- HierarchyDataSource( const css::uno::Reference< css::uno::XComponentContext > & rxContext );
+ explicit HierarchyDataSource( const css::uno::Reference< css::uno::XComponentContext > & rxContext );
virtual ~HierarchyDataSource();
// XInterface
diff --git a/ucb/source/ucp/hierarchy/hierarchydatasupplier.cxx b/ucb/source/ucp/hierarchy/hierarchydatasupplier.cxx
index 38bd19a..dd3e1bf 100644
--- a/ucb/source/ucp/hierarchy/hierarchydatasupplier.cxx
+++ b/ucb/source/ucp/hierarchy/hierarchydatasupplier.cxx
@@ -50,7 +50,7 @@ struct ResultListEntry
uno::Reference< sdbc::XRow > xRow;
HierarchyEntryData aData;
- ResultListEntry( const HierarchyEntryData& rEntry ) : aData( rEntry ) {}
+ explicit ResultListEntry( const HierarchyEntryData& rEntry ) : aData( rEntry ) {}
};
diff --git a/ucb/source/ucp/hierarchy/hierarchyprovider.hxx b/ucb/source/ucp/hierarchy/hierarchyprovider.hxx
index dec90be..c33795e 100644
--- a/ucb/source/ucp/hierarchy/hierarchyprovider.hxx
+++ b/ucb/source/ucp/hierarchy/hierarchyprovider.hxx
@@ -76,7 +76,7 @@ class HierarchyContentProvider : public ::ucbhelper::ContentProviderImplHelper,
com::sun::star::util::XOfficeInstallationDirectories > m_xOfficeInstDirs;
public:
- HierarchyContentProvider(
+ explicit HierarchyContentProvider(
const com::sun::star::uno::Reference<
com::sun::star::uno::XComponentContext >& rxContext );
virtual ~HierarchyContentProvider();
diff --git a/ucb/source/ucp/package/pkgcontent.hxx b/ucb/source/ucp/package/pkgcontent.hxx
index 9e03fdb..b784cb6 100644
--- a/ucb/source/ucp/package/pkgcontent.hxx
+++ b/ucb/source/ucp/package/pkgcontent.hxx
@@ -86,7 +86,7 @@ struct ContentProperties
bCompressed( true ), bEncrypted( false ),
bHasEncryptedEntries( false ) {}
- ContentProperties( const OUString& rContentType );
+ explicit ContentProperties( const OUString& rContentType );
com::sun::star::uno::Sequence< com::sun::star::ucb::ContentInfo >
getCreatableContentsInfo( PackageUri const & rUri ) const;
diff --git a/ucb/source/ucp/package/pkgdatasupplier.cxx b/ucb/source/ucp/package/pkgdatasupplier.cxx
index 9bb4509..fa02008 100644
--- a/ucb/source/ucp/package/pkgdatasupplier.cxx
+++ b/ucb/source/ucp/package/pkgdatasupplier.cxx
@@ -55,7 +55,7 @@ struct ResultListEntry
uno::Reference< ucb::XContent > xContent;
uno::Reference< sdbc::XRow > xRow;
- ResultListEntry( const OUString& rURL ) : aURL( rURL ) {}
+ explicit ResultListEntry( const OUString& rURL ) : aURL( rURL ) {}
};
diff --git a/ucb/source/ucp/package/pkgprovider.hxx b/ucb/source/ucp/package/pkgprovider.hxx
index 6fc6a70..1f92241 100644
--- a/ucb/source/ucp/package/pkgprovider.hxx
+++ b/ucb/source/ucp/package/pkgprovider.hxx
@@ -55,7 +55,7 @@ class ContentProvider : public ::ucbhelper::ContentProviderImplHelper
Packages* m_pPackages;
public:
- ContentProvider( const ::com::sun::star::uno::Reference<
+ explicit ContentProvider( const ::com::sun::star::uno::Reference<
::com::sun::star::uno::XComponentContext >& rxContext );
virtual ~ContentProvider();
diff --git a/ucb/source/ucp/package/pkguri.hxx b/ucb/source/ucp/package/pkguri.hxx
index edd6fee..b9e674a 100644
--- a/ucb/source/ucp/package/pkguri.hxx
+++ b/ucb/source/ucp/package/pkguri.hxx
@@ -48,7 +48,7 @@ private:
public:
PackageUri() : m_bValid( false ) {}
- PackageUri( const OUString & rPackageUri )
+ explicit PackageUri( const OUString & rPackageUri )
: m_aUri( rPackageUri ), m_bValid( false ) {}
bool isValid() const
diff --git a/ucb/source/ucp/tdoc/tdoc_datasupplier.cxx b/ucb/source/ucp/tdoc/tdoc_datasupplier.cxx
index 2869de6..ecf725c 100644
--- a/ucb/source/ucp/tdoc/tdoc_datasupplier.cxx
+++ b/ucb/source/ucp/tdoc/tdoc_datasupplier.cxx
@@ -51,7 +51,7 @@ struct ResultListEntry
uno::Reference< ucb::XContent > xContent;
uno::Reference< sdbc::XRow > xRow;
- ResultListEntry( const OUString& rURL ) : aURL( rURL ) {}
+ explicit ResultListEntry( const OUString& rURL ) : aURL( rURL ) {}
};
diff --git a/ucb/source/ucp/tdoc/tdoc_docmgr.hxx b/ucb/source/ucp/tdoc/tdoc_docmgr.hxx
index 9d445ec..544ed99 100644
--- a/ucb/source/ucp/tdoc/tdoc_docmgr.hxx
+++ b/ucb/source/ucp/tdoc/tdoc_docmgr.hxx
@@ -90,7 +90,7 @@ namespace tdoc_ucp {
{
public:
- OfficeDocumentsCloseListener( OfficeDocumentsManager * pMgr )
+ explicit OfficeDocumentsCloseListener( OfficeDocumentsManager * pMgr )
: m_pManager( pMgr ) {}
// util::XCloseListener
diff --git a/ucb/source/ucp/tdoc/tdoc_documentcontentfactory.hxx b/ucb/source/ucp/tdoc/tdoc_documentcontentfactory.hxx
index 633f080..0712eeb 100644
--- a/ucb/source/ucp/tdoc/tdoc_documentcontentfactory.hxx
+++ b/ucb/source/ucp/tdoc/tdoc_documentcontentfactory.hxx
@@ -34,7 +34,7 @@ class DocumentContentFactory :
com::sun::star::lang::XServiceInfo >
{
public:
- DocumentContentFactory( const com::sun::star::uno::Reference<
+ explicit DocumentContentFactory( const com::sun::star::uno::Reference<
com::sun::star::lang::XMultiServiceFactory >& rXSMgr );
virtual ~DocumentContentFactory();
diff --git a/ucb/source/ucp/tdoc/tdoc_passwordrequest.cxx b/ucb/source/ucp/tdoc/tdoc_passwordrequest.cxx
index 96838fe..9fb89cd 100644
--- a/ucb/source/ucp/tdoc/tdoc_passwordrequest.cxx
+++ b/ucb/source/ucp/tdoc/tdoc_passwordrequest.cxx
@@ -40,8 +40,8 @@ namespace tdoc_ucp
public task::XInteractionPassword
{
public:
- InteractionSupplyPassword( ucbhelper::InteractionRequest * pRequest )
- : InteractionContinuation( pRequest ) {}
+ explicit InteractionSupplyPassword( ucbhelper::InteractionRequest * pRequest )
+ : InteractionContinuation( pRequest ) {}
// XInterface
virtual uno::Any SAL_CALL queryInterface( const uno::Type & rType )
diff --git a/ucb/source/ucp/tdoc/tdoc_provider.hxx b/ucb/source/ucp/tdoc/tdoc_provider.hxx
index e885549..c2a212e 100644
--- a/ucb/source/ucp/tdoc/tdoc_provider.hxx
+++ b/ucb/source/ucp/tdoc/tdoc_provider.hxx
@@ -62,7 +62,7 @@ class ContentProvider :
public OfficeDocumentsEventListener
{
public:
- ContentProvider( const com::sun::star::uno::Reference<
+ explicit ContentProvider( const com::sun::star::uno::Reference<
com::sun::star::uno::XComponentContext >& rxContext );
virtual ~ContentProvider();
diff --git a/ucb/source/ucp/tdoc/tdoc_stgelems.hxx b/ucb/source/ucp/tdoc/tdoc_stgelems.hxx
index 8be3935..3bb99a6 100644
--- a/ucb/source/ucp/tdoc/tdoc_stgelems.hxx
+++ b/ucb/source/ucp/tdoc/tdoc_stgelems.hxx
@@ -283,7 +283,7 @@ public:
com::sun::star::uno::RuntimeException, std::exception ) SAL_OVERRIDE;
private:
- Storage( const rtl::Reference< Storage > & rFactory ); // n.i.
+ explicit Storage( const rtl::Reference< Storage > & rFactory ); // n.i.
rtl::Reference< StorageElementFactory > m_xFactory;
com::sun::star::uno::Reference<
diff --git a/ucb/source/ucp/webdav-neon/DAVException.hxx b/ucb/source/ucp/webdav-neon/DAVException.hxx
index a9e09b0..b2f878e 100644
--- a/ucb/source/ucp/webdav-neon/DAVException.hxx
+++ b/ucb/source/ucp/webdav-neon/DAVException.hxx
@@ -145,7 +145,7 @@ class DAVException : public std::exception
sal_uInt16 mStatusCode;
public:
- DAVException( ExceptionCode inExceptionCode ) :
+ explicit DAVException( ExceptionCode inExceptionCode ) :
mExceptionCode( inExceptionCode ), mStatusCode( SC_NONE ) {};
DAVException( ExceptionCode inExceptionCode,
const OUString & rData ) :
diff --git a/ucb/source/ucp/webdav-neon/DAVResource.hxx b/ucb/source/ucp/webdav-neon/DAVResource.hxx
index 98e3488..20c0e6a 100644
--- a/ucb/source/ucp/webdav-neon/DAVResource.hxx
+++ b/ucb/source/ucp/webdav-neon/DAVResource.hxx
@@ -53,7 +53,7 @@ struct DAVResource
std::vector< DAVPropertyValue > properties;
DAVResource() {}
- DAVResource( const OUString & inUri ) : uri( inUri ) {}
+ explicit DAVResource( const OUString & inUri ) : uri( inUri ) {}
};
struct DAVResourceInfo
@@ -61,7 +61,7 @@ struct DAVResourceInfo
OUString uri;
std::vector < OUString > properties;
- DAVResourceInfo( const OUString & inUri ) : uri( inUri ) {}
+ explicit DAVResourceInfo( const OUString & inUri ) : uri( inUri ) {}
};
} // namespace webdav_ucp
diff --git a/ucb/source/ucp/webdav-neon/DAVSession.hxx b/ucb/source/ucp/webdav-neon/DAVSession.hxx
index c75ce7e..d700b1b 100644
--- a/ucb/source/ucp/webdav-neon/DAVSession.hxx
+++ b/ucb/source/ucp/webdav-neon/DAVSession.hxx
@@ -200,7 +200,7 @@ public:
protected:
rtl::Reference< DAVSessionFactory > m_xFactory;
- DAVSession( rtl::Reference< DAVSessionFactory > const & rFactory )
+ explicit DAVSession( rtl::Reference< DAVSessionFactory > const & rFactory )
: m_xFactory( rFactory ), m_nRefCount( 0 ) {}
virtual ~DAVSession() {}
diff --git a/ucb/source/ucp/webdav-neon/NeonLockStore.cxx b/ucb/source/ucp/webdav-neon/NeonLockStore.cxx
index 5d7d35f..df90a25 100644
--- a/ucb/source/ucp/webdav-neon/NeonLockStore.cxx
+++ b/ucb/source/ucp/webdav-neon/NeonLockStore.cxx
@@ -47,9 +47,11 @@ class TickerThread : public salhelper::Thread
public:
- TickerThread( NeonLockStore & rLockStore )
- : Thread( "NeonTickerThread" ), m_bFinish( false ),
- m_rLockStore( rLockStore ) {}
+ explicit TickerThread( NeonLockStore & rLockStore )
+ : Thread( "NeonTickerThread" ), m_bFinish( false )
+ , m_rLockStore( rLockStore )
+ {
+ }
void finish() { m_bFinish = true; }
diff --git a/ucb/source/ucp/webdav-neon/NeonSession.cxx b/ucb/source/ucp/webdav-neon/NeonSession.cxx
index 6f1f81a..535abde 100644
--- a/ucb/source/ucp/webdav-neon/NeonSession.cxx
+++ b/ucb/source/ucp/webdav-neon/NeonSession.cxx
@@ -164,11 +164,11 @@ struct NeonRequestContext
const std::vector< OUString > * pHeaderNames;
DAVResource * pResource;
- NeonRequestContext( uno::Reference< io::XOutputStream > & xOutStrm )
+ explicit NeonRequestContext( uno::Reference< io::XOutputStream > & xOutStrm )
: xOutputStream( xOutStrm ), xInputStream( 0 ),
pHeaderNames( 0 ), pResource( 0 ) {}
- NeonRequestContext( const rtl::Reference< NeonInputStream > & xInStrm )
+ explicit NeonRequestContext( const rtl::Reference< NeonInputStream > & xInStrm )
: xOutputStream( 0 ), xInputStream( xInStrm ),
pHeaderNames( 0 ), pResource( 0 ) {}
diff --git a/ucb/source/ucp/webdav-neon/NeonUri.hxx b/ucb/source/ucp/webdav-neon/NeonUri.hxx
index 214a561..9fedb88 100644
--- a/ucb/source/ucp/webdav-neon/NeonUri.hxx
+++ b/ucb/source/ucp/webdav-neon/NeonUri.hxx
@@ -55,8 +55,8 @@ class NeonUri
void calculateURI ();
public:
- NeonUri( const OUString & inUri ) throw ( DAVException );
- NeonUri( const ne_uri * inUri ) throw ( DAVException );
+ explicit NeonUri( const OUString & inUri ) throw ( DAVException );
+ explicit NeonUri( const ne_uri * inUri ) throw ( DAVException );
~NeonUri( );
bool operator== ( const NeonUri & rOther ) const;
diff --git a/ucb/source/ucp/webdav-neon/webdavdatasupplier.cxx b/ucb/source/ucp/webdav-neon/webdavdatasupplier.cxx
index a01b1a0..8f718a0 100644
--- a/ucb/source/ucp/webdav-neon/webdavdatasupplier.cxx
+++ b/ucb/source/ucp/webdav-neon/webdavdatasupplier.cxx
@@ -64,7 +64,7 @@ struct ResultListEntry
uno::Reference< sdbc::XRow > xRow;
boost::shared_ptr<ContentProperties> const pData;
- ResultListEntry(boost::shared_ptr<ContentProperties> const& pEntry)
+ explicit ResultListEntry(boost::shared_ptr<ContentProperties> const& pEntry)
: pData(pEntry)
{}
};
diff --git a/ucb/source/ucp/webdav-neon/webdavprovider.hxx b/ucb/source/ucp/webdav-neon/webdavprovider.hxx
index 5da542d..66eea5d 100644
--- a/ucb/source/ucp/webdav-neon/webdavprovider.hxx
+++ b/ucb/source/ucp/webdav-neon/webdavprovider.hxx
@@ -84,7 +84,7 @@ class ContentProvider : public ::ucbhelper::ContentProviderImplHelper
PropertyMap * m_pProps;
public:
- ContentProvider( const ::com::sun::star::uno::Reference<
+ explicit ContentProvider( const ::com::sun::star::uno::Reference<
::com::sun::star::uno::XComponentContext >& rxContext );
virtual ~ContentProvider();
diff --git a/ucb/source/ucp/webdav/DAVException.hxx b/ucb/source/ucp/webdav/DAVException.hxx
index c4f241e..6aac85f 100644
--- a/ucb/source/ucp/webdav/DAVException.hxx
+++ b/ucb/source/ucp/webdav/DAVException.hxx
@@ -139,7 +139,7 @@ class DAVException : public std::exception
sal_uInt16 mStatusCode;
public:
- DAVException( ExceptionCode inExceptionCode )
+ explicit DAVException( ExceptionCode inExceptionCode )
: mExceptionCode( inExceptionCode )
, mData()
, mStatusCode( SC_NONE )
diff --git a/ucb/source/ucp/webdav/DAVResource.hxx b/ucb/source/ucp/webdav/DAVResource.hxx
index 8639204..77885b0 100644
--- a/ucb/source/ucp/webdav/DAVResource.hxx
+++ b/ucb/source/ucp/webdav/DAVResource.hxx
@@ -45,7 +45,7 @@ struct DAVResource
std::vector< DAVPropertyValue > properties;
DAVResource() {}
- DAVResource( const OUString & inUri ) : uri( inUri ) {}
+ explicit DAVResource( const OUString & inUri ) : uri( inUri ) {}
};
struct DAVResourceInfo
@@ -53,7 +53,7 @@ struct DAVResourceInfo
OUString uri;
std::vector < OUString > properties;
- DAVResourceInfo( const OUString & inUri ) : uri( inUri ) {}
+ explicit DAVResourceInfo( const OUString & inUri ) : uri( inUri ) {}
};
} // namespace http_dav_ucp
diff --git a/ucb/source/ucp/webdav/DAVSession.hxx b/ucb/source/ucp/webdav/DAVSession.hxx
index 45a1383..0647a54 100644
--- a/ucb/source/ucp/webdav/DAVSession.hxx
+++ b/ucb/source/ucp/webdav/DAVSession.hxx
@@ -193,8 +193,8 @@ public:
protected:
rtl::Reference< DAVSessionFactory > m_xFactory;
- DAVSession( rtl::Reference< DAVSessionFactory > const & rFactory )
- : m_xFactory( rFactory ), m_nRefCount( 0 ) {}
+ explicit DAVSession( rtl::Reference< DAVSessionFactory > const & rFactory )
+ : m_xFactory( rFactory ), m_nRefCount( 0 ) {}
virtual ~DAVSession() {}
diff --git a/ucb/source/ucp/webdav/SerfLockStore.cxx b/ucb/source/ucp/webdav/SerfLockStore.cxx
index 5314cee..daee2d2 100644
--- a/ucb/source/ucp/webdav/SerfLockStore.cxx
+++ b/ucb/source/ucp/webdav/SerfLockStore.cxx
@@ -34,8 +34,8 @@ class TickerThread : public osl::Thread
public:
- TickerThread( SerfLockStore & rLockStore )
- : osl::Thread(), m_bFinish( false ), m_rLockStore( rLockStore ) {}
+ explicit TickerThread( SerfLockStore & rLockStore )
+ : osl::Thread(), m_bFinish( false ), m_rLockStore( rLockStore ) {}
void finish() { m_bFinish = true; }
diff --git a/ucb/source/ucp/webdav/SerfUri.hxx b/ucb/source/ucp/webdav/SerfUri.hxx
index dc88d74..b7a1454 100644
--- a/ucb/source/ucp/webdav/SerfUri.hxx
+++ b/ucb/source/ucp/webdav/SerfUri.hxx
@@ -50,8 +50,8 @@ class SerfUri
void calculateURI ();
public:
- SerfUri( const OUString & inUri ) throw ( DAVException );
- SerfUri( const apr_uri_t * inUri ) throw ( DAVException );
+ explicit SerfUri( const OUString & inUri ) throw ( DAVException );
+ explicit SerfUri( const apr_uri_t * inUri ) throw ( DAVException );
~SerfUri( );
bool operator== ( const SerfUri & rOther ) const;
diff --git a/ucb/source/ucp/webdav/webdavdatasupplier.cxx b/ucb/source/ucp/webdav/webdavdatasupplier.cxx
index 1114f4d..89f50cb 100644
--- a/ucb/source/ucp/webdav/webdavdatasupplier.cxx
+++ b/ucb/source/ucp/webdav/webdavdatasupplier.cxx
@@ -47,7 +47,7 @@ struct ResultListEntry
uno::Reference< sdbc::XRow > xRow;
const ContentProperties* pData;
- ResultListEntry( const ContentProperties* pEntry ) : pData( pEntry ) {};
+ explicit ResultListEntry( const ContentProperties* pEntry ) : pData( pEntry ) {}
~ResultListEntry() { delete pData; }
};
diff --git a/ucb/source/ucp/webdav/webdavprovider.hxx b/ucb/source/ucp/webdav/webdavprovider.hxx
index 78cfa6c..d0c40e0 100644
--- a/ucb/source/ucp/webdav/webdavprovider.hxx
+++ b/ucb/source/ucp/webdav/webdavprovider.hxx
@@ -72,7 +72,7 @@ class ContentProvider : public ::ucbhelper::ContentProviderImplHelper
PropertyMap * m_pProps;
public:
- ContentProvider( const ::com::sun::star::uno::Reference<
+ explicit ContentProvider( const ::com::sun::star::uno::Reference<
::com::sun::star::uno::XComponentContext >& rContext );
virtual ~ContentProvider();
diff --git a/ucb/source/ucp/webdav/webdavresponseparser.cxx b/ucb/source/ucp/webdav/webdavresponseparser.cxx
index ca485d1..549b19d 100644
--- a/ucb/source/ucp/webdav/webdavresponseparser.cxx
+++ b/ucb/source/ucp/webdav/webdavresponseparser.cxx
@@ -352,7 +352,7 @@ namespace
}
public:
- WebDAVResponseParser(WebDAVResponseParserMode eWebDAVResponseParserMode);
+ explicit WebDAVResponseParser(WebDAVResponseParserMode eWebDAVResponseParserMode);
virtual ~WebDAVResponseParser();
// Methods XDocumentHandler
diff --git a/ucbhelper/source/client/content.cxx b/ucbhelper/source/client/content.cxx
index f0f0572..1f38a8c 100644
--- a/ucbhelper/source/client/content.cxx
+++ b/ucbhelper/source/client/content.cxx
@@ -140,8 +140,8 @@ class ContentEventListener_Impl : public cppu::OWeakObject,
Content_Impl& m_rContent;
public:
- ContentEventListener_Impl( Content_Impl& rContent )
- : m_rContent( rContent ) {}
+ explicit ContentEventListener_Impl( Content_Impl& rContent )
+ : m_rContent( rContent ) {}
// XInterface
virtual css::uno::Any SAL_CALL queryInterface( const css::uno::Type & rType )
diff --git a/ucbhelper/source/client/proxydecider.cxx b/ucbhelper/source/client/proxydecider.cxx
index 5f2bf5c..2faff93 100644
--- a/ucbhelper/source/client/proxydecider.cxx
+++ b/ucbhelper/source/client/proxydecider.cxx
@@ -62,7 +62,7 @@ private:
OString m_aWildString;
public:
- WildCard( const OUString& rWildCard )
+ explicit WildCard( const OUString& rWildCard )
: m_aWildString(
OUStringToOString(
rWildCard, RTL_TEXTENCODING_UTF8 ).toAsciiLowerCase() ) {}
@@ -133,7 +133,7 @@ private:
sal_Int32 nPort,
bool bUseFullyQualified ) const;
public:
- InternetProxyDecider_Impl(
+ explicit InternetProxyDecider_Impl(
const uno::Reference< uno::XComponentContext >& rxContext );
virtual ~InternetProxyDecider_Impl();
diff --git a/ucbhelper/source/provider/contenthelper.cxx b/ucbhelper/source/provider/contenthelper.cxx
index 280d242..7621e8e 100644
--- a/ucbhelper/source/provider/contenthelper.cxx
+++ b/ucbhelper/source/provider/contenthelper.cxx
@@ -46,7 +46,7 @@ class PropertyEventSequence
sal_uInt32 m_nPos;
public:
- PropertyEventSequence( sal_uInt32 nSize )
+ explicit PropertyEventSequence( sal_uInt32 nSize )
: m_aSeq( nSize ), m_nPos( 0 ) {};
void append( const beans::PropertyChangeEvent& rEvt )
diff --git a/ucbhelper/source/provider/contentidentifier.cxx b/ucbhelper/source/provider/contentidentifier.cxx
index b95d3f4..b8f8cbc 100644
--- a/ucbhelper/source/provider/contentidentifier.cxx
+++ b/ucbhelper/source/provider/contentidentifier.cxx
@@ -51,7 +51,7 @@ struct ContentIdentifier_Impl
OUString m_aProviderScheme;
osl::Mutex m_aMutex;
- ContentIdentifier_Impl( const OUString& rURL );
+ explicit ContentIdentifier_Impl( const OUString& rURL );
};
diff --git a/ucbhelper/source/provider/interactionrequest.cxx b/ucbhelper/source/provider/interactionrequest.cxx
index c36c2a6..6815a11 100644
--- a/ucbhelper/source/provider/interactionrequest.cxx
+++ b/ucbhelper/source/provider/interactionrequest.cxx
@@ -53,7 +53,7 @@ struct InteractionRequest_Impl
com::sun::star::task::XInteractionContinuation > > m_aContinuations;
InteractionRequest_Impl() {}
- InteractionRequest_Impl( const uno::Any & rRequest )
+ explicit InteractionRequest_Impl( const uno::Any & rRequest )
: m_aRequest( rRequest ) {}
};
@@ -196,13 +196,8 @@ InteractionRequest::getContinuations()
}
-
-
// InteractionContinuation Implementation.
-
-
-
namespace ucbhelper
{
@@ -210,7 +205,7 @@ struct InteractionContinuation_Impl
{
InteractionRequest * m_pRequest;
- InteractionContinuation_Impl( InteractionRequest * pRequest )
+ explicit InteractionContinuation_Impl( InteractionRequest * pRequest )
: m_pRequest( pRequest ) {}
};
diff --git a/ucbhelper/source/provider/resultset.cxx b/ucbhelper/source/provider/resultset.cxx
index 231585c..31617fd 100644
--- a/ucbhelper/source/provider/resultset.cxx
+++ b/ucbhelper/source/provider/resultset.cxx
@@ -128,8 +128,8 @@ typedef cppu::OMultiTypeInterfaceContainerHelperVar<OUString>
class PropertyChangeListeners : public PropertyChangeListenerContainer
{
public:
- PropertyChangeListeners( osl::Mutex& rMtx )
- : PropertyChangeListenerContainer( rMtx ) {}
+ explicit PropertyChangeListeners( osl::Mutex& rMtx )
+ : PropertyChangeListenerContainer( rMtx ) {}
};
} // namespace ucbhelper_impl
diff --git a/ucbhelper/source/provider/resultsetmetadata.cxx b/ucbhelper/source/provider/resultsetmetadata.cxx
index ef2b2ae..5afc296 100644
--- a/ucbhelper/source/provider/resultsetmetadata.cxx
+++ b/ucbhelper/source/provider/resultsetmetadata.cxx
@@ -58,11 +58,11 @@ struct ResultSetMetaData_Impl
bool m_bObtainedTypes;
bool m_bGlobalReadOnlyValue;
- ResultSetMetaData_Impl( sal_Int32 nSize )
+ explicit ResultSetMetaData_Impl( sal_Int32 nSize )
: m_aColumnData( nSize ), m_bObtainedTypes( false ),
m_bGlobalReadOnlyValue( true ) {}
- ResultSetMetaData_Impl(
+ explicit ResultSetMetaData_Impl(
const std::vector< ::ucbhelper::ResultSetColumnData >& rColumnData )
: m_aColumnData( rColumnData ), m_bObtainedTypes( false ),
m_bGlobalReadOnlyValue( false ) {}
diff --git a/ucbhelper/source/provider/simplenameclashresolverequest.cxx b/ucbhelper/source/provider/simplenameclashresolverequest.cxx
index 55832d0..39abc5b 100644
--- a/ucbhelper/source/provider/simplenameclashresolverequest.cxx
+++ b/ucbhelper/source/provider/simplenameclashresolverequest.cxx
@@ -40,7 +40,7 @@ class InteractionSupplyName : public InteractionContinuation,
OUString m_aName;
public:
- InteractionSupplyName( InteractionRequest * pRequest )
+ explicit InteractionSupplyName( InteractionRequest * pRequest )
: InteractionContinuation( pRequest ) {}
// XInterface
diff --git a/unoidl/source/sourceprovider-scanner.hxx b/unoidl/source/sourceprovider-scanner.hxx
index 614340e..2b624a8 100644
--- a/unoidl/source/sourceprovider-scanner.hxx
+++ b/unoidl/source/sourceprovider-scanner.hxx
@@ -76,8 +76,8 @@ class SourceProviderPolymorphicStructTypeTemplateEntityPad:
public SourceProviderEntityPad
{
public:
- SourceProviderPolymorphicStructTypeTemplateEntityPad(bool published):
- SourceProviderEntityPad(published)
+ explicit SourceProviderPolymorphicStructTypeTemplateEntityPad(bool published)
+ : SourceProviderEntityPad(published)
{}
std::vector<OUString> typeParameters;
diff --git a/unoidl/source/unoidl-check.cxx b/unoidl/source/unoidl-check.cxx
index 22dff88..c6cdf4c 100644
--- a/unoidl/source/unoidl-check.cxx
+++ b/unoidl/source/unoidl-check.cxx
@@ -140,7 +140,7 @@ OUString showDirection(
}
struct EqualsAnnotation {
- EqualsAnnotation(OUString const & name): name_(name) {}
+ explicit EqualsAnnotation(OUString const & name): name_(name) {}
bool operator ()(unoidl::AnnotatedReference const & ref)
{ return ref.name == name_; }
diff --git a/unotools/source/config/configitem.cxx b/unotools/source/config/configitem.cxx
index 0d055ec..e05d960 100644
--- a/unotools/source/config/configitem.cxx
+++ b/unotools/source/config/configitem.cxx
@@ -100,14 +100,16 @@ class ValueCounter_Impl
{
sal_Int16& rCnt;
public:
- ValueCounter_Impl(sal_Int16& rCounter):
- rCnt(rCounter)
- {rCnt++;}
+ explicit ValueCounter_Impl(sal_Int16& rCounter)
+ : rCnt(rCounter)
+ {
+ rCnt++;
+ }
~ValueCounter_Impl()
- {
- OSL_ENSURE(rCnt>0, "RefCount < 0 ??");
- rCnt--;
- }
+ {
+ OSL_ENSURE(rCnt>0, "RefCount < 0 ??");
+ rCnt--;
+ }
};
ConfigChangeListener_Impl::ConfigChangeListener_Impl(
diff --git a/unotools/source/config/configvaluecontainer.cxx b/unotools/source/config/configvaluecontainer.cxx
index 7121e06..6ec6913 100644
--- a/unotools/source/config/configvaluecontainer.cxx
+++ b/unotools/source/config/configvaluecontainer.cxx
@@ -51,7 +51,7 @@ namespace utl
Type aDataType; // the type object pointed to by pLocation
public:
- NodeValueAccessor( const OUString& _rNodePath );
+ explicit NodeValueAccessor( const OUString& _rNodePath );
void bind( void* _pLocation, const Type& _rType );
diff --git a/unotools/source/config/fltrcfg.cxx b/unotools/source/config/fltrcfg.cxx
index 34b0fef..20baaaa 100644
--- a/unotools/source/config/fltrcfg.cxx
+++ b/unotools/source/config/fltrcfg.cxx
@@ -63,7 +63,7 @@ protected:
virtual void ImplCommit() SAL_OVERRIDE;
public:
- SvtAppFilterOptions_Impl(const OUString& rRoot) :
+ explicit SvtAppFilterOptions_Impl(const OUString& rRoot) :
utl::ConfigItem(rRoot),
bLoadVBA(false),
bSaveVBA(false) {}
@@ -137,7 +137,7 @@ private:
virtual void ImplCommit() SAL_OVERRIDE;
public:
- SvtWriterFilterOptions_Impl(const OUString& rRoot) :
+ explicit SvtWriterFilterOptions_Impl(const OUString& rRoot) :
SvtAppFilterOptions_Impl(rRoot),
bLoadExecutable(false)
{}
@@ -185,7 +185,7 @@ private:
virtual void ImplCommit() SAL_OVERRIDE;
public:
- SvtCalcFilterOptions_Impl(const OUString& rRoot) :
+ explicit SvtCalcFilterOptions_Impl(const OUString& rRoot) :
SvtAppFilterOptions_Impl(rRoot),
bLoadExecutable(false)
{}
diff --git a/unotools/source/config/useroptions.cxx b/unotools/source/config/useroptions.cxx
index 1e0efb8..424b2be 100644
--- a/unotools/source/config/useroptions.cxx
+++ b/unotools/source/config/useroptions.cxx
@@ -73,7 +73,7 @@ std::weak_ptr<SvtUserOptions::Impl> SvtUserOptions::xSharedImpl;
class SvtUserOptions::ChangeListener : public cppu::WeakImplHelper1<util::XChangesListener>
{
public:
- ChangeListener (Impl& rParent): m_rParent(rParent) { }
+ explicit ChangeListener (Impl& rParent): m_rParent(rParent) { }
// XChangesListener
virtual void SAL_CALL changesOccurred (util::ChangesEvent const& Event) throw(uno::RuntimeException, std::exception) SAL_OVERRIDE;
diff --git a/unotools/source/config/viewoptions.cxx b/unotools/source/config/viewoptions.cxx
index 9f078e1..95282f0 100644
--- a/unotools/source/config/viewoptions.cxx
+++ b/unotools/source/config/viewoptions.cxx
@@ -91,7 +91,7 @@ class SvtViewOptionsBase_Impl
public:
enum State { STATE_NONE, STATE_FALSE, STATE_TRUE };
- SvtViewOptionsBase_Impl ( const OUString& sList );
+ explicit SvtViewOptionsBase_Impl(const OUString& rList);
virtual ~SvtViewOptionsBase_Impl ( );
bool Exists ( const OUString& sName );
bool Delete ( const OUString& sName );
diff --git a/unotools/source/misc/closeveto.cxx b/unotools/source/misc/closeveto.cxx
index b33ef29..c8e68c2 100644
--- a/unotools/source/misc/closeveto.cxx
+++ b/unotools/source/misc/closeveto.cxx
@@ -51,7 +51,7 @@ namespace utl
class CloseListener_Impl : public CloseListener_Base
{
public:
- CloseListener_Impl(bool const bHasOwnership)
+ explicit CloseListener_Impl(bool const bHasOwnership)
: m_bHasOwnership(bHasOwnership)
{
}
diff --git a/unotools/source/misc/componentresmodule.cxx b/unotools/source/misc/componentresmodule.cxx
index 7b75a86..74af55a 100644
--- a/unotools/source/misc/componentresmodule.cxx
+++ b/unotools/source/misc/componentresmodule.cxx
@@ -42,7 +42,7 @@ namespace utl
OComponentResModuleImpl& operator=(const OComponentResModuleImpl&) SAL_DELETED_FUNCTION;
public:
- OComponentResModuleImpl( const OString& _rResFilePrefix )
+ explicit OComponentResModuleImpl( const OString& _rResFilePrefix )
:m_pResources( NULL )
,m_bInitialized( false )
,m_sResFilePrefix( _rResFilePrefix )
diff --git a/unotools/source/misc/fontcvt.cxx b/unotools/source/misc/fontcvt.cxx
index a154e05..c276127 100644
--- a/unotools/source/misc/fontcvt.cxx
+++ b/unotools/source/misc/fontcvt.cxx
@@ -1032,7 +1032,7 @@ class StarSymbolToMSMultiFontImpl : public StarSymbolToMSMultiFont
private:
::std::multimap<sal_Unicode, SymbolEntry> maMagicMap;
public:
- StarSymbolToMSMultiFontImpl(bool bPerfectOnly);
+ explicit StarSymbolToMSMultiFontImpl(bool bPerfectOnly);
OUString ConvertChar(sal_Unicode &rChar) SAL_OVERRIDE;
OUString ConvertString(OUString &rString, sal_Int32& rIndex) SAL_OVERRIDE;
};
diff --git a/unotools/source/misc/sharedunocomponent.cxx b/unotools/source/misc/sharedunocomponent.cxx
index 7d78e06..c29dce8 100644
--- a/unotools/source/misc/sharedunocomponent.cxx
+++ b/unotools/source/misc/sharedunocomponent.cxx
@@ -75,7 +75,7 @@ namespace utl
CloseableComponentImpl& operator=(const CloseableComponentImpl&) SAL_DELETED_FUNCTION;
public:
- CloseableComponentImpl( const Reference< XInterface >& _rxComponent );
+ explicit CloseableComponentImpl( const Reference< XInterface >& _rxComponent );
/** closes the component
diff --git a/unotools/source/ucbhelper/XTempFile.hxx b/unotools/source/ucbhelper/XTempFile.hxx
index a2ed5e5..f8048fc 100644
--- a/unotools/source/ucbhelper/XTempFile.hxx
+++ b/unotools/source/ucbhelper/XTempFile.hxx
@@ -61,7 +61,7 @@ protected:
void checkConnected ();
public:
- OTempFileService (::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext > const & context);
+ explicit OTempFileService (::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext > const & context);
//Methods
// XInterface
diff --git a/unotools/source/ucbhelper/ucblockbytes.cxx b/unotools/source/ucbhelper/ucblockbytes.cxx
index be090bc..513757e 100644
--- a/unotools/source/ucbhelper/ucblockbytes.cxx
+++ b/unotools/source/ucbhelper/ucblockbytes.cxx
@@ -75,9 +75,9 @@ class UcbDataSink_Impl : public ::cppu::WeakImplHelper2< XActiveDataControl, XAc
UcbLockBytesRef m_xLockBytes;
public:
- UcbDataSink_Impl( UcbLockBytes* pLockBytes )
- : m_xLockBytes( pLockBytes )
- {}
+ explicit UcbDataSink_Impl( UcbLockBytes* pLockBytes )
+ : m_xLockBytes( pLockBytes )
+ {}
// XActiveDataControl.
virtual void SAL_CALL addListener ( const Reference<XStreamListener> &/*rxListener*/) throw(RuntimeException, std::exception) SAL_OVERRIDE {}
@@ -102,9 +102,9 @@ class UcbStreamer_Impl : public ::cppu::WeakImplHelper2< XActiveDataStreamer, XA
UcbLockBytesRef m_xLockBytes;
public:
- UcbStreamer_Impl( UcbLockBytes* pLockBytes )
- : m_xLockBytes( pLockBytes )
- {}
+ explicit UcbStreamer_Impl( UcbLockBytes* pLockBytes )
+ : m_xLockBytes( pLockBytes )
+ {}
// XActiveDataControl.
virtual void SAL_CALL addListener ( const Reference<XStreamListener> &/*rxListener*/) throw(RuntimeException, std::exception) SAL_OVERRIDE {}
@@ -150,9 +150,9 @@ class UcbPropertiesChangeListener_Impl : public ::cppu::WeakImplHelper1< XProper
public:
UcbLockBytesRef m_xLockBytes;
- UcbPropertiesChangeListener_Impl( UcbLockBytesRef rRef )
- : m_xLockBytes( rRef )
- {}
+ explicit UcbPropertiesChangeListener_Impl( UcbLockBytesRef rRef )
+ : m_xLockBytes( rRef )
+ {}
virtual void SAL_CALL disposing ( const EventObject &/*rEvent*/) throw(RuntimeException, std::exception) SAL_OVERRIDE {}
virtual void SAL_CALL propertiesChange ( const Sequence<PropertyChangeEvent> &rEvent) throw(RuntimeException, std::exception) SAL_OVERRIDE;
@@ -341,7 +341,7 @@ class ModeratorsActiveDataStreamer
{
public:
- ModeratorsActiveDataStreamer(Moderator &theModerator);
+ explicit ModeratorsActiveDataStreamer(Moderator &theModerator);
virtual ~ModeratorsActiveDataStreamer();
@@ -377,7 +377,7 @@ class ModeratorsActiveDataSink
{
public:
- ModeratorsActiveDataSink(Moderator &theModerator);
+ explicit ModeratorsActiveDataSink(Moderator &theModerator);
virtual ~ModeratorsActiveDataSink();
@@ -460,7 +460,7 @@ class ModeratorsInteractionHandler
{
public:
- ModeratorsInteractionHandler(Moderator &theModerator);
+ explicit ModeratorsInteractionHandler(Moderator &theModerator);
virtual ~ModeratorsInteractionHandler();
diff --git a/unoxml/source/dom/document.hxx b/unoxml/source/dom/document.hxx
index a4ef13a..4ba221b 100644
--- a/unoxml/source/dom/document.hxx
+++ b/unoxml/source/dom/document.hxx
@@ -85,7 +85,7 @@ namespace DOM
::std::unique_ptr<events::CEventDispatcher> const m_pEventDispatcher;
- CDocument(xmlDocPtr const pDocPtr);
+ explicit CDocument(xmlDocPtr const pDocPtr);
public:
diff --git a/unoxml/source/dom/documentbuilder.hxx b/unoxml/source/dom/documentbuilder.hxx
index e6c4ddb..2d16da2 100644
--- a/unoxml/source/dom/documentbuilder.hxx
+++ b/unoxml/source/dom/documentbuilder.hxx
@@ -59,7 +59,7 @@ namespace DOM
public:
// ctor
- CDocumentBuilder(
+ explicit CDocumentBuilder(
css::uno::Reference< css::lang::XMultiServiceFactory > const&
xFactory);
diff --git a/unoxml/source/dom/elementlist.cxx b/unoxml/source/dom/elementlist.cxx
index 2e76017..8dd8ac7 100644
--- a/unoxml/source/dom/elementlist.cxx
+++ b/unoxml/source/dom/elementlist.cxx
@@ -38,7 +38,7 @@ namespace
css::uno::WeakReference<css::xml::dom::events::XEventListener> mxOwner;
public:
- WeakEventListener(const css::uno::Reference<css::xml::dom::events::XEventListener>& rOwner)
+ explicit WeakEventListener(const css::uno::Reference<css::xml::dom::events::XEventListener>& rOwner)
: mxOwner(rOwner)
{
}
diff --git a/unoxml/source/dom/saxbuilder.hxx b/unoxml/source/dom/saxbuilder.hxx
index 4f2565c..ce8ce13 100644
--- a/unoxml/source/dom/saxbuilder.hxx
+++ b/unoxml/source/dom/saxbuilder.hxx
@@ -80,7 +80,7 @@ namespace DOM
static css::uno::Sequence< OUString > _getSupportedServiceNames();
static css::uno::Reference< XInterface > _getInstance(const css::uno::Reference< css::lang::XMultiServiceFactory >& rSMgr);
- CSAXDocumentBuilder(const css::uno::Reference< css::lang::XMultiServiceFactory >& mgr);
+ explicit CSAXDocumentBuilder(const css::uno::Reference< css::lang::XMultiServiceFactory >& mgr);
// XServiceInfo
virtual OUString SAL_CALL getImplementationName()
diff --git a/unoxml/source/rdf/librdf_repository.cxx b/unoxml/source/rdf/librdf_repository.cxx
index 10f7241..2b20ce0 100644
--- a/unoxml/source/rdf/librdf_repository.cxx
+++ b/unoxml/source/rdf/librdf_repository.cxx
@@ -186,14 +186,14 @@ public:
struct URI : public Resource
{
OString const value;
- URI(OString const& i_rValue)
+ explicit URI(OString const& i_rValue)
: value(i_rValue)
{ }
};
struct BlankNode : public Resource
{
OString const value;
- BlankNode(OString const& i_rValue)
+ explicit BlankNode(OString const& i_rValue)
: value(i_rValue)
{ }
};
@@ -635,7 +635,7 @@ class NodeArrayDeleter : public std::unary_function<librdf_node**, void>
const int m_Count;
public:
- NodeArrayDeleter(int i_Count) : m_Count(i_Count) { }
+ explicit NodeArrayDeleter(int i_Count) : m_Count(i_Count) { }
void operator() (librdf_node** io_pArray) const throw ()
{
diff --git a/unoxml/source/xpath/xpathapi.hxx b/unoxml/source/xpath/xpathapi.hxx
index 52b274d..32b03ee 100644
--- a/unoxml/source/xpath/xpathapi.hxx
+++ b/unoxml/source/xpath/xpathapi.hxx
@@ -65,7 +65,7 @@ namespace XPath
public:
// ctor
- CXPathAPI(
+ explicit CXPathAPI(
const css::uno::Reference< css::lang::XMultiServiceFactory >&
rSMgr);
diff --git a/uui/source/fltdlg.cxx b/uui/source/fltdlg.cxx
index c2135be..24e5476 100644
--- a/uui/source/fltdlg.cxx
+++ b/uui/source/fltdlg.cxx
@@ -168,7 +168,7 @@ bool FilterDialog::AskForFilter( FilterNameListPtr& pSelectedItem )
class StringCalculator : public ::cppu::WeakImplHelper1< ::com::sun::star::util::XStringWidth >
{
public:
- StringCalculator( const OutputDevice* pDevice )
+ explicit StringCalculator( const OutputDevice* pDevice )
: m_pDevice( const_cast< OutputDevice * >( pDevice ) )
{
}
diff --git a/uui/source/fltdlg.hxx b/uui/source/fltdlg.hxx
index 958ad99..df0b8ee 100644
--- a/uui/source/fltdlg.hxx
+++ b/uui/source/fltdlg.hxx
@@ -46,7 +46,7 @@ class FilterDialog : public ModalDialog
{
// public interface
public:
- FilterDialog ( vcl::Window* pParentWindow );
+ explicit FilterDialog(vcl::Window* pParentWindow);
virtual ~FilterDialog();
virtual void dispose() SAL_OVERRIDE;
void SetURL ( const OUString& sURL );
diff --git a/uui/source/iahndl.cxx b/uui/source/iahndl.cxx
index 1f20c31..d16935b 100644
--- a/uui/source/iahndl.cxx
+++ b/uui/source/iahndl.cxx
@@ -112,7 +112,7 @@ namespace {
class HandleData : public osl::Condition
{
public:
- HandleData(
+ explicit HandleData(
uno::Reference< task::XInteractionRequest > const & rRequest)
: osl::Condition(),
m_rRequest(rRequest),
diff --git a/uui/source/iahndl.hxx b/uui/source/iahndl.hxx
index 437d0f2..1059b3c 100644
--- a/uui/source/iahndl.hxx
+++ b/uui/source/iahndl.hxx
@@ -69,8 +69,8 @@ struct InteractionHandlerData
OUString ServiceName;
InteractionHandlerData() {};
- InteractionHandlerData(const OUString & rService)
- : ServiceName( rService ){}
+ explicit InteractionHandlerData(const OUString & rService)
+ : ServiceName( rService ){}
};
typedef std::vector< InteractionHandlerData > InteractionHandlerDataList;
@@ -97,7 +97,7 @@ public:
com::sun::star::uno::Reference<
com::sun::star::awt::XWindow > const & rxWindow,
const OUString & rContextParam);
- UUIInteractionHelper(
+ explicit UUIInteractionHelper(
com::sun::star::uno::Reference<
com::sun::star::uno::XComponentContext > const & rxContext);
@@ -295,9 +295,9 @@ private:
class ErrorResource: private Resource
{
public:
- inline ErrorResource(ResId & rResId): Resource(rResId) {}
+ explicit ErrorResource(ResId & rResId): Resource(rResId) {}
- inline ~ErrorResource() { FreeResource(); }
+ ~ErrorResource() { FreeResource(); }
bool getString(ErrCode nErrorCode, OUString &rString) const;
};
diff --git a/uui/source/interactionhandler.cxx b/uui/source/interactionhandler.cxx
index 4cb9c52..f3984d1 100644
--- a/uui/source/interactionhandler.cxx
+++ b/uui/source/interactionhandler.cxx
@@ -44,7 +44,7 @@ private:
UUIInteractionHelper * m_pImpl;
public:
- UUIInteractionHandler(com::sun::star::uno::Reference<
+ explicit UUIInteractionHandler(com::sun::star::uno::Reference<
com::sun::star::uno::XComponentContext >
const & rxContext);
diff --git a/uui/source/passwordcontainer.hxx b/uui/source/passwordcontainer.hxx
index 6c4542c..04eb55b 100644
--- a/uui/source/passwordcontainer.hxx
+++ b/uui/source/passwordcontainer.hxx
@@ -47,7 +47,7 @@ namespace uui {
class PasswordContainerHelper
{
public:
- PasswordContainerHelper(
+ explicit PasswordContainerHelper(
com::sun::star::uno::Reference<
com::sun::star::uno::XComponentContext > const &
xContext );
diff --git a/uui/source/requeststringresolver.hxx b/uui/source/requeststringresolver.hxx
index f7062ab..4a21456 100644
--- a/uui/source/requeststringresolver.hxx
+++ b/uui/source/requeststringresolver.hxx
@@ -52,7 +52,7 @@ private:
UUIInteractionRequestStringResolver(UUIInteractionRequestStringResolver &) SAL_DELETED_FUNCTION;
void operator =(UUIInteractionRequestStringResolver) SAL_DELETED_FUNCTION;
- UUIInteractionRequestStringResolver(
+ explicit UUIInteractionRequestStringResolver(
com::sun::star::uno::Reference<
com::sun::star::uno::XComponentContext >
const & rxContext);
More information about the Libreoffice-commits
mailing list