[Libreoffice-commits] core.git: Changes to 'feature/lok_cellcursor'

[Andrzej Hunt]

New branch 'feature/lok_cellcursor' available with the following commits:
commit 406ae94057eecec7fe6e7e085eca2d7bd0928b73
Author: Andrzej Hunt <andrzej at ahunt.org>
Date:   Tue Nov 3 10:14:02 2015 +0100

    sc lok: make cell cursor behaviour consistent with desktop
    
    I.e. single click selects cell, typing activates the EditView
    (and hides the cell cursor). (Previously: single click activates
    the edit view, text cursor is shown, and no clean way of hiding
    the cell cursor again.)
    
    Change-Id: I184630277e8935e9f8a97a856191497ec5d62111

commit cdc8b002740b0cb49e90db923cc6881c68c83c5e
Author: Andrzej Hunt <andrzej at ahunt.org>
Date:   Mon Nov 2 13:57:51 2015 +0100

    sc lok: Use cached zoom level for calc text cursor callback too
    
    Previously the text cursor (as opposed to cell cursor) would be
    placed incorrectly if a cell was selected by clicking, due to the
    incorrect zoom level being used. (Note: in gtktiledviewer
    this was only visible when selecting cells after zooming in.)
    
    Change-Id: I87c210c8c4a108e11f762445354fc323fd496da7

commit ad8791f2e2530309eae8df321d05bee644052790
Author: Andrzej Hunt <andrzej at ahunt.org>
Date:   Mon Nov 2 13:24:12 2015 +0100

    sc lok: Cache viewdata zoom and reuse for cursor callback
    
    As of a1605d6860e3c4510177c42ab6d2fda569506f57 we reset the zoom
    level to the default when processing LOK mouse events. The exact
    cell cursor position is dependent on the zoom level (due to the
    rounding in the cell position summing calculations), hence we need
    to make sure we have the correct zoom level for those calculations
    (or else the rounding errors will result in incorrect cell cursor
    positions). Caching the zoom level and reusing it only here seems
    to be the most efficient way of solving this for now.
    
    (An alternative would be to only send the cell ID in the callback,
     and have the frontend then request the pixel positions together
     with the current frontend zoom level - however especially for
     LOOL minimising the number of trips is probably wise.)
    
    Change-Id: Iae3aabfd7ea9bec7057be7b63670885766870c4f

commit 24112a233626416e554f97420cb5f5c235b05b28
Author: Andrzej Hunt <andrzej at ahunt.org>
Date:   Mon Nov 2 11:43:05 2015 +0100

    sc lok: Cell Cursor callback
    
    This only works correctly for the default zoom level - since
    the updateLibreOfficeKitCellCursor call happens during the
    internal / hidden rendering, it uses the internal zoom values,
    which can differ from the tiled-rendering zoom values.
    
    Change-Id: Ie4f344fe771078fca10ad9d6f7a93e88fb93880a