[Libreoffice-commits] core.git: include/cppuhelper

Stephan Bergmann sbergman at redhat.com
Fri Nov 6 07:32:57 PST 2015


 include/cppuhelper/compbase.hxx |    4 ++++
 include/cppuhelper/implbase.hxx |    8 ++++++++
 2 files changed, 12 insertions(+)

New commits:
commit a0be15e5d4747bb335467dba7004e52eceb8fe2a
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Fri Nov 6 16:32:27 2015 +0100

    Note why certain replacements of odd functionality are not there by design
    
    Change-Id: Iaa3110eaea5e295a193642555b7e14ab3fb6ff96

diff --git a/include/cppuhelper/compbase.hxx b/include/cppuhelper/compbase.hxx
index 767e302..0b67044 100644
--- a/include/cppuhelper/compbase.hxx
+++ b/include/cppuhelper/compbase.hxx
@@ -42,6 +42,10 @@ namespace osl { class Mutex; }
 
 #if defined LIBO_INTERNAL_ONLY
 
+// A replacement for WeakAggComponentImplHelper1 has deliberately been left out,
+// as the underlying aggregation mechanism is known broken in general and should
+// not be used.
+
 namespace cppu {
 
 /** Implementation helper implementing interfaces
diff --git a/include/cppuhelper/implbase.hxx b/include/cppuhelper/implbase.hxx
index 37b6a1c..abf00f3 100644
--- a/include/cppuhelper/implbase.hxx
+++ b/include/cppuhelper/implbase.hxx
@@ -38,6 +38,14 @@
 
 #if defined LIBO_INTERNAL_ONLY
 
+// A replacement for ImplHelperN has deliberately been left out, as ImplHelperN
+// is unlikely ever be a better choice htan WeakImplHelper, so all their
+// existing uses are probably confused and should use WeakImplHelper instead.
+//
+// Replacements for WeakAggImplHelperN and AggImplInheritanceHelper1 have
+// deliberately been left out, as the underlying aggregation mechanism is known
+// broken in general and should not be used.
+
 namespace cppu {
 
 /// @cond INTERNAL


More information about the Libreoffice-commits mailing list